You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/04/23 12:22:16 UTC

[GitHub] [hadoop-ozone] elek opened a new pull request #863: HDDS-3461. Add acceptance test to smoketest CSI service startup

elek opened a new pull request #863:
URL: https://github.com/apache/hadoop-ozone/pull/863


   ## What changes were proposed in this pull request?
   
   
   
   Ozone CSI service implement Container Storage Interface specification to provide volumes for container orchestrators such as Yarn and Kubernetes.
   
   We don't have any acceptance test which makes easy to break the classpath / functionality.
   
   As a first step I would create a simple smoketest to check if the csi service can be started and the identitiy service can be called.
   
   ## What is the link to the Apache JIRA
   
   https://issues.apache.org/jira/browse/HDDS-3461
   
   ## How was this patch tested?
   
   With executing `./test.sh` in the `compose/ozone-csi` folder. (Will be part of the acceptance test runs).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org


[GitHub] [hadoop-ozone] elek commented on pull request #863: HDDS-3461. Add acceptance test to smoketest CSI service startup

Posted by GitBox <gi...@apache.org>.
elek commented on pull request #863:
URL: https://github.com/apache/hadoop-ozone/pull/863#issuecomment-630119917


   > So the fix is 0a8b3d6? LGTM.
   
   Yes. CSI socket was missing when we checked it.
   
   Thanks to review it @adoroszlai and @dineshchitlangia Will merge it again.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org


[GitHub] [hadoop-ozone] elek edited a comment on pull request #863: HDDS-3461. Add acceptance test to smoketest CSI service startup

Posted by GitBox <gi...@apache.org>.
elek edited a comment on pull request #863:
URL: https://github.com/apache/hadoop-ozone/pull/863#issuecomment-619214890


   Failed in https://github.com/apache/hadoop-ozone/actions/runs/86963299. Reverted immediately.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org


[GitHub] [hadoop-ozone] elek commented on pull request #863: HDDS-3461. Add acceptance test to smoketest CSI service startup

Posted by GitBox <gi...@apache.org>.
elek commented on pull request #863:
URL: https://github.com/apache/hadoop-ozone/pull/863#issuecomment-619214890


   RevertedFauked 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org


[GitHub] [hadoop-ozone] adoroszlai commented on pull request #863: HDDS-3461. Add acceptance test to smoketest CSI service startup

Posted by GitBox <gi...@apache.org>.
adoroszlai commented on pull request #863:
URL: https://github.com/apache/hadoop-ozone/pull/863#issuecomment-628866401


   > @adoroszlai Problem is fixed. Do you have any concern to recommit it?
   
   So the fix is 0a8b3d68ff3db7a03b634ea68d03db3cc4e1c8fe?  LGTM.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org


[GitHub] [hadoop-ozone] elek closed pull request #863: HDDS-3461. Add acceptance test to smoketest CSI service startup

Posted by GitBox <gi...@apache.org>.
elek closed pull request #863:
URL: https://github.com/apache/hadoop-ozone/pull/863


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org


[GitHub] [hadoop-ozone] elek commented on pull request #863: HDDS-3461. Add acceptance test to smoketest CSI service startup

Posted by GitBox <gi...@apache.org>.
elek commented on pull request #863:
URL: https://github.com/apache/hadoop-ozone/pull/863#issuecomment-625837005


   /ready


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org


[GitHub] [hadoop-ozone] elek commented on pull request #863: HDDS-3461. Add acceptance test to smoketest CSI service startup

Posted by GitBox <gi...@apache.org>.
elek commented on pull request #863:
URL: https://github.com/apache/hadoop-ozone/pull/863#issuecomment-619215210


   /pending Failed in https://github.com/apache/hadoop-ozone/actions/runs/86963299


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org


[GitHub] [hadoop-ozone] elek commented on pull request #863: HDDS-3461. Add acceptance test to smoketest CSI service startup

Posted by GitBox <gi...@apache.org>.
elek commented on pull request #863:
URL: https://github.com/apache/hadoop-ozone/pull/863#issuecomment-618885558


   >  I'd prefer adding csi container to the base ozone environment instead of duplication, but we can discuss that later.
   
   Yeah, I don't know what is the best approach. It seems to be an optional component. Earlier we had a conversation about creating `ozone-minimal` and `ozone-full` containers, but since that, we already added **recon** and *s3g** to the normal cluster as required components.
   
   I think **recon** should be required, s3g is more like a very frequently used optional component. csi seems to be more optional, that's the reason why I created a separated cluster, but I am open to merge it with anything else. (In theory I agree to provide less cluster) 
   
   I will merge it as is to have this safety line as soon as possible, but open to move in any direction.
   
   Thanks the review @adoroszlai 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org