You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by "Dieter De Paepe (Jira)" <ji...@apache.org> on 2024/07/02 14:16:00 UTC

[jira] [Commented] (HBASE-28705) BackupLogCleaner cleans required WALs when using multiple backuproots

    [ https://issues.apache.org/jira/browse/HBASE-28705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17862462#comment-17862462 ] 

Dieter De Paepe commented on HBASE-28705:
-----------------------------------------

Not sure why the PR isn't getting picked up, but here it is: https://github.com/apache/hbase/pull/6040

> BackupLogCleaner cleans required WALs when using multiple backuproots
> ---------------------------------------------------------------------
>
>                 Key: HBASE-28705
>                 URL: https://issues.apache.org/jira/browse/HBASE-28705
>             Project: HBase
>          Issue Type: Bug
>          Components: backup&amp;restore
>    Affects Versions: 2.6.0, 4.0.0-alpha-1
>            Reporter: Dieter De Paepe
>            Assignee: Dieter De Paepe
>            Priority: Blocker
>
> The BackupLogCleaner is responsible for avoiding the deletion of WAL/logs that still need to be included in a future backup.
> The logic to decide which files can be deleted does not work correctly when multiple backup roots are used. Each backup root has a different chain of backups (full, incremental1, incremental2, ...). So, if any chain requires a log, it should be preserved. This is not the case.
> The result is that logs could be incorrectly deleted, resulting in data loss in backups.
> PR incoming with test & fix.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)