You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/04/21 20:52:31 UTC
[GitHub] [beam] Hannah-Jiang opened a new pull request #11484: [BEAM-9778] remove temp directoryf
Hannah-Jiang opened a new pull request #11484:
URL: https://github.com/apache/beam/pull/11484
**Please** add a meaningful description for your change here
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark
--- | --- | --- | --- | --- | --- | --- | ---
Go | [](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/)
Java | [](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Java11/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/)
Python | [](https://builds.apache.org/job/beam_PostCommit_Python2/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python35/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/) | --- | [](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Python2_PVR_Flink_Cron/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python35_VR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/)
XLang | --- | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/)
Pre-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
--- |Java | Python | Go | Website
--- | --- | --- | --- | ---
Non-portable | [](https://builds.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/)
Portable | --- | [](https://builds.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/) | --- | ---
See [.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md) for trigger phrase, status and link of all Jenkins jobs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Hannah-Jiang commented on issue #11484: [BEAM-9778] remove temp directoryf
Posted by GitBox <gi...@apache.org>.
Hannah-Jiang commented on issue #11484:
URL: https://github.com/apache/beam/pull/11484#issuecomment-617424118
Run XVR_Spark PostCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] ibzib commented on a change in pull request #11484: [BEAM-9778] remove temp directory & add docker-pull-licenses to release scripts
Posted by GitBox <gi...@apache.org>.
ibzib commented on a change in pull request #11484:
URL: https://github.com/apache/beam/pull/11484#discussion_r413230082
##########
File path: sdks/java/container/build.gradle
##########
@@ -94,8 +86,12 @@ licenseReport {
task copyThirdPartyLicenses(type: Copy) {
from ("third_party_licenses")
into "build/target/third_party_licenses"
+ doLast {
+ file('third_party_licenses').deleteDir()
+ }
}
+def Boolean pull_licenses
Review comment:
(Sorry for picking nits by the way, I'm just trying to understand Gradle better 😅)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Hannah-Jiang commented on issue #11484: [BEAM-9778] remove temp directoryf
Posted by GitBox <gi...@apache.org>.
Hannah-Jiang commented on issue #11484:
URL: https://github.com/apache/beam/pull/11484#issuecomment-617510448
Run XVR_Spark PostCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] ibzib commented on a change in pull request #11484: [BEAM-9778] remove temp directory & add docker-pull-licenses to release scripts
Posted by GitBox <gi...@apache.org>.
ibzib commented on a change in pull request #11484:
URL: https://github.com/apache/beam/pull/11484#discussion_r412981733
##########
File path: sdks/java/container/build.gradle
##########
@@ -94,8 +86,12 @@ licenseReport {
task copyThirdPartyLicenses(type: Copy) {
from ("third_party_licenses")
into "build/target/third_party_licenses"
+ doLast {
+ file('third_party_licenses').deleteDir()
+ }
}
+def Boolean pull_licenses
Review comment:
Why pull this out into a global variable?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Hannah-Jiang commented on issue #11484: [BEAM-9778] remove temp directoryf
Posted by GitBox <gi...@apache.org>.
Hannah-Jiang commented on issue #11484:
URL: https://github.com/apache/beam/pull/11484#issuecomment-617462955
Run XVR_Spark PostCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Hannah-Jiang commented on issue #11484: [BEAM-9778] remove temp directoryf
Posted by GitBox <gi...@apache.org>.
Hannah-Jiang commented on issue #11484:
URL: https://github.com/apache/beam/pull/11484#issuecomment-617415886
Run XVR_Spark PostCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Hannah-Jiang commented on issue #11484: [BEAM-9778] remove temp directoryf
Posted by GitBox <gi...@apache.org>.
Hannah-Jiang commented on issue #11484:
URL: https://github.com/apache/beam/pull/11484#issuecomment-617512857
Run XVR_Spark PostCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Hannah-Jiang commented on issue #11484: [BEAM-9778] remove temp directoryf
Posted by GitBox <gi...@apache.org>.
Hannah-Jiang commented on issue #11484:
URL: https://github.com/apache/beam/pull/11484#issuecomment-617409465
Run XVR_Spark PostCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] ibzib commented on a change in pull request #11484: [BEAM-9778] remove temp directory & add docker-pull-licenses to release scripts
Posted by GitBox <gi...@apache.org>.
ibzib commented on a change in pull request #11484:
URL: https://github.com/apache/beam/pull/11484#discussion_r413229048
##########
File path: sdks/java/container/build.gradle
##########
@@ -94,8 +86,12 @@ licenseReport {
task copyThirdPartyLicenses(type: Copy) {
from ("third_party_licenses")
into "build/target/third_party_licenses"
+ doLast {
+ file('third_party_licenses').deleteDir()
+ }
}
+def Boolean pull_licenses
Review comment:
I tried changing `generateThirdPartyLicenses` to read `project.rootProject.hasProperty(["docker-pull-licenses"])` directly, and it seemed to work fine when I called `./gradlew :sdks:java:container:docker -Pdocker-pull-licenses`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Hannah-Jiang commented on issue #11484: [BEAM-9778] remove temp directoryf
Posted by GitBox <gi...@apache.org>.
Hannah-Jiang commented on issue #11484:
URL: https://github.com/apache/beam/pull/11484#issuecomment-617512400
Run Website_Stage_GCS PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Hannah-Jiang commented on a change in pull request #11484: [BEAM-9778] remove temp directory & add docker-pull-licenses to release scripts
Posted by GitBox <gi...@apache.org>.
Hannah-Jiang commented on a change in pull request #11484:
URL: https://github.com/apache/beam/pull/11484#discussion_r413211860
##########
File path: sdks/java/container/build.gradle
##########
@@ -94,8 +86,12 @@ licenseReport {
task copyThirdPartyLicenses(type: Copy) {
from ("third_party_licenses")
into "build/target/third_party_licenses"
+ doLast {
+ file('third_party_licenses').deleteDir()
+ }
}
+def Boolean pull_licenses
Review comment:
when we pass `docker-pull-licenses` to `:sdks:java:container:docker`, `generateThirdPartyLicenses` task doesn't understand it. In order to pass the tag from docker task to `generateThirdPartyLicenses`, we need a global value to share it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Hannah-Jiang commented on issue #11484: [BEAM-9778] remove temp directoryf
Posted by GitBox <gi...@apache.org>.
Hannah-Jiang commented on issue #11484:
URL: https://github.com/apache/beam/pull/11484#issuecomment-617421279
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Hannah-Jiang commented on issue #11484: [BEAM-9778] remove temp directory & add docker-pull-licenses to release scripts
Posted by GitBox <gi...@apache.org>.
Hannah-Jiang commented on issue #11484:
URL: https://github.com/apache/beam/pull/11484#issuecomment-617971868
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Hannah-Jiang commented on issue #11484: [BEAM-9778] remove temp directory & add docker-pull-licenses to release scripts
Posted by GitBox <gi...@apache.org>.
Hannah-Jiang commented on issue #11484:
URL: https://github.com/apache/beam/pull/11484#issuecomment-618038216
Run Python PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Hannah-Jiang commented on issue #11484: [BEAM-9778] remove temp directoryf
Posted by GitBox <gi...@apache.org>.
Hannah-Jiang commented on issue #11484:
URL: https://github.com/apache/beam/pull/11484#issuecomment-617465452
Run XVR_Spark PostCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Hannah-Jiang commented on issue #11484: [BEAM-9778] remove temp directoryf
Posted by GitBox <gi...@apache.org>.
Hannah-Jiang commented on issue #11484:
URL: https://github.com/apache/beam/pull/11484#issuecomment-617415951
Run XVR_Flink PostCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Hannah-Jiang commented on issue #11484: [BEAM-9778] remove temp directoryf
Posted by GitBox <gi...@apache.org>.
Hannah-Jiang commented on issue #11484:
URL: https://github.com/apache/beam/pull/11484#issuecomment-617510378
Run XVR_Flink PostCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Hannah-Jiang commented on issue #11484: [BEAM-9778] remove temp directory & add docker-pull-licenses to release scripts
Posted by GitBox <gi...@apache.org>.
Hannah-Jiang commented on issue #11484:
URL: https://github.com/apache/beam/pull/11484#issuecomment-617524413
R: @ibzib
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Hannah-Jiang commented on a change in pull request #11484: [BEAM-9778] remove temp directory & add docker-pull-licenses to release scripts
Posted by GitBox <gi...@apache.org>.
Hannah-Jiang commented on a change in pull request #11484:
URL: https://github.com/apache/beam/pull/11484#discussion_r413244516
##########
File path: sdks/java/container/build.gradle
##########
@@ -94,8 +86,12 @@ licenseReport {
task copyThirdPartyLicenses(type: Copy) {
from ("third_party_licenses")
into "build/target/third_party_licenses"
+ doLast {
+ file('third_party_licenses').deleteDir()
+ }
}
+def Boolean pull_licenses
Review comment:
That was the behavior I observed when I implement it. But yesterday, when I try it again, it didn't work as expected. So I introduced the pull_licenses variable. But today, as you pointed out, I tried again, it worked! I reversed to original code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Hannah-Jiang commented on issue #11484: [BEAM-9778] remove temp directoryf
Posted by GitBox <gi...@apache.org>.
Hannah-Jiang commented on issue #11484:
URL: https://github.com/apache/beam/pull/11484#issuecomment-617462920
Run XVR_Flink PostCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Hannah-Jiang removed a comment on issue #11484: [BEAM-9778] remove temp directoryf
Posted by GitBox <gi...@apache.org>.
Hannah-Jiang removed a comment on issue #11484:
URL: https://github.com/apache/beam/pull/11484#issuecomment-617512400
Run Website_Stage_GCS PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Hannah-Jiang commented on issue #11484: [BEAM-9778] remove temp directoryf
Posted by GitBox <gi...@apache.org>.
Hannah-Jiang commented on issue #11484:
URL: https://github.com/apache/beam/pull/11484#issuecomment-617471277
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Hannah-Jiang removed a comment on issue #11484: [BEAM-9778] remove temp directoryf
Posted by GitBox <gi...@apache.org>.
Hannah-Jiang removed a comment on issue #11484:
URL: https://github.com/apache/beam/pull/11484#issuecomment-617510378
Run XVR_Flink PostCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Hannah-Jiang removed a comment on issue #11484: [BEAM-9778] remove temp directoryf
Posted by GitBox <gi...@apache.org>.
Hannah-Jiang removed a comment on issue #11484:
URL: https://github.com/apache/beam/pull/11484#issuecomment-617510448
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org