[GitHub] [superset] diegomedina248 commented on pull request #19257: fix(sql lab): table selector should clear once selected

[GitBox <gi...@apache.org>]

diegomedina248 commented on pull request #19257:
URL: https://github.com/apache/superset/pull/19257#issuecomment-1074464465


   > This works, but it feels a little unique/strange in how it works compared to other Select menus. Would it make sense to have it be a multiple select, so that ALL your choices persist? Then removing an item from the selection could remove the preview just like clicking the close button above the field list itself (which is also not a consistent pattern in Superset, really).
   > 
   > cc @yousoph we can let this through, but a little piece of me wants to tap the brakes and have a brief design thinking moment here.
   
   Agreed, but I think it's worth a bigger discussion, cause the database & schema are required to perform the query, but the table is not, so I think it shouldn't belong in the same place. The table is there to get the table schema, which is nice, but feels disconnected.
   
   However, I feel like the solution in the PR is a bit better than the current one, so while we discuss a better approach, it's worth considering.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org