You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/02/23 19:52:47 UTC

[GitHub] [kafka] ableegoldman opened a new pull request #10197: KAFKA-12211: don't change perm for base/state dir when no persistent store

ableegoldman opened a new pull request #10197:
URL: https://github.com/apache/kafka/pull/10197


   We improved the state directory folder/file permission setting in #9583 . But we forgot to consider one situation: if user doesn't have Persistent Stores, we won't create base dir and state dir. And if there's no such dir, and when we tried to set permission to them, we'll have NoSuchFileException.
   
   Port of https://github.com/apache/kafka/pull/9904 to the 2.6 branch


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kafka] ableegoldman commented on pull request #10197: KAFKA-12211: don't change perm for base/state dir when no persistent store

Posted by GitBox <gi...@apache.org>.
ableegoldman commented on pull request #10197:
URL: https://github.com/apache/kafka/pull/10197#issuecomment-784468722


   call for review @showuon @modax @lct45 @wcarlson5 @cadonna 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kafka] ableegoldman merged pull request #10197: KAFKA-12211: don't change perm for base/state dir when no persistent store

Posted by GitBox <gi...@apache.org>.
ableegoldman merged pull request #10197:
URL: https://github.com/apache/kafka/pull/10197


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kafka] showuon commented on pull request #10197: KAFKA-12211: don't change perm for base/state dir when no persistent store

Posted by GitBox <gi...@apache.org>.
showuon commented on pull request #10197:
URL: https://github.com/apache/kafka/pull/10197#issuecomment-784653971


   @ableegoldman , thanks for taking care of it. LGTM ( a little late XD)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org