You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/03/21 10:00:36 UTC
[GitHub] [dolphinscheduler-website] Tianqi-Dotes commented on a change in pull request #744: Change how to release python dist
Tianqi-Dotes commented on a change in pull request #744:
URL: https://github.com/apache/dolphinscheduler-website/pull/744#discussion_r830916226
##########
File path: docs/en-us/2.0.2/user_doc/guide/project/workflow-definition.md
##########
@@ -17,7 +17,7 @@
3. Select "Task Priority": When the number of worker threads is insufficient, high-level tasks will be executed first in the execution queue, and tasks with the same priority will be executed in the order of first in, first out;
4. Timeout alarm (optional): Check the timeout alarm, timeout failure, and fill in the "timeout period". When the task execution time exceeds **timeout period**, an alert email will be sent and the task timeout fails;
5. Resources (optional). Resource files are files created or uploaded on the Resource Center -> File Management page. For example, the file name is `test.sh`, and the command to call the resource in the script is `sh test.sh`;
-6. Custom parameters (optional), refer to [Custom Parameters](#UserDefinedParameters);
+6. Custom parameters (optional);
Review comment:
same as above
##########
File path: docs/en-us/2.0.1/user_doc/guide/project/workflow-definition.md
##########
@@ -17,7 +17,7 @@
3. Select "Task Priority": When the number of worker threads is insufficient, high-level tasks will be executed first in the execution queue, and tasks with the same priority will be executed in the order of first in, first out;
4. Timeout alarm (optional): Check the timeout alarm, timeout failure, and fill in the "timeout period". When the task execution time exceeds **timeout period**, an alert email will be sent and the task timeout fails;
5. Resources (optional). Resource files are files created or uploaded on the Resource Center -> File Management page. For example, the file name is `test.sh`, and the command to call the resource in the script is `sh test.sh`;
-6. Custom parameters (optional), refer to [Custom Parameters](#UserDefinedParameters);
+6. Custom parameters (optional);
Review comment:
same as above
##########
File path: docs/en-us/2.0.2/user_doc/guide/project/workflow-definition.md
##########
@@ -49,7 +49,7 @@ The operation functions of the workflow definition list are as follows:
- **Edit:** Only "offline" workflow definitions can be edited. Workflow DAG editing is the same as [Create Workflow Definition](#create-workflow-definition).
- **Online:** When the workflow status is "Offline", used to online workflow. Only the workflow in the "Online" state can run, but cannot be edited.
- **Offline:** When the workflow status is "Online", used to offline workflow. Only the workflow in the "Offline" state can be edited, but not run.
-- **Run:** Only workflow in the online state can run. See [2.3.3 Run Workflow](#runWorkflow) for the operation steps
+- **Run:** Only workflow in the online state can run. See [2.3.3 Run Workflow](#run-the-workflow) for the operation steps
Review comment:
same as above
##########
File path: docs/en-us/2.0.3/user_doc/guide/project/workflow-definition.md
##########
@@ -49,7 +49,7 @@ The operation functions of the workflow definition list are as follows:
- **Edit:** Only "offline" workflow definitions can be edited. Workflow DAG editing is the same as [Create Workflow Definition](#create-workflow-definition).
- **Online:** When the workflow status is "Offline", used to online workflow. Only the workflow in the "Online" state can run, but cannot be edited.
- **Offline:** When the workflow status is "Online", used to offline workflow. Only the workflow in the "Offline" state can be edited, but not run.
-- **Run:** Only workflow in the online state can run. See [2.3.3 Run Workflow](#runWorkflow) for the operation steps
+- **Run:** Only workflow in the online state can run. See [2.3.3 Run Workflow](#run-the-workflow) for the operation steps
Review comment:
same as above
##########
File path: docs/zh-cn/2.0.3/user_doc/guide/project/workflow-definition.md
##########
@@ -47,7 +47,7 @@
- **编辑：** 只能编辑"下线"的工作流定义。工作流DAG编辑同创建工作流定义。
- **上线：** 工作流状态为"下线"时，上线工作流，只有"上线"状态的工作流能运行，但不能编辑。
- **下线：** 工作流状态为"上线"时，下线工作流，下线状态的工作流可以编辑，但不能运行。
-- **运行：** 只有上线的工作流能运行。运行操作步骤见[2.3.3 运行工作流](#runWorkflow)
+- **运行：** 只有上线的工作流能运行。运行操作步骤见运行工作流
Review comment:
same as above
##########
File path: docs/zh-cn/dev/user_doc/guide/project/workflow-definition.md
##########
@@ -45,7 +45,7 @@
- **编辑：** 只能编辑"下线"的工作流定义。工作流DAG编辑同创建工作流定义。
- **上线：** 工作流状态为"下线"时，上线工作流，只有"上线"状态的工作流能运行，但不能编辑。
- **下线：** 工作流状态为"上线"时，下线工作流，下线状态的工作流可以编辑，但不能运行。
-- **运行：** 只有上线的工作流能运行。运行操作步骤见[2.3.3 运行工作流](#runWorkflow)
+- **运行：** 只有上线的工作流能运行。运行操作步骤见运行工作流
Review comment:
same as above
##########
File path: docs/en-us/2.0.5/user_doc/guide/project/workflow-definition.md
##########
@@ -17,7 +17,7 @@
3. Select "Task Priority": When the number of worker threads is insufficient, high-level tasks will be executed first in the execution queue, and tasks with the same priority will be executed in the order of first in, first out;
4. Timeout alarm (optional): Check the timeout alarm, timeout failure, and fill in the "timeout period". When the task execution time exceeds **timeout period**, an alert email will be sent and the task timeout fails;
5. Resources (optional). Resource files are files created or uploaded on the Resource Center -> File Management page. For example, the file name is `test.sh`, and the command to call the resource in the script is `sh test.sh`;
-6. Custom parameters (optional), refer to [Custom Parameters](#UserDefinedParameters);
+6. Custom parameters (optional);
Review comment:
same as above
##########
File path: docs/zh-cn/dev/user_doc/guide/project/workflow-definition.md
##########
@@ -97,7 +97,7 @@
<p align="center">
<img src="/img/time-schedule2.png" width="80%" />
</p>
-- 失败策略、通知策略、流程优先级、Worker分组、通知组、收件人、抄送人同[工作流运行参数](#runParamers)。
+- 失败策略、通知策略、流程优先级、Worker分组、通知组、收件人、抄送人同工作流运行参数
Review comment:
same as above
##########
File path: docs/en-us/2.0.1/user_doc/guide/project/workflow-instance.md
##########
@@ -17,7 +17,7 @@
<p align="center">
<img src="/img/instanceViewLog-en.png" width="80%" />
</p>
-- Click "View Log", a log pop-up box will pop up, as shown in the figure below, the task log can also be viewed on the task instance page, refer to [Task View Log](#taskLog)。
+- Click "View Log", a log pop-up box will pop up, as shown in the figure below, the task log can also be viewed on the task instance page, refer to [Task View Log](./task-instance.md)。
Review comment:
same as above
##########
File path: docs/zh-cn/2.0.2/user_doc/guide/project/workflow-definition.md
##########
@@ -99,7 +99,7 @@
<p align="center">
<img src="/img/time-schedule2.png" width="80%" />
</p>
-- 失败策略、通知策略、流程优先级、Worker分组、通知组、收件人、抄送人同[工作流运行参数](#runParamers)。
+- 失败策略、通知策略、流程优先级、Worker分组、通知组、收件人、抄送人同工作流运行参数
Review comment:
same as above
##########
File path: docs/en-us/2.0.2/user_doc/guide/project/workflow-instance.md
##########
@@ -17,7 +17,7 @@
<p align="center">
<img src="/img/instanceViewLog-en.png" width="80%" />
</p>
-- Click "View Log", a log pop-up box will pop up, as shown in the figure below, the task log can also be viewed on the task instance page, refer to [Task View Log](#taskLog)。
+- Click "View Log", a log pop-up box will pop up, as shown in the figure below, the task log can also be viewed on the task instance page, refer to [Task View Log](./task-instance.md)。
Review comment:
same as above
##########
File path: docs/en-us/dev/user_doc/guide/project/workflow-definition.md
##########
@@ -17,7 +17,7 @@
3. Select "Task Priority": when the number of worker threads is insufficient, high priority tasks will execute first in the execution queue, and tasks with the same priority will execute in the order of first in, first out;
4. Timeout alarm (optional): check the timeout alarm, timeout failure, and fill in the "timeout period". When the task execution time exceeds **timeout period**, an alert email will send and the task timeout fails;
5. Resources (optional). Resources are files create or upload in the Resource Center -> File Management page. For example, the file name is `test.sh`, and the command to call the resource in the script is `sh test.sh`;
-6. Custom parameters (optional), refer to [Custom Parameters](#UserDefinedParameters);
+6. Custom parameters (optional);
Review comment:
same as above
##########
File path: docs/en-us/2.0.0/user_doc/guide/project/workflow-definition.md
##########
@@ -17,7 +17,7 @@
3. Select "Task Priority": When the number of worker threads is insufficient, high-level tasks will be executed first in the execution queue, and tasks with the same priority will be executed in the order of first in, first out;
4. Timeout alarm (optional): Check the timeout alarm, timeout failure, and fill in the "timeout period". When the task execution time exceeds **timeout period**, an alert email will be sent and the task timeout fails;
5. Resources (optional). Resource files are files created or uploaded on the Resource Center -> File Management page. For example, the file name is `test.sh`, and the command to call the resource in the script is `sh test.sh`;
-6. Custom parameters (optional), refer to [Custom Parameters](#UserDefinedParameters);
+6. Custom parameters (optional);
Review comment:
A verb + noun.
Maybe
Customize parameters (optional);
is better
##########
File path: docs/en-us/2.0.3/user_doc/guide/project/workflow-definition.md
##########
@@ -17,7 +17,7 @@
3. Select "Task Priority": When the number of worker threads is insufficient, high-level tasks will be executed first in the execution queue, and tasks with the same priority will be executed in the order of first in, first out;
4. Timeout alarm (optional): Check the timeout alarm, timeout failure, and fill in the "timeout period". When the task execution time exceeds **timeout period**, an alert email will be sent and the task timeout fails;
5. Resources (optional). Resource files are files created or uploaded on the Resource Center -> File Management page. For example, the file name is `test.sh`, and the command to call the resource in the script is `sh test.sh`;
-6. Custom parameters (optional), refer to [Custom Parameters](#UserDefinedParameters);
+6. Custom parameters (optional);
Review comment:
same as above
##########
File path: docs/en-us/2.0.1/user_doc/guide/project/workflow-definition.md
##########
@@ -49,7 +49,7 @@ The operation functions of the workflow definition list are as follows:
- **Edit:** Only "offline" workflow definitions can be edited. Workflow DAG editing is the same as [Create Workflow Definition](#create-workflow-definition).
- **Online:** When the workflow status is "Offline", used to online workflow. Only the workflow in the "Online" state can run, but cannot be edited.
- **Offline:** When the workflow status is "Online", used to offline workflow. Only the workflow in the "Offline" state can be edited, but not run.
-- **Run:** Only workflow in the online state can run. See [2.3.3 Run Workflow](#runWorkflow) for the operation steps
+- **Run:** Only workflow in the online state can run. See [2.3.3 Run Workflow](#run-the-workflow) for the operation steps
Review comment:
same as above
##########
File path: docs/en-us/dev/user_doc/guide/project/workflow-definition.md
##########
@@ -49,7 +49,7 @@ The following are the operation functions of the workflow definition list:
- **Edit:** Only "Offline" workflow definitions can be edited. Workflow DAG editing is the same as [Create Workflow Definition](#creatDag)
- **Online:** When the workflow status is "Offline", used to make workflow online. Only the workflow in the "Online" state can run, but cannot edit
- **Offline:** When the workflow status is "Online", used to make workflow offline. Only the workflow in the "Offline" state can be edited, but cannot run
-- **Run:** Only workflow in the online state can run. See [2.3.3 Run Workflow](#runWorkflow) for the operation steps
+- **Run:** Only workflow in the online state can run. See [2.3.3 Run Workflow](#run-the-workflow) for the operation steps
Review comment:
same as above
##########
File path: docs/en-us/2.0.0/user_doc/guide/project/workflow-definition.md
##########
@@ -49,7 +49,7 @@ The operation functions of the workflow definition list are as follows:
- **Edit:** Only "offline" workflow definitions can be edited. Workflow DAG editing is the same as [Create Workflow Definition](#create-workflow-definition).
- **Online:** When the workflow status is "Offline", used to online workflow. Only the workflow in the "Online" state can run, but cannot be edited.
- **Offline:** When the workflow status is "Online", used to offline workflow. Only the workflow in the "Offline" state can be edited, but not run.
-- **Run:** Only workflow in the online state can run. See [2.3.3 Run Workflow](#runWorkflow) for the operation steps
+- **Run:** Only workflow in the online state can run. See [2.3.3 Run Workflow](#run-the-workflow) for the operation steps
Review comment:
forget '.' at the end of the sentence.
##########
File path: docs/zh-cn/2.0.0/user_doc/guide/project/workflow-definition.md
##########
@@ -47,7 +47,7 @@
- **编辑：** 只能编辑"下线"的工作流定义。工作流DAG编辑同创建工作流定义。
- **上线：** 工作流状态为"下线"时，上线工作流，只有"上线"状态的工作流能运行，但不能编辑。
- **下线：** 工作流状态为"上线"时，下线工作流，下线状态的工作流可以编辑，但不能运行。
-- **运行：** 只有上线的工作流能运行。运行操作步骤见[2.3.3 运行工作流](#runWorkflow)
+- **运行：** 只有上线的工作流能运行。运行操作步骤见运行工作流
Review comment:
same as above
##########
File path: docs/en-us/2.0.5/user_doc/guide/project/workflow-definition.md
##########
@@ -49,7 +49,7 @@ The operation functions of the workflow definition list are as follows:
- **Edit:** Only "offline" workflow definitions can be edited. Workflow DAG editing is the same as [Create Workflow Definition](#create-workflow-definition).
- **Online:** When the workflow status is "Offline", used to online workflow. Only the workflow in the "Online" state can run, but cannot be edited.
- **Offline:** When the workflow status is "Online", used to offline workflow. Only the workflow in the "Offline" state can be edited, but not run.
-- **Run:** Only workflow in the online state can run. See [2.3.3 Run Workflow](#runWorkflow) for the operation steps
+- **Run:** Only workflow in the online state can run. See [2.3.3 Run Workflow](#run-the-workflow) for the operation steps
Review comment:
same as above
##########
File path: docs/zh-cn/2.0.2/user_doc/guide/project/workflow-definition.md
##########
@@ -47,7 +47,7 @@
- **编辑：** 只能编辑"下线"的工作流定义。工作流DAG编辑同创建工作流定义。
- **上线：** 工作流状态为"下线"时，上线工作流，只有"上线"状态的工作流能运行，但不能编辑。
- **下线：** 工作流状态为"上线"时，下线工作流，下线状态的工作流可以编辑，但不能运行。
-- **运行：** 只有上线的工作流能运行。运行操作步骤见[2.3.3 运行工作流](#runWorkflow)
+- **运行：** 只有上线的工作流能运行。运行操作步骤见运行工作流
Review comment:
same as above
##########
File path: docs/zh-cn/2.0.5/user_doc/guide/project/workflow-definition.md
##########
@@ -47,7 +47,7 @@
- **编辑：** 只能编辑"下线"的工作流定义。工作流DAG编辑同创建工作流定义。
- **上线：** 工作流状态为"下线"时，上线工作流，只有"上线"状态的工作流能运行，但不能编辑。
- **下线：** 工作流状态为"上线"时，下线工作流，下线状态的工作流可以编辑，但不能运行。
-- **运行：** 只有上线的工作流能运行。运行操作步骤见[2.3.3 运行工作流](#runWorkflow)
+- **运行：** 只有上线的工作流能运行。运行操作步骤见运行工作流
Review comment:
same as above
##########
File path: docs/en-us/2.0.2/user_doc/guide/project/workflow-definition.md
##########
@@ -102,7 +102,7 @@ The operation functions of the workflow definition list are as follows:
<p align="center">
<img src="/img/timer-en.png" width="80%" />
</p>
-- Failure strategy, notification strategy, process priority, worker group, notification group, recipient, and CC are the same as [workflow running parameters](#runParamers).
+- Failure strategy, notification strategy, process priority, worker group, notification group, recipient, and CC are the same as workflow running parameters
Review comment:
same as above
##########
File path: docs/en-us/2.0.3/user_doc/guide/project/workflow-definition.md
##########
@@ -102,7 +102,7 @@ The operation functions of the workflow definition list are as follows:
<p align="center">
<img src="/img/timer-en.png" width="80%" />
</p>
-- Failure strategy, notification strategy, process priority, worker group, notification group, recipient, and CC are the same as [workflow running parameters](#runParamers).
+- Failure strategy, notification strategy, process priority, worker group, notification group, recipient, and CC are the same as workflow running parameters
Review comment:
same as above
##########
File path: docs/en-us/dev/user_doc/guide/project/workflow-definition.md
##########
@@ -102,7 +102,7 @@ The following are the operation functions of the workflow definition list:
<p align="center">
<img src="/img/timer-en.png" width="80%" />
</p>
-- Failure strategy, notification strategy, process priority, worker group, notification group, recipient, and CC are the same as [workflow running parameters](#runParamers).
+- Failure strategy, notification strategy, process priority, worker group, notification group, recipient, and CC are the same as workflow running parameters
Review comment:
same as above
##########
File path: docs/zh-cn/2.0.1/user_doc/guide/project/workflow-definition.md
##########
@@ -99,7 +99,7 @@
<p align="center">
<img src="/img/time-schedule2.png" width="80%" />
</p>
-- 失败策略、通知策略、流程优先级、Worker分组、通知组、收件人、抄送人同[工作流运行参数](#runParamers)。
+- 失败策略、通知策略、流程优先级、Worker分组、通知组、收件人、抄送人同工作流运行参数
Review comment:
same as above
##########
File path: docs/zh-cn/2.0.0/user_doc/guide/project/workflow-definition.md
##########
@@ -99,7 +99,7 @@
<p align="center">
<img src="/img/time-schedule2.png" width="80%" />
</p>
-- 失败策略、通知策略、流程优先级、Worker分组、通知组、收件人、抄送人同[工作流运行参数](#runParamers)。
+- 失败策略、通知策略、流程优先级、Worker分组、通知组、收件人、抄送人同工作流运行参数
Review comment:
same as above
##########
File path: docs/zh-cn/2.0.1/user_doc/guide/project/workflow-definition.md
##########
@@ -47,7 +47,7 @@
- **编辑：** 只能编辑"下线"的工作流定义。工作流DAG编辑同创建工作流定义。
- **上线：** 工作流状态为"下线"时，上线工作流，只有"上线"状态的工作流能运行，但不能编辑。
- **下线：** 工作流状态为"上线"时，下线工作流，下线状态的工作流可以编辑，但不能运行。
-- **运行：** 只有上线的工作流能运行。运行操作步骤见[2.3.3 运行工作流](#runWorkflow)
+- **运行：** 只有上线的工作流能运行。运行操作步骤见运行工作流
Review comment:
same as above
##########
File path: docs/en-us/2.0.0/user_doc/guide/project/workflow-instance.md
##########
@@ -17,7 +17,7 @@
<p align="center">
<img src="/img/instanceViewLog-en.png" width="80%" />
</p>
-- Click "View Log", a log pop-up box will pop up, as shown in the figure below, the task log can also be viewed on the task instance page, refer to [Task View Log](#taskLog)。
+- Click "View Log", a log pop-up box will pop up, as shown in the figure below, the task log can also be viewed on the task instance page, refer to [Task View Log](./task-instance.md)。
Review comment:
change '。' to '.'
##########
File path: docs/en-us/2.0.5/user_doc/guide/project/workflow-instance.md
##########
@@ -17,7 +17,7 @@
<p align="center">
<img src="/img/instanceViewLog-en.png" width="80%" />
</p>
-- Click "View Log", a log pop-up box will pop up, as shown in the figure below, the task log can also be viewed on the task instance page, refer to [Task View Log](#taskLog)。
+- Click "View Log", a log pop-up box will pop up, as shown in the figure below, the task log can also be viewed on the task instance page, refer to [Task View Log](./task-instance.md)。
Review comment:
same as above
##########
File path: docs/en-us/2.0.5/user_doc/guide/project/workflow-definition.md
##########
@@ -102,7 +102,7 @@ The operation functions of the workflow definition list are as follows:
<p align="center">
<img src="/img/timer-en.png" width="80%" />
</p>
-- Failure strategy, notification strategy, process priority, worker group, notification group, recipient, and CC are the same as [workflow running parameters](#runParamers).
+- Failure strategy, notification strategy, process priority, worker group, notification group, recipient, and CC are the same as workflow running parameters
Review comment:
same as above
##########
File path: docs/zh-cn/2.0.3/user_doc/guide/project/workflow-definition.md
##########
@@ -99,7 +99,7 @@
<p align="center">
<img src="/img/time-schedule2.png" width="80%" />
</p>
-- 失败策略、通知策略、流程优先级、Worker分组、通知组、收件人、抄送人同[工作流运行参数](#runParamers)。
+- 失败策略、通知策略、流程优先级、Worker分组、通知组、收件人、抄送人同工作流运行参数
Review comment:
same as above
##########
File path: docs/en-us/2.0.2/user_doc/guide/project/workflow-definition.md
##########
@@ -1,6 +1,6 @@
# Workflow definition
-## <span id=creatDag> Create workflow definition</span>
+## Create workflow definitionc
Review comment:
wrong word spelling 'definitionc'
##########
File path: docs/en-us/2.0.0/user_doc/guide/project/workflow-definition.md
##########
@@ -102,7 +102,7 @@ The operation functions of the workflow definition list are as follows:
<p align="center">
<img src="/img/timer-en.png" width="80%" />
</p>
-- Failure strategy, notification strategy, process priority, worker group, notification group, recipient, and CC are the same as [workflow running parameters](#runParamers).
+- Failure strategy, notification strategy, process priority, worker group, notification group, recipient, and CC are the same as workflow running parameters
Review comment:
forget '.'
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org