You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@kylin.apache.org by GitBox <gi...@apache.org> on 2020/09/10 12:30:37 UTC

[GitHub] [kylin] guangxuCheng opened a new pull request #1406: KYLIN-4756 user/group page has duplicate information between adjacent page numbers

guangxuCheng opened a new pull request #1406:
URL: https://github.com/apache/kylin/pull/1406


   ## Proposed changes
   
   Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
   
   ## Types of changes
   
   What types of changes does your code introduce to Kylin?
   _Put an `x` in the boxes that apply_
   
   - [x] Bugfix (non-breaking change which fixes an issue)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
   - [ ] Documentation Update (if none of the other choices apply)
   
   ## Checklist
   
   _Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._
   
   - [x] I have create an issue on [Kylin's jira](https://issues.apache.org/jira/browse/KYLIN), and have described the bug/feature there in detail
   - [ x Commit messages in my PR start with the related jira ID, like "KYLIN-0000 Make Kylin project open-source"
   - [x] Compiling and unit tests pass locally with my changes
   - [ ] I have added tests that prove my fix is effective or that my feature works
   - [ ] If this change need a document change, I will prepare another pr against the `document` branch
   - [ ] Any dependent changes have been merged
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at user@kylin or dev@kylin by explaining why you chose the solution you did and what alternatives you considered, etc...
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kylin] coveralls edited a comment on pull request #1406: KYLIN-4756 user/group page has duplicate information between adjacent page numbers

Posted by GitBox <gi...@apache.org>.

coveralls edited a comment on pull request #1406:
URL: https://github.com/apache/kylin/pull/1406#issuecomment-690273518


   ## Pull Request Test Coverage Report for [Build 6364](https://coveralls.io/builds/33460284)
   
   * **0** of **0**   changed or added relevant lines in **0** files are covered.
   * **2** unchanged lines in **2** files lost coverage.
   * Overall coverage decreased (**-0.002%**) to **28.06%**
   
   ---
   
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [server-base/src/main/java/org/apache/kylin/rest/util/QueryRequestLimits.java](https://coveralls.io/builds/33460284/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Futil%2FQueryRequestLimits.java#L72) | 1 | 47.62% |
   | [stream-core/src/main/java/org/apache/kylin/stream/core/storage/columnar/GeneralColumnDataReader.java](https://coveralls.io/builds/33460284/source?filename=stream-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstream%2Fcore%2Fstorage%2Fcolumnar%2FGeneralColumnDataReader.java#L43) | 1 | 92.11% |
   <!-- | **Total:** | **2** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/33460284/badge)](https://coveralls.io/builds/33460284) |
   | :-- | --: |
   | Change from base [Build 6363](https://coveralls.io/builds/33444750): |  -0.002% |
   | Covered Lines: | 26246 |
   | Relevant Lines: | 93535 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kylin] hit-lacus merged pull request #1406: KYLIN-4756 user/group page has duplicate information between adjacent page numbers

Posted by GitBox <gi...@apache.org>.

hit-lacus merged pull request #1406:
URL: https://github.com/apache/kylin/pull/1406


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kylin] coveralls commented on pull request #1406: KYLIN-4756 user/group page has duplicate information between adjacent page numbers

Posted by GitBox <gi...@apache.org>.

coveralls commented on pull request #1406:
URL: https://github.com/apache/kylin/pull/1406#issuecomment-690273518


   ## Pull Request Test Coverage Report for [Build 6357](https://coveralls.io/builds/33361716)
   
   * **0** of **0**   changed or added relevant lines in **0** files are covered.
   * **8** unchanged lines in **6** files lost coverage.
   * Overall coverage decreased (**-0.005%**) to **28.058%**
   
   ---
   
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [core-dictionary/src/main/java/org/apache/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://coveralls.io/builds/33361716/source?filename=core-dictionary%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fdict%2Flookup%2Fcache%2FRocksDBLookupTable.java#L62) | 1 | 81.08% |
   | [server-base/src/main/java/org/apache/kylin/rest/util/QueryRequestLimits.java](https://coveralls.io/builds/33361716/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Futil%2FQueryRequestLimits.java#L72) | 1 | 47.62% |
   | [stream-core/src/main/java/org/apache/kylin/stream/core/storage/columnar/ColumnarStoreCache.java](https://coveralls.io/builds/33361716/source?filename=stream-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstream%2Fcore%2Fstorage%2Fcolumnar%2FColumnarStoreCache.java#L146) | 1 | 56.82% |
   | [tool/src/main/java/org/apache/kylin/tool/query/ProbabilityGenerator.java](https://coveralls.io/builds/33361716/source?filename=tool%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Ftool%2Fquery%2FProbabilityGenerator.java#L42) | 1 | 81.58% |
   | [core-job/src/main/java/org/apache/kylin/job/impl/threadpool/DefaultScheduler.java](https://coveralls.io/builds/33361716/source?filename=core-job%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fjob%2Fimpl%2Fthreadpool%2FDefaultScheduler.java#L194) | 2 | 80.23% |
   | [stream-core/src/main/java/org/apache/kylin/stream/core/storage/CheckPointStore.java](https://coveralls.io/builds/33361716/source?filename=stream-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstream%2Fcore%2Fstorage%2FCheckPointStore.java#L98) | 2 | 73.74% |
   <!-- | **Total:** | **8** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/33361716/badge)](https://coveralls.io/builds/33361716) |
   | :-- | --: |
   | Change from base [Build 6349](https://coveralls.io/builds/33335228): |  -0.005% |
   | Covered Lines: | 26245 |
   | Relevant Lines: | 93537 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kylin] hit-lacus commented on pull request #1406: KYLIN-4756 user/group page has duplicate information between adjacent page numbers

Posted by GitBox <gi...@apache.org>.

hit-lacus commented on pull request #1406:
URL: https://github.com/apache/kylin/pull/1406#issuecomment-692070955


   @zzcclp  could please help to review this patch ?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kylin] hit-lacus commented on pull request #1406: KYLIN-4756 user/group page has duplicate information between adjacent page numbers

Posted by GitBox <gi...@apache.org>.

hit-lacus commented on pull request #1406:
URL: https://github.com/apache/kylin/pull/1406#issuecomment-692429861


   Thank you, @guangxuCheng . I will merge this.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kylin] zzcclp commented on pull request #1406: KYLIN-4756 user/group page has duplicate information between adjacent page numbers

Posted by GitBox <gi...@apache.org>.

zzcclp commented on pull request #1406:
URL: https://github.com/apache/kylin/pull/1406#issuecomment-692396002


   LGTM.
   BTW, there are some places missing ';' after function, could you add them?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kylin] guangxuCheng commented on pull request #1406: KYLIN-4756 user/group page has duplicate information between adjacent page numbers

Posted by GitBox <gi...@apache.org>.

guangxuCheng commented on pull request #1406:
URL: https://github.com/apache/kylin/pull/1406#issuecomment-692414107


   > LGTM.
   > BTW, there are some places missing ';' after function, could you add them?
   
   Thanks for review. I will add them.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kylin] codecov-commenter commented on pull request #1406: KYLIN-4756 user/group page has duplicate information between adjacent page numbers

Posted by GitBox <gi...@apache.org>.

codecov-commenter commented on pull request #1406:
URL: https://github.com/apache/kylin/pull/1406#issuecomment-692425263


   # [Codecov](https://codecov.io/gh/apache/kylin/pull/1406?src=pr&el=h1) Report
   > Merging [#1406](https://codecov.io/gh/apache/kylin/pull/1406?src=pr&el=desc) into [master](https://codecov.io/gh/apache/kylin/commit/85f421da2a250f1878fb0eb69282352d922ad8b2?el=desc) will **decrease** coverage by `0.00%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/kylin/pull/1406/graphs/tree.svg?width=650&height=150&src=pr&token=JawVgbgsVo)](https://codecov.io/gh/apache/kylin/pull/1406?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1406      +/-   ##
   ============================================
   - Coverage     25.51%   25.51%   -0.01%     
   + Complexity     6761     6758       -3     
   ============================================
     Files          1506     1506              
     Lines         93535    93535              
     Branches      13092    13092              
   ============================================
   - Hits          23869    23864       -5     
   - Misses        67291    67293       +2     
   - Partials       2375     2378       +3     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/1406?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...core/storage/columnar/GeneralColumnDataReader.java](https://codecov.io/gh/apache/kylin/pull/1406/diff?src=pr&el=tree#diff-c3RyZWFtLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3N0cmVhbS9jb3JlL3N0b3JhZ2UvY29sdW1uYXIvR2VuZXJhbENvbHVtbkRhdGFSZWFkZXIuamF2YQ==) | `89.47% <0.00%> (-5.27%)` | `6.00% <0.00%> (-1.00%)` | |
   | [...org/apache/kylin/rest/util/QueryRequestLimits.java](https://codecov.io/gh/apache/kylin/pull/1406/diff?src=pr&el=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3QvdXRpbC9RdWVyeVJlcXVlc3RMaW1pdHMuamF2YQ==) | `35.71% <0.00%> (-4.77%)` | `5.00% <0.00%> (-1.00%)` | |
   | [...a/org/apache/kylin/dict/Number2BytesConverter.java](https://codecov.io/gh/apache/kylin/pull/1406/diff?src=pr&el=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L051bWJlcjJCeXRlc0NvbnZlcnRlci5qYXZh) | `81.74% <0.00%> (-0.80%)` | `17.00% <0.00%> (-1.00%)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/1406?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/1406?src=pr&el=footer). Last update [85f421d...9a97ea9](https://codecov.io/gh/apache/kylin/pull/1406?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kylin] guangxuCheng commented on pull request #1406: KYLIN-4756 user/group page has duplicate information between adjacent page numbers

Posted by GitBox <gi...@apache.org>.

guangxuCheng commented on pull request #1406:
URL: https://github.com/apache/kylin/pull/1406#issuecomment-692419840


   @zzcclp Add some missing ";" , the main change is in line 78. Thanks
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org