You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/02/25 12:14:48 UTC

[GitHub] [shardingsphere] linghengqian opened a new pull request #15644: Eliminate Warning when configuring YAML

linghengqian opened a new pull request #15644:
URL: https://github.com/apache/shardingsphere/pull/15644


   Fixes #15641.
   
   Changes proposed in this pull request:
   - Eliminate Warning when configuring YAML
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] linghengqian commented on a change in pull request #15644: Eliminate Warning when configuring YAML

Posted by GitBox <gi...@apache.org>.
linghengqian commented on a change in pull request #15644:
URL: https://github.com/apache/shardingsphere/pull/15644#discussion_r814831200



##########
File path: shardingsphere-jdbc/shardingsphere-jdbc-spring/shardingsphere-jdbc-core-spring/shardingsphere-jdbc-core-spring-boot-starter/src/main/resources/META-INF/additional-spring-configuration-metadata.json
##########
@@ -70,6 +70,10 @@
       "type": "java.lang.String",
       "sourceType": "org.apache.shardingsphere.spring.boot.ShardingSphereAutoConfiguration"
     },
+    {
+      "name": "spring.shardingsphere.datasource",
+      "type": "java.util.Map<java.lang.String,java.util.Map<java.lang.String,java.lang.Object>>"

Review comment:
       processed.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] totalo commented on a change in pull request #15644: Eliminate Warning when configuring YAML

Posted by GitBox <gi...@apache.org>.
totalo commented on a change in pull request #15644:
URL: https://github.com/apache/shardingsphere/pull/15644#discussion_r814827010



##########
File path: shardingsphere-jdbc/shardingsphere-jdbc-spring/shardingsphere-jdbc-core-spring/shardingsphere-jdbc-core-spring-boot-starter/src/main/resources/META-INF/additional-spring-configuration-metadata.json
##########
@@ -70,6 +70,10 @@
       "type": "java.lang.String",
       "sourceType": "org.apache.shardingsphere.spring.boot.ShardingSphereAutoConfiguration"
     },
+    {
+      "name": "spring.shardingsphere.datasource",
+      "type": "java.util.Map<java.lang.String,java.util.Map<java.lang.String,java.lang.Object>>"

Review comment:
       Format of generics in Map.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] totalo commented on a change in pull request #15644: Eliminate Warning when configuring YAML

Posted by GitBox <gi...@apache.org>.
totalo commented on a change in pull request #15644:
URL: https://github.com/apache/shardingsphere/pull/15644#discussion_r814817014



##########
File path: shardingsphere-jdbc/shardingsphere-jdbc-spring/shardingsphere-jdbc-core-spring/shardingsphere-jdbc-core-spring-boot-starter/src/main/resources/META-INF/additional-spring-configuration-metadata.json
##########
@@ -70,6 +70,10 @@
       "type": "java.lang.String",
       "sourceType": "org.apache.shardingsphere.spring.boot.ShardingSphereAutoConfiguration"
     },
+    {
+      "name": "spring.shardingsphere.datasource",
+      "type": "java.util.Map<java.lang.String,java.util.Map<java.lang.String,java.lang.Object>>"

Review comment:
       Please add blank after `,`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] linghengqian commented on a change in pull request #15644: Eliminate Warning when configuring YAML

Posted by GitBox <gi...@apache.org>.
linghengqian commented on a change in pull request #15644:
URL: https://github.com/apache/shardingsphere/pull/15644#discussion_r814823189



##########
File path: shardingsphere-jdbc/shardingsphere-jdbc-spring/shardingsphere-jdbc-core-spring/shardingsphere-jdbc-core-spring-boot-starter/src/main/resources/META-INF/additional-spring-configuration-metadata.json
##########
@@ -70,6 +70,10 @@
       "type": "java.lang.String",
       "sourceType": "org.apache.shardingsphere.spring.boot.ShardingSphereAutoConfiguration"
     },
+    {
+      "name": "spring.shardingsphere.datasource",
+      "type": "java.util.Map<java.lang.String,java.util.Map<java.lang.String,java.lang.Object>>"

Review comment:
       Refers to the `,`? of `"name": "spring.shardingsphere.datasource",` but spaces are ignored when `commit` in IntelliJ IDEA.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] totalo merged pull request #15644: Eliminate Warning when configuring YAML

Posted by GitBox <gi...@apache.org>.
totalo merged pull request #15644:
URL: https://github.com/apache/shardingsphere/pull/15644


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] totalo removed a comment on pull request #15644: Eliminate Warning when configuring YAML

Posted by GitBox <gi...@apache.org>.
totalo removed a comment on pull request #15644:
URL: https://github.com/apache/shardingsphere/pull/15644#issuecomment-1050969256


   Good job! Thanks.@linghengqian


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] linghengqian commented on a change in pull request #15644: Eliminate Warning when configuring YAML

Posted by GitBox <gi...@apache.org>.
linghengqian commented on a change in pull request #15644:
URL: https://github.com/apache/shardingsphere/pull/15644#discussion_r814823189



##########
File path: shardingsphere-jdbc/shardingsphere-jdbc-spring/shardingsphere-jdbc-core-spring/shardingsphere-jdbc-core-spring-boot-starter/src/main/resources/META-INF/additional-spring-configuration-metadata.json
##########
@@ -70,6 +70,10 @@
       "type": "java.lang.String",
       "sourceType": "org.apache.shardingsphere.spring.boot.ShardingSphereAutoConfiguration"
     },
+    {
+      "name": "spring.shardingsphere.datasource",
+      "type": "java.util.Map<java.lang.String,java.util.Map<java.lang.String,java.lang.Object>>"

Review comment:
       - Refers to the `,` of `"name": "spring.shardingsphere.datasource"` ?  
   - But spaces are ignored when `commit` in IntelliJ IDEA.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] totalo commented on pull request #15644: Eliminate Warning when configuring YAML

Posted by GitBox <gi...@apache.org>.
totalo commented on pull request #15644:
URL: https://github.com/apache/shardingsphere/pull/15644#issuecomment-1050969256


   Good job! Thanks.@linghengqian


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] linghengqian commented on pull request #15644: Eliminate Warning when configuring YAML

Posted by GitBox <gi...@apache.org>.
linghengqian commented on pull request #15644:
URL: https://github.com/apache/shardingsphere/pull/15644#issuecomment-1050851476


   - This appears to be a CI/CD issue due to timeouts. But I have no experience with Spring 4.
   - ![image](https://user-images.githubusercontent.com/20187731/155722594-47b05dda-f138-402c-a70b-1fa30add4cd9.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org