You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/11/08 16:28:37 UTC
[GitHub] [shardingsphere] terrymanu opened a new pull request #8080: Move ShardingSphereSchema.tableAddressingMetaData to PhysicalTableMetaData
terrymanu opened a new pull request #8080:
URL: https://github.com/apache/shardingsphere/pull/8080
For #8057.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-io commented on pull request #8080: Move ShardingSphereSchema.tableAddressingMetaData to PhysicalTableMetaData
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #8080:
URL: https://github.com/apache/shardingsphere/pull/8080#issuecomment-723665925
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/8080?src=pr&el=h1) Report
> Merging [#8080](https://codecov.io/gh/apache/shardingsphere/pull/8080?src=pr&el=desc) (b685a54) into [master](https://codecov.io/gh/apache/shardingsphere/commit/15ad5e4e150bdc2c1f2fe1c90fcc1056d7da7d56?el=desc) (15ad5e4) will **decrease** coverage by `0.00%`.
> The diff coverage is `65.38%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/8080/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so)](https://codecov.io/gh/apache/shardingsphere/pull/8080?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #8080 +/- ##
============================================
- Coverage 75.13% 75.12% -0.01%
Complexity 548 548
============================================
Files 1450 1450
Lines 22747 22730 -17
Branches 4064 4057 -7
============================================
- Hits 17092 17077 -15
+ Misses 4548 4539 -9
- Partials 1107 1114 +7
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/8080?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...impl/DropViewStatementMetaDataRefreshStrategy.java](https://codecov.io/gh/apache/shardingsphere/pull/8080/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9tZXRhZGF0YS9zY2hlbWEvcmVmcmVzaC9pbXBsL0Ryb3BWaWV3U3RhdGVtZW50TWV0YURhdGFSZWZyZXNoU3RyYXRlZ3kuamF2YQ==) | `100.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...e/infra/route/engine/impl/AllSQLRouteExecutor.java](https://codecov.io/gh/apache/shardingsphere/pull/8080/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtcm91dGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2luZnJhL3JvdXRlL2VuZ2luZS9pbXBsL0FsbFNRTFJvdXRlRXhlY3V0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...a/metadata/schema/loader/SchemaMetaDataLoader.java](https://codecov.io/gh/apache/shardingsphere/pull/8080/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9tZXRhZGF0YS9zY2hlbWEvbG9hZGVyL1NjaGVtYU1ldGFEYXRhTG9hZGVyLmphdmE=) | `57.89% <40.00%> (-19.89%)` | `0.00 <0.00> (ø)` | |
| [...e/engine/type/single/SingleTableRoutingEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/8080/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctcm91dGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nL3JvdXRlL2VuZ2luZS90eXBlL3NpbmdsZS9TaW5nbGVUYWJsZVJvdXRpbmdFbmdpbmUuamF2YQ==) | `53.84% <50.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [.../route/engine/type/ShardingRouteEngineFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/8080/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctcm91dGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nL3JvdXRlL2VuZ2luZS90eXBlL1NoYXJkaW5nUm91dGVFbmdpbmVGYWN0b3J5LmphdmE=) | `75.51% <75.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...e/validator/ddl/ShardingDDLStatementValidator.java](https://codecov.io/gh/apache/shardingsphere/pull/8080/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctcm91dGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nL3JvdXRlL2VuZ2luZS92YWxpZGF0b3IvZGRsL1NoYXJkaW5nRERMU3RhdGVtZW50VmFsaWRhdG9yLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [...nance/context/schema/GovernanceSchemaContexts.java](https://codecov.io/gh/apache/shardingsphere/pull/8080/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZ292ZXJuYW5jZS9zaGFyZGluZ3NwaGVyZS1nb3Zlcm5hbmNlLWNvcmUvc2hhcmRpbmdzcGhlcmUtZ292ZXJuYW5jZS1jb3JlLWNvbnRleHQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2dvdmVybmFuY2UvY29udGV4dC9zY2hlbWEvR292ZXJuYW5jZVNjaGVtYUNvbnRleHRzLmphdmE=) | `92.53% <100.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...a/schema/model/physical/PhysicalTableMetaData.java](https://codecov.io/gh/apache/shardingsphere/pull/8080/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9tZXRhZGF0YS9zY2hlbWEvbW9kZWwvcGh5c2ljYWwvUGh5c2ljYWxUYWJsZU1ldGFEYXRhLmphdmE=) | `96.55% <100.00%> (+0.12%)` | `0.00 <0.00> (ø)` | |
| [...l/CreateTableStatementMetaDataRefreshStrategy.java](https://codecov.io/gh/apache/shardingsphere/pull/8080/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9tZXRhZGF0YS9zY2hlbWEvcmVmcmVzaC9pbXBsL0NyZWF0ZVRhYmxlU3RhdGVtZW50TWV0YURhdGFSZWZyZXNoU3RyYXRlZ3kuamF2YQ==) | `100.00% <100.00%> (+12.50%)` | `0.00 <0.00> (ø)` | |
| [...pl/CreateViewStatementMetaDataRefreshStrategy.java](https://codecov.io/gh/apache/shardingsphere/pull/8080/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9tZXRhZGF0YS9zY2hlbWEvcmVmcmVzaC9pbXBsL0NyZWF0ZVZpZXdTdGF0ZW1lbnRNZXRhRGF0YVJlZnJlc2hTdHJhdGVneS5qYXZh) | `100.00% <100.00%> (+15.38%)` | `0.00 <0.00> (ø)` | |
| ... and [9 more](https://codecov.io/gh/apache/shardingsphere/pull/8080/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/8080?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/8080?src=pr&el=footer). Last update [15ad5e4...b685a54](https://codecov.io/gh/apache/shardingsphere/pull/8080?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] menghaoranss merged pull request #8080: Move ShardingSphereSchema.tableAddressingMetaData to PhysicalTableMetaData
Posted by GitBox <gi...@apache.org>.
menghaoranss merged pull request #8080:
URL: https://github.com/apache/shardingsphere/pull/8080
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org