You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openjpa.apache.org by "Donald Woods (JIRA)" <ji...@apache.org> on 2009/02/10 22:29:59 UTC

[jira] Created: (OPENJPA-919) JUnit for Bi-directional OneToOne with null relationships

JUnit for Bi-directional OneToOne with null relationships
---------------------------------------------------------

                 Key: OPENJPA-919
                 URL: https://issues.apache.org/jira/browse/OPENJPA-919
             Project: OpenJPA
          Issue Type: Improvement
          Components: jdbc
    Affects Versions: 1.2.0, 1.3.0, 2.0.0
            Reporter: Donald Woods
            Assignee: Donald Woods
            Priority: Trivial
             Fix For: 1.2.1, 1.3.0, 2.0.0


Testcase to verify relationships in a bi-directional OneToOne are null when:
1) the relations are not set (should default to null)
2) the relations are explicitly set to null


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Re: [jira] Commented: (OPENJPA-919) JUnit for Bi-directional OneToOne with null relationships

Posted by Donald Woods <dw...@apache.org>.
OK, just realized the copy of the file that was sent to me in a separate 
email thread didn't match the version attached to the JIRA.... Sorry for 
the noise.


-Donald


Donald Woods wrote:
> Still not seeing it. I can't find a "C" reference in the orm.xml, 
> ABean.java, BBean.java, BeanBean.java or NullRelationTest.java files....
> 
> Just 'A', 'B' and 'BeanBean' references.
> 
> 
> -Donald
> 
> 
> Kevin Sutter wrote:
>> Don,
>> I believe David is referring to the testcase that he posted to the 
>> JIRA.  He
>> has entities A, B, and C in his testcase.
>>
>> Kevin
>>
>> On Wed, Feb 11, 2009 at 9:06 AM, Donald Woods (JIRA) 
>> <ji...@apache.org>wrote:
>>
>>>    [
>>> https://issues.apache.org/jira/browse/OPENJPA-919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12672650#action_12672650] 
>>>
>>>
>>> Donald Woods commented on OPENJPA-919:
>>> --------------------------------------
>>>
>>> David, what do you mean by "Rename the 'C' fields to 'c' ..."?  There 
>>> are
>>> no 'C' fields in the attached testcase....  Are you referring to a 
>>> testcase
>>> used for OPENJPA-838?
>>>
>>>
>>>> JUnit for Bi-directional OneToOne with null relationships
>>>> ---------------------------------------------------------
>>>>
>>>>                 Key: OPENJPA-919
>>>>                 URL: https://issues.apache.org/jira/browse/OPENJPA-919
>>>>             Project: OpenJPA
>>>>          Issue Type: Bug
>>>>          Components: jdbc
>>>>    Affects Versions: 1.2.0, 1.3.0, 2.0.0
>>>>            Reporter: Donald Woods
>>>>            Priority: Critical
>>>>             Fix For: 1.2.1, 1.3.0, 2.0.0
>>>>
>>>>         Attachments: jpa-nullrelation.tar.gz
>>>>
>>>>
>>>> Testcase to verify relationships in a bi-directional OneToOne are null
>>> (as tested for by the EJB TCK) when:
>>>> 1) the relations are not set (should default to null)
>>>> 2) the relations are explicitly set to null
>>> -- 
>>> This message is automatically generated by JIRA.
>>> -
>>> You can reply to this email to add a comment to the issue online.
>>>
>>>
>>
> 

Re: [jira] Commented: (OPENJPA-919) JUnit for Bi-directional OneToOne with null relationships

Posted by Donald Woods <dw...@apache.org>.
Still not seeing it. I can't find a "C" reference in the orm.xml, 
ABean.java, BBean.java, BeanBean.java or NullRelationTest.java files....

Just 'A', 'B' and 'BeanBean' references.


-Donald


Kevin Sutter wrote:
> Don,
> I believe David is referring to the testcase that he posted to the JIRA.  He
> has entities A, B, and C in his testcase.
> 
> Kevin
> 
> On Wed, Feb 11, 2009 at 9:06 AM, Donald Woods (JIRA) <ji...@apache.org>wrote:
> 
>>    [
>> https://issues.apache.org/jira/browse/OPENJPA-919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12672650#action_12672650]
>>
>> Donald Woods commented on OPENJPA-919:
>> --------------------------------------
>>
>> David, what do you mean by "Rename the 'C' fields to 'c' ..."?  There are
>> no 'C' fields in the attached testcase....  Are you referring to a testcase
>> used for OPENJPA-838?
>>
>>
>>> JUnit for Bi-directional OneToOne with null relationships
>>> ---------------------------------------------------------
>>>
>>>                 Key: OPENJPA-919
>>>                 URL: https://issues.apache.org/jira/browse/OPENJPA-919
>>>             Project: OpenJPA
>>>          Issue Type: Bug
>>>          Components: jdbc
>>>    Affects Versions: 1.2.0, 1.3.0, 2.0.0
>>>            Reporter: Donald Woods
>>>            Priority: Critical
>>>             Fix For: 1.2.1, 1.3.0, 2.0.0
>>>
>>>         Attachments: jpa-nullrelation.tar.gz
>>>
>>>
>>> Testcase to verify relationships in a bi-directional OneToOne are null
>> (as tested for by the EJB TCK) when:
>>> 1) the relations are not set (should default to null)
>>> 2) the relations are explicitly set to null
>> --
>> This message is automatically generated by JIRA.
>> -
>> You can reply to this email to add a comment to the issue online.
>>
>>
> 

Re: [jira] Commented: (OPENJPA-919) JUnit for Bi-directional OneToOne with null relationships

Posted by Kevin Sutter <kw...@gmail.com>.
Don,
I believe David is referring to the testcase that he posted to the JIRA.  He
has entities A, B, and C in his testcase.

Kevin

On Wed, Feb 11, 2009 at 9:06 AM, Donald Woods (JIRA) <ji...@apache.org>wrote:

>
>    [
> https://issues.apache.org/jira/browse/OPENJPA-919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12672650#action_12672650]
>
> Donald Woods commented on OPENJPA-919:
> --------------------------------------
>
> David, what do you mean by "Rename the 'C' fields to 'c' ..."?  There are
> no 'C' fields in the attached testcase....  Are you referring to a testcase
> used for OPENJPA-838?
>
>
> > JUnit for Bi-directional OneToOne with null relationships
> > ---------------------------------------------------------
> >
> >                 Key: OPENJPA-919
> >                 URL: https://issues.apache.org/jira/browse/OPENJPA-919
> >             Project: OpenJPA
> >          Issue Type: Bug
> >          Components: jdbc
> >    Affects Versions: 1.2.0, 1.3.0, 2.0.0
> >            Reporter: Donald Woods
> >            Priority: Critical
> >             Fix For: 1.2.1, 1.3.0, 2.0.0
> >
> >         Attachments: jpa-nullrelation.tar.gz
> >
> >
> > Testcase to verify relationships in a bi-directional OneToOne are null
> (as tested for by the EJB TCK) when:
> > 1) the relations are not set (should default to null)
> > 2) the relations are explicitly set to null
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>

Re: [jira] Commented: (OPENJPA-919) JUnit for Bi-directional OneToOne with null relationships

Posted by David Blevins <da...@visi.com>.
Just an update on this.  I've attached a test case which reproduces  
the issue.

In ABean if you change the field from 'C' to 'c' the test fails.  It  
seems anything that sorts before 'b' in the ASCII chart will work and  
anything after 'b' will fail.

I saw this exact thing in the custom id issue.  I suspect there might  
be one of those "anywhere we do x, we need to fix it" kind of issues  
where x is some sort of collection usage that results in order making  
a difference.

-David

On Feb 10, 2009, at 2:11 PM, Kevin Sutter wrote:

> Thanks for doing this, Don!  Always good to enhance our test bucket.
>
> Kevin
>
> On Tue, Feb 10, 2009 at 3:55 PM, Donald Woods (JIRA)  
> <ji...@apache.org>wrote:
>
>>
>>   [
>> https://issues.apache.org/jira/browse/OPENJPA-919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12672417 
>> #action_12672417]
>>
>> Donald Woods commented on OPENJPA-919:
>> --------------------------------------
>>
>> BTW - these tests prove that OpenJPA is handling null relationships
>> correctly, as tested for in the EJB TCK...
>>
>>
>>> JUnit for Bi-directional OneToOne with null relationships
>>> ---------------------------------------------------------
>>>
>>>                Key: OPENJPA-919
>>>                URL: https://issues.apache.org/jira/browse/ 
>>> OPENJPA-919
>>>            Project: OpenJPA
>>>         Issue Type: Improvement
>>>         Components: jdbc
>>>   Affects Versions: 1.2.0, 1.3.0, 2.0.0
>>>           Reporter: Donald Woods
>>>           Priority: Trivial
>>>            Fix For: 1.2.1, 1.3.0, 2.0.0
>>>
>>>        Attachments: OPENJPA-919-branches12x.patch,
>> OPENJPA-919-branches13x.patch, OPENJPA-919-trunk.patch
>>>
>>>
>>> Testcase to verify relationships in a bi-directional OneToOne are  
>>> null
>> (as tested for by the EJB TCK) when:
>>> 1) the relations are not set (should default to null)
>>> 2) the relations are explicitly set to null
>>
>> --
>> This message is automatically generated by JIRA.
>> -
>> You can reply to this email to add a comment to the issue online.
>>
>>


Re: [jira] Commented: (OPENJPA-919) JUnit for Bi-directional OneToOne with null relationships

Posted by Kevin Sutter <kw...@gmail.com>.
Thanks for doing this, Don!  Always good to enhance our test bucket.

Kevin

On Tue, Feb 10, 2009 at 3:55 PM, Donald Woods (JIRA) <ji...@apache.org>wrote:

>
>    [
> https://issues.apache.org/jira/browse/OPENJPA-919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12672417#action_12672417]
>
> Donald Woods commented on OPENJPA-919:
> --------------------------------------
>
> BTW - these tests prove that OpenJPA is handling null relationships
> correctly, as tested for in the EJB TCK...
>
>
> > JUnit for Bi-directional OneToOne with null relationships
> > ---------------------------------------------------------
> >
> >                 Key: OPENJPA-919
> >                 URL: https://issues.apache.org/jira/browse/OPENJPA-919
> >             Project: OpenJPA
> >          Issue Type: Improvement
> >          Components: jdbc
> >    Affects Versions: 1.2.0, 1.3.0, 2.0.0
> >            Reporter: Donald Woods
> >            Priority: Trivial
> >             Fix For: 1.2.1, 1.3.0, 2.0.0
> >
> >         Attachments: OPENJPA-919-branches12x.patch,
> OPENJPA-919-branches13x.patch, OPENJPA-919-trunk.patch
> >
> >
> > Testcase to verify relationships in a bi-directional OneToOne are null
> (as tested for by the EJB TCK) when:
> > 1) the relations are not set (should default to null)
> > 2) the relations are explicitly set to null
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>

[jira] Commented: (OPENJPA-919) JUnit for Bi-directional OneToOne with null relationships

Posted by "Donald Woods (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OPENJPA-919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12673922#action_12673922 ] 

Donald Woods commented on OPENJPA-919:
--------------------------------------

Sorry, I've been away since Thursday due to a family emergency.  Will start looking at it again today.

> JUnit for Bi-directional OneToOne with null relationships
> ---------------------------------------------------------
>
>                 Key: OPENJPA-919
>                 URL: https://issues.apache.org/jira/browse/OPENJPA-919
>             Project: OpenJPA
>          Issue Type: Bug
>          Components: jdbc
>    Affects Versions: 1.2.0
>            Reporter: Donald Woods
>            Priority: Critical
>             Fix For: 1.2.1, 1.3.0, 2.0.0
>
>         Attachments: jpa-nullrelation.tar.gz, OPENJPA-919-trunk.patch
>
>
> Testcase to verify relationships in a bi-directional OneToOne are null (as tested for by the EJB TCK) when:
> 1) the relations are not set (should default to null)
> 2) the relations are explicitly set to null

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (OPENJPA-919) JUnit for Bi-directional OneToOne with null relationships

Posted by "Donald Woods (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OPENJPA-919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Donald Woods reassigned OPENJPA-919:
------------------------------------

    Assignee:     (was: Donald Woods)

Unassign so a committer can review.

> JUnit for Bi-directional OneToOne with null relationships
> ---------------------------------------------------------
>
>                 Key: OPENJPA-919
>                 URL: https://issues.apache.org/jira/browse/OPENJPA-919
>             Project: OpenJPA
>          Issue Type: Improvement
>          Components: jdbc
>    Affects Versions: 1.2.0, 1.3.0, 2.0.0
>            Reporter: Donald Woods
>            Priority: Trivial
>             Fix For: 1.2.1, 1.3.0, 2.0.0
>
>         Attachments: OPENJPA-919-branches12x.patch, OPENJPA-919-branches13x.patch, OPENJPA-919-trunk.patch
>
>
> Testcase to verify relationships in a bi-directional OneToOne are null (as tested for by the EJB TCK) when:
> 1) the relations are not set (should default to null)
> 2) the relations are explicitly set to null

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (OPENJPA-919) JUnit for Bi-directional OneToOne with null relationships

Posted by "Donald Woods (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OPENJPA-919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12672650#action_12672650 ] 

Donald Woods commented on OPENJPA-919:
--------------------------------------

David, what do you mean by "Rename the 'C' fields to 'c' ..."?  There are no 'C' fields in the attached testcase....  Are you referring to a testcase used for OPENJPA-838?


> JUnit for Bi-directional OneToOne with null relationships
> ---------------------------------------------------------
>
>                 Key: OPENJPA-919
>                 URL: https://issues.apache.org/jira/browse/OPENJPA-919
>             Project: OpenJPA
>          Issue Type: Bug
>          Components: jdbc
>    Affects Versions: 1.2.0, 1.3.0, 2.0.0
>            Reporter: Donald Woods
>            Priority: Critical
>             Fix For: 1.2.1, 1.3.0, 2.0.0
>
>         Attachments: jpa-nullrelation.tar.gz
>
>
> Testcase to verify relationships in a bi-directional OneToOne are null (as tested for by the EJB TCK) when:
> 1) the relations are not set (should default to null)
> 2) the relations are explicitly set to null

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (OPENJPA-919) JUnit for Bi-directional OneToOne with null relationships

Posted by "Donald Woods (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OPENJPA-919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Donald Woods updated OPENJPA-919:
---------------------------------

    Attachment:     (was: OPENJPA-919-trunk.patch)

> JUnit for Bi-directional OneToOne with null relationships
> ---------------------------------------------------------
>
>                 Key: OPENJPA-919
>                 URL: https://issues.apache.org/jira/browse/OPENJPA-919
>             Project: OpenJPA
>          Issue Type: Bug
>          Components: jdbc
>    Affects Versions: 1.2.0, 1.3.0, 2.0.0
>            Reporter: Donald Woods
>            Priority: Critical
>             Fix For: 1.2.1, 1.3.0, 2.0.0
>
>         Attachments: jpa-nullrelation.tar.gz
>
>
> Testcase to verify relationships in a bi-directional OneToOne are null (as tested for by the EJB TCK) when:
> 1) the relations are not set (should default to null)
> 2) the relations are explicitly set to null

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (OPENJPA-919) JUnit for Bi-directional OneToOne with null relationships

Posted by "Donald Woods (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OPENJPA-919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Donald Woods updated OPENJPA-919:
---------------------------------

    Attachment: OPENJPA-919-branches12x.patch
                OPENJPA-919-branches13x.patch
                OPENJPA-919-trunk.patch

Patches to add a junit test to openjpa-persistence-jdbc to test for the null mappedBy relations.

> JUnit for Bi-directional OneToOne with null relationships
> ---------------------------------------------------------
>
>                 Key: OPENJPA-919
>                 URL: https://issues.apache.org/jira/browse/OPENJPA-919
>             Project: OpenJPA
>          Issue Type: Improvement
>          Components: jdbc
>    Affects Versions: 1.2.0, 1.3.0, 2.0.0
>            Reporter: Donald Woods
>            Assignee: Donald Woods
>            Priority: Trivial
>             Fix For: 1.2.1, 1.3.0, 2.0.0
>
>         Attachments: OPENJPA-919-branches12x.patch, OPENJPA-919-branches13x.patch, OPENJPA-919-trunk.patch
>
>
> Testcase to verify relationships in a bi-directional OneToOne are null (as tested for by the EJB TCK) when:
> 1) the relations are not set (should default to null)
> 2) the relations are explicitly set to null

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (OPENJPA-919) JUnit for Bi-directional OneToOne with null relationships

Posted by "Donald Woods (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OPENJPA-919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Donald Woods updated OPENJPA-919:
---------------------------------

    Description: 
Testcase to verify relationships in a bi-directional OneToOne are null (as tested for by the EJB TCK) when:
1) the relations are not set (should default to null)
2) the relations are explicitly set to null


  was:
Testcase to verify relationships in a bi-directional OneToOne are null when:
1) the relations are not set (should default to null)
2) the relations are explicitly set to null



> JUnit for Bi-directional OneToOne with null relationships
> ---------------------------------------------------------
>
>                 Key: OPENJPA-919
>                 URL: https://issues.apache.org/jira/browse/OPENJPA-919
>             Project: OpenJPA
>          Issue Type: Improvement
>          Components: jdbc
>    Affects Versions: 1.2.0, 1.3.0, 2.0.0
>            Reporter: Donald Woods
>            Assignee: Donald Woods
>            Priority: Trivial
>             Fix For: 1.2.1, 1.3.0, 2.0.0
>
>
> Testcase to verify relationships in a bi-directional OneToOne are null (as tested for by the EJB TCK) when:
> 1) the relations are not set (should default to null)
> 2) the relations are explicitly set to null

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (OPENJPA-919) JUnit for Bi-directional OneToOne with null relationships

Posted by "Donald Woods (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OPENJPA-919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Donald Woods updated OPENJPA-919:
---------------------------------

    Attachment: OPENJPA-919-trunk.patch

Simple null relation testcase.  does not test for the more complex SQL/join/FK test from David, but verifies that simple null relations work.

> JUnit for Bi-directional OneToOne with null relationships
> ---------------------------------------------------------
>
>                 Key: OPENJPA-919
>                 URL: https://issues.apache.org/jira/browse/OPENJPA-919
>             Project: OpenJPA
>          Issue Type: Bug
>          Components: jdbc
>    Affects Versions: 1.2.0
>            Reporter: Donald Woods
>            Priority: Critical
>             Fix For: 1.2.1, 1.3.0, 2.0.0
>
>         Attachments: jpa-nullrelation.tar.gz, OPENJPA-919-trunk.patch
>
>
> Testcase to verify relationships in a bi-directional OneToOne are null (as tested for by the EJB TCK) when:
> 1) the relations are not set (should default to null)
> 2) the relations are explicitly set to null

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (OPENJPA-919) JUnit for Bi-directional OneToOne with null relationships

Posted by "Jeremy Bauer (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OPENJPA-919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12672658#action_12672658 ] 

Jeremy Bauer commented on OPENJPA-919:
--------------------------------------

I reviewed OPENJPA-919-trunk.patch provided by Donald and will commit to trunk shortly.  While the test provided in this patch does not reproduce the subject problem, it is a good test to have in the suite.

> JUnit for Bi-directional OneToOne with null relationships
> ---------------------------------------------------------
>
>                 Key: OPENJPA-919
>                 URL: https://issues.apache.org/jira/browse/OPENJPA-919
>             Project: OpenJPA
>          Issue Type: Bug
>          Components: jdbc
>    Affects Versions: 1.2.0
>            Reporter: Donald Woods
>            Priority: Critical
>             Fix For: 1.2.1, 1.3.0, 2.0.0
>
>         Attachments: jpa-nullrelation.tar.gz, OPENJPA-919-trunk.patch
>
>
> Testcase to verify relationships in a bi-directional OneToOne are null (as tested for by the EJB TCK) when:
> 1) the relations are not set (should default to null)
> 2) the relations are explicitly set to null

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (OPENJPA-919) JUnit for Bi-directional OneToOne with null relationships

Posted by "Kevan Miller (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OPENJPA-919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12673914#action_12673914 ] 

Kevan Miller commented on OPENJPA-919:
--------------------------------------

Has anyone had the chance to look at David Blevin's jpa-nullrelation test case? It drives the failure scenario that is blocking Geronimo TCK.

> JUnit for Bi-directional OneToOne with null relationships
> ---------------------------------------------------------
>
>                 Key: OPENJPA-919
>                 URL: https://issues.apache.org/jira/browse/OPENJPA-919
>             Project: OpenJPA
>          Issue Type: Bug
>          Components: jdbc
>    Affects Versions: 1.2.0
>            Reporter: Donald Woods
>            Priority: Critical
>             Fix For: 1.2.1, 1.3.0, 2.0.0
>
>         Attachments: jpa-nullrelation.tar.gz, OPENJPA-919-trunk.patch
>
>
> Testcase to verify relationships in a bi-directional OneToOne are null (as tested for by the EJB TCK) when:
> 1) the relations are not set (should default to null)
> 2) the relations are explicitly set to null

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (OPENJPA-919) JUnit for Bi-directional OneToOne with null relationships

Posted by "Donald Woods (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OPENJPA-919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12672417#action_12672417 ] 

Donald Woods commented on OPENJPA-919:
--------------------------------------

BTW - these tests prove that OpenJPA is handling null relationships correctly, as tested for in the EJB TCK...


> JUnit for Bi-directional OneToOne with null relationships
> ---------------------------------------------------------
>
>                 Key: OPENJPA-919
>                 URL: https://issues.apache.org/jira/browse/OPENJPA-919
>             Project: OpenJPA
>          Issue Type: Improvement
>          Components: jdbc
>    Affects Versions: 1.2.0, 1.3.0, 2.0.0
>            Reporter: Donald Woods
>            Priority: Trivial
>             Fix For: 1.2.1, 1.3.0, 2.0.0
>
>         Attachments: OPENJPA-919-branches12x.patch, OPENJPA-919-branches13x.patch, OPENJPA-919-trunk.patch
>
>
> Testcase to verify relationships in a bi-directional OneToOne are null (as tested for by the EJB TCK) when:
> 1) the relations are not set (should default to null)
> 2) the relations are explicitly set to null

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (OPENJPA-919) JUnit for Bi-directional OneToOne with null relationships

Posted by "David Blevins (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OPENJPA-919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

David Blevins updated OPENJPA-919:
----------------------------------

    Attachment: jpa-nullrelation.tar.gz

Here's a test case that reproduces what I'm seeing.  Like the custom id issue this test case passes if the relation names are changed, proving that there is some sort of case sensitive or sorting issue with the fields in the bean.  Rename the 'C' fields to 'c' and the test will pass.

> JUnit for Bi-directional OneToOne with null relationships
> ---------------------------------------------------------
>
>                 Key: OPENJPA-919
>                 URL: https://issues.apache.org/jira/browse/OPENJPA-919
>             Project: OpenJPA
>          Issue Type: Improvement
>          Components: jdbc
>    Affects Versions: 1.2.0, 1.3.0, 2.0.0
>            Reporter: Donald Woods
>            Priority: Trivial
>             Fix For: 1.2.1, 1.3.0, 2.0.0
>
>         Attachments: jpa-nullrelation.tar.gz, OPENJPA-919-branches12x.patch, OPENJPA-919-branches13x.patch, OPENJPA-919-trunk.patch
>
>
> Testcase to verify relationships in a bi-directional OneToOne are null (as tested for by the EJB TCK) when:
> 1) the relations are not set (should default to null)
> 2) the relations are explicitly set to null

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (OPENJPA-919) JUnit for Bi-directional OneToOne with null relationships

Posted by "Donald Woods (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OPENJPA-919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12674654#action_12674654 ] 

Donald Woods commented on OPENJPA-919:
--------------------------------------

Looks like OPENJPA-925 fixed our test scenario on trunk, so I'm back porting the fix now to 1.2.x to verify it there....

> JUnit for Bi-directional OneToOne with null relationships
> ---------------------------------------------------------
>
>                 Key: OPENJPA-919
>                 URL: https://issues.apache.org/jira/browse/OPENJPA-919
>             Project: OpenJPA
>          Issue Type: Bug
>          Components: jdbc
>    Affects Versions: 1.2.0
>            Reporter: Donald Woods
>            Priority: Critical
>             Fix For: 1.2.1, 1.3.0, 2.0.0
>
>         Attachments: jpa-nullrelation.tar.gz, OPENJPA-919-test-branches12x.patch, OPENJPA-919-test-trunk.patch, OPENJPA-919-trunk.patch
>
>
> Testcase to verify relationships in a bi-directional OneToOne are null (as tested for by the EJB TCK) when:
> 1) the relations are not set (should default to null)
> 2) the relations are explicitly set to null

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (OPENJPA-919) JUnit for Bi-directional OneToOne with null relationships

Posted by "Jeremy Bauer (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OPENJPA-919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12672751#action_12672751 ] 

Jeremy Bauer commented on OPENJPA-919:
--------------------------------------

Committed OPENJPA-919-trunk.patch for Donald under revision 743473.

> JUnit for Bi-directional OneToOne with null relationships
> ---------------------------------------------------------
>
>                 Key: OPENJPA-919
>                 URL: https://issues.apache.org/jira/browse/OPENJPA-919
>             Project: OpenJPA
>          Issue Type: Bug
>          Components: jdbc
>    Affects Versions: 1.2.0
>            Reporter: Donald Woods
>            Priority: Critical
>             Fix For: 1.2.1, 1.3.0, 2.0.0
>
>         Attachments: jpa-nullrelation.tar.gz, OPENJPA-919-trunk.patch
>
>
> Testcase to verify relationships in a bi-directional OneToOne are null (as tested for by the EJB TCK) when:
> 1) the relations are not set (should default to null)
> 2) the relations are explicitly set to null

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (OPENJPA-919) JUnit for Bi-directional OneToOne with null relationships

Posted by "Donald Woods (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OPENJPA-919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12672644#action_12672644 ] 

Donald Woods commented on OPENJPA-919:
--------------------------------------

Thanks.

> JUnit for Bi-directional OneToOne with null relationships
> ---------------------------------------------------------
>
>                 Key: OPENJPA-919
>                 URL: https://issues.apache.org/jira/browse/OPENJPA-919
>             Project: OpenJPA
>          Issue Type: Bug
>          Components: jdbc
>    Affects Versions: 1.2.0, 1.3.0, 2.0.0
>            Reporter: Donald Woods
>            Priority: Critical
>             Fix For: 1.2.1, 1.3.0, 2.0.0
>
>         Attachments: jpa-nullrelation.tar.gz, OPENJPA-919-branches12x.patch, OPENJPA-919-branches13x.patch, OPENJPA-919-trunk.patch
>
>
> Testcase to verify relationships in a bi-directional OneToOne are null (as tested for by the EJB TCK) when:
> 1) the relations are not set (should default to null)
> 2) the relations are explicitly set to null

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (OPENJPA-919) JUnit for Bi-directional OneToOne with null relationships

Posted by "Donald Woods (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OPENJPA-919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Donald Woods updated OPENJPA-919:
---------------------------------

    Attachment:     (was: OPENJPA-919-branches12x.patch)

> JUnit for Bi-directional OneToOne with null relationships
> ---------------------------------------------------------
>
>                 Key: OPENJPA-919
>                 URL: https://issues.apache.org/jira/browse/OPENJPA-919
>             Project: OpenJPA
>          Issue Type: Bug
>          Components: jdbc
>    Affects Versions: 1.2.0, 1.3.0, 2.0.0
>            Reporter: Donald Woods
>            Priority: Critical
>             Fix For: 1.2.1, 1.3.0, 2.0.0
>
>         Attachments: jpa-nullrelation.tar.gz
>
>
> Testcase to verify relationships in a bi-directional OneToOne are null (as tested for by the EJB TCK) when:
> 1) the relations are not set (should default to null)
> 2) the relations are explicitly set to null

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (OPENJPA-919) JUnit for Bi-directional OneToOne with null relationships

Posted by "David Blevins (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OPENJPA-919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

David Blevins updated OPENJPA-919:
----------------------------------

      Priority: Critical  (was: Trivial)
    Issue Type: Bug  (was: Improvement)

Marking this as a bug.

> JUnit for Bi-directional OneToOne with null relationships
> ---------------------------------------------------------
>
>                 Key: OPENJPA-919
>                 URL: https://issues.apache.org/jira/browse/OPENJPA-919
>             Project: OpenJPA
>          Issue Type: Bug
>          Components: jdbc
>    Affects Versions: 1.2.0, 1.3.0, 2.0.0
>            Reporter: Donald Woods
>            Priority: Critical
>             Fix For: 1.2.1, 1.3.0, 2.0.0
>
>         Attachments: jpa-nullrelation.tar.gz, OPENJPA-919-branches12x.patch, OPENJPA-919-branches13x.patch, OPENJPA-919-trunk.patch
>
>
> Testcase to verify relationships in a bi-directional OneToOne are null (as tested for by the EJB TCK) when:
> 1) the relations are not set (should default to null)
> 2) the relations are explicitly set to null

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (OPENJPA-919) JUnit for Bi-directional OneToOne with null relationships

Posted by "Donald Woods (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OPENJPA-919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Donald Woods updated OPENJPA-919:
---------------------------------

    Affects Version/s:     (was: 2.0.0)
                           (was: 1.3.0)

> JUnit for Bi-directional OneToOne with null relationships
> ---------------------------------------------------------
>
>                 Key: OPENJPA-919
>                 URL: https://issues.apache.org/jira/browse/OPENJPA-919
>             Project: OpenJPA
>          Issue Type: Bug
>          Components: jdbc
>    Affects Versions: 1.2.0
>            Reporter: Donald Woods
>            Priority: Critical
>             Fix For: 1.2.1, 1.3.0, 2.0.0
>
>         Attachments: jpa-nullrelation.tar.gz
>
>
> Testcase to verify relationships in a bi-directional OneToOne are null (as tested for by the EJB TCK) when:
> 1) the relations are not set (should default to null)
> 2) the relations are explicitly set to null

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (OPENJPA-919) JUnit for Bi-directional OneToOne with null relationships

Posted by "Donald Woods (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OPENJPA-919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Donald Woods updated OPENJPA-919:
---------------------------------

    Attachment:     (was: OPENJPA-919-branches13x.patch)

> JUnit for Bi-directional OneToOne with null relationships
> ---------------------------------------------------------
>
>                 Key: OPENJPA-919
>                 URL: https://issues.apache.org/jira/browse/OPENJPA-919
>             Project: OpenJPA
>          Issue Type: Bug
>          Components: jdbc
>    Affects Versions: 1.2.0, 1.3.0, 2.0.0
>            Reporter: Donald Woods
>            Priority: Critical
>             Fix For: 1.2.1, 1.3.0, 2.0.0
>
>         Attachments: jpa-nullrelation.tar.gz
>
>
> Testcase to verify relationships in a bi-directional OneToOne are null (as tested for by the EJB TCK) when:
> 1) the relations are not set (should default to null)
> 2) the relations are explicitly set to null

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (OPENJPA-919) JUnit for Bi-directional OneToOne with null relationships

Posted by "Donald Woods (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OPENJPA-919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Donald Woods resolved OPENJPA-919.
----------------------------------

    Resolution: Duplicate

Problem resolved by changes made in OPENJPA-925.  Waiting for Catalina to apply the fix to the 1.2.x branch before marking this as closed.

> JUnit for Bi-directional OneToOne with null relationships
> ---------------------------------------------------------
>
>                 Key: OPENJPA-919
>                 URL: https://issues.apache.org/jira/browse/OPENJPA-919
>             Project: OpenJPA
>          Issue Type: Bug
>          Components: jdbc
>    Affects Versions: 1.2.0
>            Reporter: Donald Woods
>            Priority: Critical
>             Fix For: 1.2.1, 1.3.0, 2.0.0
>
>         Attachments: jpa-nullrelation.tar.gz, OPENJPA-919-test-branches12x.patch, OPENJPA-919-test-trunk.patch, OPENJPA-919-trunk.patch
>
>
> Testcase to verify relationships in a bi-directional OneToOne are null (as tested for by the EJB TCK) when:
> 1) the relations are not set (should default to null)
> 2) the relations are explicitly set to null

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (OPENJPA-919) JUnit for Bi-directional OneToOne with null relationships

Posted by "Donald Woods (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OPENJPA-919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Donald Woods updated OPENJPA-919:
---------------------------------

    Attachment: OPENJPA-919-test-trunk.patch

Converted testcase from David Blevins for trunk showing that complex relations fails.

> JUnit for Bi-directional OneToOne with null relationships
> ---------------------------------------------------------
>
>                 Key: OPENJPA-919
>                 URL: https://issues.apache.org/jira/browse/OPENJPA-919
>             Project: OpenJPA
>          Issue Type: Bug
>          Components: jdbc
>    Affects Versions: 1.2.0
>            Reporter: Donald Woods
>            Priority: Critical
>             Fix For: 1.2.1, 1.3.0, 2.0.0
>
>         Attachments: jpa-nullrelation.tar.gz, OPENJPA-919-test-branches12x.patch, OPENJPA-919-test-trunk.patch, OPENJPA-919-trunk.patch
>
>
> Testcase to verify relationships in a bi-directional OneToOne are null (as tested for by the EJB TCK) when:
> 1) the relations are not set (should default to null)
> 2) the relations are explicitly set to null

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (OPENJPA-919) JUnit for Bi-directional OneToOne with null relationships

Posted by "Donald Woods (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OPENJPA-919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Donald Woods updated OPENJPA-919:
---------------------------------

    Attachment: OPENJPA-919-test-branches12x.patch

JUnit testcases that show simple null relations work, but the more complex example from David Blevins fails if the OneOneABean uses 'C' instead of 'c' as the variable name for the OneOneCBean relation.

> JUnit for Bi-directional OneToOne with null relationships
> ---------------------------------------------------------
>
>                 Key: OPENJPA-919
>                 URL: https://issues.apache.org/jira/browse/OPENJPA-919
>             Project: OpenJPA
>          Issue Type: Bug
>          Components: jdbc
>    Affects Versions: 1.2.0
>            Reporter: Donald Woods
>            Priority: Critical
>             Fix For: 1.2.1, 1.3.0, 2.0.0
>
>         Attachments: jpa-nullrelation.tar.gz, OPENJPA-919-test-branches12x.patch, OPENJPA-919-trunk.patch
>
>
> Testcase to verify relationships in a bi-directional OneToOne are null (as tested for by the EJB TCK) when:
> 1) the relations are not set (should default to null)
> 2) the relations are explicitly set to null

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (OPENJPA-919) JUnit for Bi-directional OneToOne with null relationships

Posted by "Donald Woods (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OPENJPA-919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Donald Woods closed OPENJPA-919.
--------------------------------


OPENJPA-925 resolved this issue.

> JUnit for Bi-directional OneToOne with null relationships
> ---------------------------------------------------------
>
>                 Key: OPENJPA-919
>                 URL: https://issues.apache.org/jira/browse/OPENJPA-919
>             Project: OpenJPA
>          Issue Type: Bug
>          Components: jdbc
>    Affects Versions: 1.2.0
>            Reporter: Donald Woods
>            Priority: Critical
>             Fix For: 1.2.1, 1.3.0, 2.0.0
>
>         Attachments: jpa-nullrelation.tar.gz, OPENJPA-919-test-branches12x.patch, OPENJPA-919-test-trunk.patch, OPENJPA-919-trunk.patch
>
>
> Testcase to verify relationships in a bi-directional OneToOne are null (as tested for by the EJB TCK) when:
> 1) the relations are not set (should default to null)
> 2) the relations are explicitly set to null

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.