You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@arrow.apache.org by "Kouhei Sutou (Jira)" <ji...@apache.org> on 2022/07/01 06:44:00 UTC

[jira] [Commented] (ARROW-16947) [C++] Remove boost dependency with thrift

    [ https://issues.apache.org/jira/browse/ARROW-16947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17561316#comment-17561316 ] 

Kouhei Sutou commented on ARROW-16947:
--------------------------------------

I think that the best approach for it to remove Boost dependencies from Thrift's public header files.

I created THRFIT-5602 and open a pull request for it as a first step: https://github.com/apache/thrift/pull/2630

If there are people who are interested in this, please comment on this issue. Let's work on this together.

> [C++] Remove boost dependency with thrift
> -----------------------------------------
>
>                 Key: ARROW-16947
>                 URL: https://issues.apache.org/jira/browse/ARROW-16947
>             Project: Apache Arrow
>          Issue Type: Improvement
>          Components: C++
>            Reporter: Neal Richardson
>            Assignee: Kouhei Sutou
>            Priority: Major
>              Labels: good-first-issue, good-second-issue
>
> [~kou] (re-)added this dependency in ARROW-16721: https://github.com/apache/arrow/pull/13292/files#r890849903. But looking at thrift/transport/TBufferTransports.h, the header we include that uses boost, the class we use from it doesn't seem to require boost itself. So maybe we can pull the class definition out that we need and inline/vendor it, so that we can drop the need for that header, and thus drop the need for boost with thrift.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)