[GitHub] ralf0131 closed pull request #49: remove hard code for registry url

[GitBox <gi...@apache.org>]

ralf0131 closed pull request #49: remove hard code for registry url
URL: https://github.com/apache/incubator-dubbo-ops/pull/49
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/dubbo-admin/src/main/resources/application.properties b/dubbo-admin/src/main/resources/application.properties
index e3b43bf..477174f 100644
--- a/dubbo-admin/src/main/resources/application.properties
+++ b/dubbo-admin/src/main/resources/application.properties
@@ -23,3 +23,5 @@ spring.messages.fallback-to-system-locale=false
 spring.messages.basename=i18n/message
 spring.root.password=root
 spring.guest.password=guest
+
+dubbo.registry.address=zookeeper://127.0.0.1:2181
diff --git a/dubbo-admin/src/main/resources/dubbo-admin.xml b/dubbo-admin/src/main/resources/dubbo-admin.xml
index 332a3eb..f32036c 100644
--- a/dubbo-admin/src/main/resources/dubbo-admin.xml
+++ b/dubbo-admin/src/main/resources/dubbo-admin.xml
@@ -23,7 +23,7 @@
        http://dubbo.apache.org/schema/dubbo http://dubbo.apache.org/schema/dubbo/dubbo.xsd">
 
     <dubbo:application name="dubbo-admin"/>
-    <dubbo:registry address="zookeeper://127.0.0.1:2181"/>
+    <dubbo:registry address="${dubbo.registry.address}"/>
     <dubbo:reference id="registryService" interface="com.alibaba.dubbo.registry.RegistryService" check="false"/>
 
 </beans>
\ No newline at end of file


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org