You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Sarath Subramanian <sa...@apache.org> on 2020/09/23 06:58:40 UTC
Review Request 72902: ATLAS-3875: Introduce python client for Atlas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72902/
-----------------------------------------------------------
Review request for atlas, Ashutosh Mestry and Madhan Neethiraj.
Bugs: ATLAS-3875
https://issues.apache.org/jira/browse/ATLAS-3875
Repository: atlas
Description
-------
This is a updated patch from https://reviews.apache.org/r/72730/
Few additional changes:
* Formatting changes
* Renamed atlas_client to apache_atlas
* Moved client and model files into intg module
* Updated README files.
---------------------------------
Added basic structure for Python client
This includes all classes for Entity and TypeDef
Added all endpoints for typedef, Entity, Glossary, Lineage and Relationship
Added Python Sample project to test basic APIs and as a guideline
Added logging and readme file
Diffs
-----
.gitignore 90ca27646
atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/GlossaryExample.java e4fc4edbf
atlas-examples/sample-app/src/main/python/README.md PRE-CREATION
atlas-examples/sample-app/src/main/python/discovery_example.py PRE-CREATION
atlas-examples/sample-app/src/main/python/entity_example.py PRE-CREATION
atlas-examples/sample-app/src/main/python/glossary_example.py PRE-CREATION
atlas-examples/sample-app/src/main/python/lineage_example.py PRE-CREATION
atlas-examples/sample-app/src/main/python/request_json/entity_create_db.json PRE-CREATION
atlas-examples/sample-app/src/main/python/request_json/entity_create_process.json PRE-CREATION
atlas-examples/sample-app/src/main/python/request_json/entity_create_table_canada.json PRE-CREATION
atlas-examples/sample-app/src/main/python/request_json/entity_create_table_us.json PRE-CREATION
atlas-examples/sample-app/src/main/python/request_json/typedef_create.json PRE-CREATION
atlas-examples/sample-app/src/main/python/sample_client.py PRE-CREATION
atlas-examples/sample-app/src/main/python/typedef_example.py PRE-CREATION
atlas-examples/sample-app/src/main/python/utils.py PRE-CREATION
intg/src/main/python/LICENSE PRE-CREATION
intg/src/main/python/README.md PRE-CREATION
intg/src/main/python/apache_atlas/__init__.py PRE-CREATION
intg/src/main/python/apache_atlas/base_client.py PRE-CREATION
intg/src/main/python/apache_atlas/client/__init__.py PRE-CREATION
intg/src/main/python/apache_atlas/client/discovery.py PRE-CREATION
intg/src/main/python/apache_atlas/client/entity.py PRE-CREATION
intg/src/main/python/apache_atlas/client/glossary.py PRE-CREATION
intg/src/main/python/apache_atlas/client/lineage.py PRE-CREATION
intg/src/main/python/apache_atlas/client/relationship.py PRE-CREATION
intg/src/main/python/apache_atlas/client/typedef.py PRE-CREATION
intg/src/main/python/apache_atlas/exceptions.py PRE-CREATION
intg/src/main/python/apache_atlas/model/__init__.py PRE-CREATION
intg/src/main/python/apache_atlas/model/discovery.py PRE-CREATION
intg/src/main/python/apache_atlas/model/entity.py PRE-CREATION
intg/src/main/python/apache_atlas/model/glossary.py PRE-CREATION
intg/src/main/python/apache_atlas/model/lineage.py PRE-CREATION
intg/src/main/python/apache_atlas/model/relationship.py PRE-CREATION
intg/src/main/python/apache_atlas/model/typedef.py PRE-CREATION
intg/src/main/python/apache_atlas/utils.py PRE-CREATION
intg/src/main/python/requirements.txt PRE-CREATION
intg/src/main/python/setup.py PRE-CREATION
intg/src/main/python/tests/__init__.py PRE-CREATION
Diff: https://reviews.apache.org/r/72902/diff/1/
Testing
-------
Local testing done
Thanks,
Sarath Subramanian
Re: Review Request 72902: ATLAS-3875: Introduce python client for
Atlas (updated patch from https://reviews.apache.org/r/72730/)
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72902/#review222041
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On Oct. 13, 2020, 10:05 p.m., Sarath Subramanian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72902/
> -----------------------------------------------------------
>
> (Updated Oct. 13, 2020, 10:05 p.m.)
>
>
> Review request for atlas, Ashutosh Mestry and Madhan Neethiraj.
>
>
> Bugs: ATLAS-3875
> https://issues.apache.org/jira/browse/ATLAS-3875
>
>
> Repository: atlas
>
>
> Description
> -------
>
> This is a updated patch from https://reviews.apache.org/r/72730/
>
> Few additional changes:
> 1. Formatting changes
> 2. Renamed atlas_client to apache_atlas
> 3. Moved client and model files into intg module
> 4. Updated README files.
>
> ---------------------------------
> Added basic structure for Python client
> This includes all classes for Entity and TypeDef
> Added all endpoints for typedef, Entity, Glossary, Lineage and Relationship
> Added Python Sample project to test basic APIs and as a guideline
> Added logging and readme file
>
>
> Diffs
> -----
>
> .gitignore 90ca27646
> atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/GlossaryExample.java e4fc4edbf
> atlas-examples/sample-app/src/main/python/README.md PRE-CREATION
> atlas-examples/sample-app/src/main/python/discovery_example.py PRE-CREATION
> atlas-examples/sample-app/src/main/python/entity_example.py PRE-CREATION
> atlas-examples/sample-app/src/main/python/glossary_example.py PRE-CREATION
> atlas-examples/sample-app/src/main/python/lineage_example.py PRE-CREATION
> atlas-examples/sample-app/src/main/python/request_json/entity_create_db.json PRE-CREATION
> atlas-examples/sample-app/src/main/python/request_json/entity_create_process.json PRE-CREATION
> atlas-examples/sample-app/src/main/python/request_json/entity_create_table_canada.json PRE-CREATION
> atlas-examples/sample-app/src/main/python/request_json/entity_create_table_us.json PRE-CREATION
> atlas-examples/sample-app/src/main/python/request_json/typedef_create.json PRE-CREATION
> atlas-examples/sample-app/src/main/python/sample_client.py PRE-CREATION
> atlas-examples/sample-app/src/main/python/typedef_example.py PRE-CREATION
> atlas-examples/sample-app/src/main/python/utils.py PRE-CREATION
> intg/src/main/python/LICENSE PRE-CREATION
> intg/src/main/python/README.md PRE-CREATION
> intg/src/main/python/apache_atlas/__init__.py PRE-CREATION
> intg/src/main/python/apache_atlas/base_client.py PRE-CREATION
> intg/src/main/python/apache_atlas/client/__init__.py PRE-CREATION
> intg/src/main/python/apache_atlas/client/discovery.py PRE-CREATION
> intg/src/main/python/apache_atlas/client/entity.py PRE-CREATION
> intg/src/main/python/apache_atlas/client/glossary.py PRE-CREATION
> intg/src/main/python/apache_atlas/client/lineage.py PRE-CREATION
> intg/src/main/python/apache_atlas/client/relationship.py PRE-CREATION
> intg/src/main/python/apache_atlas/client/typedef.py PRE-CREATION
> intg/src/main/python/apache_atlas/exceptions.py PRE-CREATION
> intg/src/main/python/apache_atlas/model/__init__.py PRE-CREATION
> intg/src/main/python/apache_atlas/model/discovery.py PRE-CREATION
> intg/src/main/python/apache_atlas/model/entity.py PRE-CREATION
> intg/src/main/python/apache_atlas/model/glossary.py PRE-CREATION
> intg/src/main/python/apache_atlas/model/lineage.py PRE-CREATION
> intg/src/main/python/apache_atlas/model/relationship.py PRE-CREATION
> intg/src/main/python/apache_atlas/model/typedef.py PRE-CREATION
> intg/src/main/python/apache_atlas/utils.py PRE-CREATION
> intg/src/main/python/requirements.txt PRE-CREATION
> intg/src/main/python/setup.py PRE-CREATION
> intg/src/test/python/__init__.py PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/72902/diff/3/
>
>
> Testing
> -------
>
> Local testing done
>
>
> Thanks,
>
> Sarath Subramanian
>
>
Re: Review Request 72902: ATLAS-3875: Introduce python client for
Atlas (updated patch from https://reviews.apache.org/r/72730/)
Posted by Sarath Subramanian <sa...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72902/
-----------------------------------------------------------
(Updated Oct. 13, 2020, 3:05 p.m.)
Review request for atlas, Ashutosh Mestry and Madhan Neethiraj.
Changes
-------
addressed review comments
Bugs: ATLAS-3875
https://issues.apache.org/jira/browse/ATLAS-3875
Repository: atlas
Description
-------
This is a updated patch from https://reviews.apache.org/r/72730/
Few additional changes:
1. Formatting changes
2. Renamed atlas_client to apache_atlas
3. Moved client and model files into intg module
4. Updated README files.
---------------------------------
Added basic structure for Python client
This includes all classes for Entity and TypeDef
Added all endpoints for typedef, Entity, Glossary, Lineage and Relationship
Added Python Sample project to test basic APIs and as a guideline
Added logging and readme file
Diffs (updated)
-----
.gitignore 90ca27646
atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/GlossaryExample.java e4fc4edbf
atlas-examples/sample-app/src/main/python/README.md PRE-CREATION
atlas-examples/sample-app/src/main/python/discovery_example.py PRE-CREATION
atlas-examples/sample-app/src/main/python/entity_example.py PRE-CREATION
atlas-examples/sample-app/src/main/python/glossary_example.py PRE-CREATION
atlas-examples/sample-app/src/main/python/lineage_example.py PRE-CREATION
atlas-examples/sample-app/src/main/python/request_json/entity_create_db.json PRE-CREATION
atlas-examples/sample-app/src/main/python/request_json/entity_create_process.json PRE-CREATION
atlas-examples/sample-app/src/main/python/request_json/entity_create_table_canada.json PRE-CREATION
atlas-examples/sample-app/src/main/python/request_json/entity_create_table_us.json PRE-CREATION
atlas-examples/sample-app/src/main/python/request_json/typedef_create.json PRE-CREATION
atlas-examples/sample-app/src/main/python/sample_client.py PRE-CREATION
atlas-examples/sample-app/src/main/python/typedef_example.py PRE-CREATION
atlas-examples/sample-app/src/main/python/utils.py PRE-CREATION
intg/src/main/python/LICENSE PRE-CREATION
intg/src/main/python/README.md PRE-CREATION
intg/src/main/python/apache_atlas/__init__.py PRE-CREATION
intg/src/main/python/apache_atlas/base_client.py PRE-CREATION
intg/src/main/python/apache_atlas/client/__init__.py PRE-CREATION
intg/src/main/python/apache_atlas/client/discovery.py PRE-CREATION
intg/src/main/python/apache_atlas/client/entity.py PRE-CREATION
intg/src/main/python/apache_atlas/client/glossary.py PRE-CREATION
intg/src/main/python/apache_atlas/client/lineage.py PRE-CREATION
intg/src/main/python/apache_atlas/client/relationship.py PRE-CREATION
intg/src/main/python/apache_atlas/client/typedef.py PRE-CREATION
intg/src/main/python/apache_atlas/exceptions.py PRE-CREATION
intg/src/main/python/apache_atlas/model/__init__.py PRE-CREATION
intg/src/main/python/apache_atlas/model/discovery.py PRE-CREATION
intg/src/main/python/apache_atlas/model/entity.py PRE-CREATION
intg/src/main/python/apache_atlas/model/glossary.py PRE-CREATION
intg/src/main/python/apache_atlas/model/lineage.py PRE-CREATION
intg/src/main/python/apache_atlas/model/relationship.py PRE-CREATION
intg/src/main/python/apache_atlas/model/typedef.py PRE-CREATION
intg/src/main/python/apache_atlas/utils.py PRE-CREATION
intg/src/main/python/requirements.txt PRE-CREATION
intg/src/main/python/setup.py PRE-CREATION
intg/src/test/python/__init__.py PRE-CREATION
Diff: https://reviews.apache.org/r/72902/diff/3/
Changes: https://reviews.apache.org/r/72902/diff/2-3/
Testing
-------
Local testing done
Thanks,
Sarath Subramanian
Re: Review Request 72902: ATLAS-3875: Introduce python client for
Atlas (updated patch from https://reviews.apache.org/r/72730/)
Posted by Sarath Subramanian <sa...@apache.org>.
> On Oct. 12, 2020, 1:01 a.m., Madhan Neethiraj wrote:
> > intg/src/main/python/apache_atlas/model/typedef.py
> > Lines 58 (patched)
> > <https://reviews.apache.org/r/72902/diff/2/?file=2240602#file2240602line58>
> >
> > Should category be constructor parameter in AtlasEnumDef, given the valuw would be ENUM for AtlasEnumDef. If this argument is needed for JSON deserialization, consider replacing default None with ENUM.
> >
> > Same for other classes as well: AtlasClassificationDef, AtlasEntityDef, AtlasRelationshipDef, AtlasBusinessMetadataDef,
yes 'category' needs to be part of contructor else deserialization fails. I have update default value from None to ENUM/STRUCT/CLASSIFICATION/ENTITY/BUSINESS_METADATA
- Sarath
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72902/#review222014
-----------------------------------------------------------
On Oct. 13, 2020, 3:05 p.m., Sarath Subramanian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72902/
> -----------------------------------------------------------
>
> (Updated Oct. 13, 2020, 3:05 p.m.)
>
>
> Review request for atlas, Ashutosh Mestry and Madhan Neethiraj.
>
>
> Bugs: ATLAS-3875
> https://issues.apache.org/jira/browse/ATLAS-3875
>
>
> Repository: atlas
>
>
> Description
> -------
>
> This is a updated patch from https://reviews.apache.org/r/72730/
>
> Few additional changes:
> 1. Formatting changes
> 2. Renamed atlas_client to apache_atlas
> 3. Moved client and model files into intg module
> 4. Updated README files.
>
> ---------------------------------
> Added basic structure for Python client
> This includes all classes for Entity and TypeDef
> Added all endpoints for typedef, Entity, Glossary, Lineage and Relationship
> Added Python Sample project to test basic APIs and as a guideline
> Added logging and readme file
>
>
> Diffs
> -----
>
> .gitignore 90ca27646
> atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/GlossaryExample.java e4fc4edbf
> atlas-examples/sample-app/src/main/python/README.md PRE-CREATION
> atlas-examples/sample-app/src/main/python/discovery_example.py PRE-CREATION
> atlas-examples/sample-app/src/main/python/entity_example.py PRE-CREATION
> atlas-examples/sample-app/src/main/python/glossary_example.py PRE-CREATION
> atlas-examples/sample-app/src/main/python/lineage_example.py PRE-CREATION
> atlas-examples/sample-app/src/main/python/request_json/entity_create_db.json PRE-CREATION
> atlas-examples/sample-app/src/main/python/request_json/entity_create_process.json PRE-CREATION
> atlas-examples/sample-app/src/main/python/request_json/entity_create_table_canada.json PRE-CREATION
> atlas-examples/sample-app/src/main/python/request_json/entity_create_table_us.json PRE-CREATION
> atlas-examples/sample-app/src/main/python/request_json/typedef_create.json PRE-CREATION
> atlas-examples/sample-app/src/main/python/sample_client.py PRE-CREATION
> atlas-examples/sample-app/src/main/python/typedef_example.py PRE-CREATION
> atlas-examples/sample-app/src/main/python/utils.py PRE-CREATION
> intg/src/main/python/LICENSE PRE-CREATION
> intg/src/main/python/README.md PRE-CREATION
> intg/src/main/python/apache_atlas/__init__.py PRE-CREATION
> intg/src/main/python/apache_atlas/base_client.py PRE-CREATION
> intg/src/main/python/apache_atlas/client/__init__.py PRE-CREATION
> intg/src/main/python/apache_atlas/client/discovery.py PRE-CREATION
> intg/src/main/python/apache_atlas/client/entity.py PRE-CREATION
> intg/src/main/python/apache_atlas/client/glossary.py PRE-CREATION
> intg/src/main/python/apache_atlas/client/lineage.py PRE-CREATION
> intg/src/main/python/apache_atlas/client/relationship.py PRE-CREATION
> intg/src/main/python/apache_atlas/client/typedef.py PRE-CREATION
> intg/src/main/python/apache_atlas/exceptions.py PRE-CREATION
> intg/src/main/python/apache_atlas/model/__init__.py PRE-CREATION
> intg/src/main/python/apache_atlas/model/discovery.py PRE-CREATION
> intg/src/main/python/apache_atlas/model/entity.py PRE-CREATION
> intg/src/main/python/apache_atlas/model/glossary.py PRE-CREATION
> intg/src/main/python/apache_atlas/model/lineage.py PRE-CREATION
> intg/src/main/python/apache_atlas/model/relationship.py PRE-CREATION
> intg/src/main/python/apache_atlas/model/typedef.py PRE-CREATION
> intg/src/main/python/apache_atlas/utils.py PRE-CREATION
> intg/src/main/python/requirements.txt PRE-CREATION
> intg/src/main/python/setup.py PRE-CREATION
> intg/src/test/python/__init__.py PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/72902/diff/3/
>
>
> Testing
> -------
>
> Local testing done
>
>
> Thanks,
>
> Sarath Subramanian
>
>
Re: Review Request 72902: ATLAS-3875: Introduce python client for
Atlas (updated patch from https://reviews.apache.org/r/72730/)
Posted by Sarath Subramanian <sa...@apache.org>.
> On Oct. 12, 2020, 1:01 a.m., Madhan Neethiraj wrote:
> > intg/src/main/python/apache_atlas/base_client.py
> > Lines 46 (patched)
> > <https://reviews.apache.org/r/72902/diff/2/?file=2240587#file2240587line46>
> >
> > If kerberos is not handled currently, consider adding in a subsequent patch.
will add kerberos support in subsequent patch
> On Oct. 12, 2020, 1:01 a.m., Madhan Neethiraj wrote:
> > intg/src/main/python/apache_atlas/base_client.py
> > Lines 60 (patched)
> > <https://reviews.apache.org/r/72902/diff/2/?file=2240587#file2240587line60>
> >
> > Similar to Java client, consider adding support for multiple URLs - in a subsequent patch.
will add kerberos support in subsequent patch
- Sarath
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72902/#review222014
-----------------------------------------------------------
On Oct. 13, 2020, 3:05 p.m., Sarath Subramanian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72902/
> -----------------------------------------------------------
>
> (Updated Oct. 13, 2020, 3:05 p.m.)
>
>
> Review request for atlas, Ashutosh Mestry and Madhan Neethiraj.
>
>
> Bugs: ATLAS-3875
> https://issues.apache.org/jira/browse/ATLAS-3875
>
>
> Repository: atlas
>
>
> Description
> -------
>
> This is a updated patch from https://reviews.apache.org/r/72730/
>
> Few additional changes:
> 1. Formatting changes
> 2. Renamed atlas_client to apache_atlas
> 3. Moved client and model files into intg module
> 4. Updated README files.
>
> ---------------------------------
> Added basic structure for Python client
> This includes all classes for Entity and TypeDef
> Added all endpoints for typedef, Entity, Glossary, Lineage and Relationship
> Added Python Sample project to test basic APIs and as a guideline
> Added logging and readme file
>
>
> Diffs
> -----
>
> .gitignore 90ca27646
> atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/GlossaryExample.java e4fc4edbf
> atlas-examples/sample-app/src/main/python/README.md PRE-CREATION
> atlas-examples/sample-app/src/main/python/discovery_example.py PRE-CREATION
> atlas-examples/sample-app/src/main/python/entity_example.py PRE-CREATION
> atlas-examples/sample-app/src/main/python/glossary_example.py PRE-CREATION
> atlas-examples/sample-app/src/main/python/lineage_example.py PRE-CREATION
> atlas-examples/sample-app/src/main/python/request_json/entity_create_db.json PRE-CREATION
> atlas-examples/sample-app/src/main/python/request_json/entity_create_process.json PRE-CREATION
> atlas-examples/sample-app/src/main/python/request_json/entity_create_table_canada.json PRE-CREATION
> atlas-examples/sample-app/src/main/python/request_json/entity_create_table_us.json PRE-CREATION
> atlas-examples/sample-app/src/main/python/request_json/typedef_create.json PRE-CREATION
> atlas-examples/sample-app/src/main/python/sample_client.py PRE-CREATION
> atlas-examples/sample-app/src/main/python/typedef_example.py PRE-CREATION
> atlas-examples/sample-app/src/main/python/utils.py PRE-CREATION
> intg/src/main/python/LICENSE PRE-CREATION
> intg/src/main/python/README.md PRE-CREATION
> intg/src/main/python/apache_atlas/__init__.py PRE-CREATION
> intg/src/main/python/apache_atlas/base_client.py PRE-CREATION
> intg/src/main/python/apache_atlas/client/__init__.py PRE-CREATION
> intg/src/main/python/apache_atlas/client/discovery.py PRE-CREATION
> intg/src/main/python/apache_atlas/client/entity.py PRE-CREATION
> intg/src/main/python/apache_atlas/client/glossary.py PRE-CREATION
> intg/src/main/python/apache_atlas/client/lineage.py PRE-CREATION
> intg/src/main/python/apache_atlas/client/relationship.py PRE-CREATION
> intg/src/main/python/apache_atlas/client/typedef.py PRE-CREATION
> intg/src/main/python/apache_atlas/exceptions.py PRE-CREATION
> intg/src/main/python/apache_atlas/model/__init__.py PRE-CREATION
> intg/src/main/python/apache_atlas/model/discovery.py PRE-CREATION
> intg/src/main/python/apache_atlas/model/entity.py PRE-CREATION
> intg/src/main/python/apache_atlas/model/glossary.py PRE-CREATION
> intg/src/main/python/apache_atlas/model/lineage.py PRE-CREATION
> intg/src/main/python/apache_atlas/model/relationship.py PRE-CREATION
> intg/src/main/python/apache_atlas/model/typedef.py PRE-CREATION
> intg/src/main/python/apache_atlas/utils.py PRE-CREATION
> intg/src/main/python/requirements.txt PRE-CREATION
> intg/src/main/python/setup.py PRE-CREATION
> intg/src/test/python/__init__.py PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/72902/diff/3/
>
>
> Testing
> -------
>
> Local testing done
>
>
> Thanks,
>
> Sarath Subramanian
>
>
Re: Review Request 72902: ATLAS-3875: Introduce python client for
Atlas (updated patch from https://reviews.apache.org/r/72730/)
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72902/#review222014
-----------------------------------------------------------
intg/src/main/python/apache_atlas/base_client.py
Lines 46 (patched)
<https://reviews.apache.org/r/72902/#comment311086>
If kerberos is not handled currently, consider adding in a subsequent patch.
intg/src/main/python/apache_atlas/base_client.py
Lines 60 (patched)
<https://reviews.apache.org/r/72902/#comment311087>
Similar to Java client, consider adding support for multiple URLs - in a subsequent patch.
intg/src/main/python/apache_atlas/base_client.py
Lines 90 (patched)
<https://reviews.apache.org/r/72902/#comment311085>
Consider checking for 'response = None', here and following if blocks:
if response is None:
...
else if response.status_code == api.expected_status:
...
else response.status_code == HTTPStatus.SERVICE_UNAVAILABLE:
...
else:
intg/src/main/python/apache_atlas/model/typedef.py
Lines 58 (patched)
<https://reviews.apache.org/r/72902/#comment311089>
Should category be constructor parameter in AtlasEnumDef, given the valuw would be ENUM for AtlasEnumDef. If this argument is needed for JSON deserialization, consider replacing default None with ENUM.
Same for other classes as well: AtlasClassificationDef, AtlasEntityDef, AtlasRelationshipDef, AtlasBusinessMetadataDef,
intg/src/main/python/tests/__init__.py
Lines 18 (patched)
<https://reviews.apache.org/r/72902/#comment311088>
I suggest to move intg/src/main/python/tests tto intg/src/test/python/
- Madhan Neethiraj
On Oct. 12, 2020, 7:12 a.m., Sarath Subramanian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72902/
> -----------------------------------------------------------
>
> (Updated Oct. 12, 2020, 7:12 a.m.)
>
>
> Review request for atlas, Ashutosh Mestry and Madhan Neethiraj.
>
>
> Bugs: ATLAS-3875
> https://issues.apache.org/jira/browse/ATLAS-3875
>
>
> Repository: atlas
>
>
> Description
> -------
>
> This is a updated patch from https://reviews.apache.org/r/72730/
>
> Few additional changes:
> 1. Formatting changes
> 2. Renamed atlas_client to apache_atlas
> 3. Moved client and model files into intg module
> 4. Updated README files.
>
> ---------------------------------
> Added basic structure for Python client
> This includes all classes for Entity and TypeDef
> Added all endpoints for typedef, Entity, Glossary, Lineage and Relationship
> Added Python Sample project to test basic APIs and as a guideline
> Added logging and readme file
>
>
> Diffs
> -----
>
> .gitignore 90ca27646
> atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/GlossaryExample.java e4fc4edbf
> atlas-examples/sample-app/src/main/python/README.md PRE-CREATION
> atlas-examples/sample-app/src/main/python/discovery_example.py PRE-CREATION
> atlas-examples/sample-app/src/main/python/entity_example.py PRE-CREATION
> atlas-examples/sample-app/src/main/python/glossary_example.py PRE-CREATION
> atlas-examples/sample-app/src/main/python/lineage_example.py PRE-CREATION
> atlas-examples/sample-app/src/main/python/request_json/entity_create_db.json PRE-CREATION
> atlas-examples/sample-app/src/main/python/request_json/entity_create_process.json PRE-CREATION
> atlas-examples/sample-app/src/main/python/request_json/entity_create_table_canada.json PRE-CREATION
> atlas-examples/sample-app/src/main/python/request_json/entity_create_table_us.json PRE-CREATION
> atlas-examples/sample-app/src/main/python/request_json/typedef_create.json PRE-CREATION
> atlas-examples/sample-app/src/main/python/sample_client.py PRE-CREATION
> atlas-examples/sample-app/src/main/python/typedef_example.py PRE-CREATION
> atlas-examples/sample-app/src/main/python/utils.py PRE-CREATION
> intg/src/main/python/LICENSE PRE-CREATION
> intg/src/main/python/README.md PRE-CREATION
> intg/src/main/python/apache_atlas/__init__.py PRE-CREATION
> intg/src/main/python/apache_atlas/base_client.py PRE-CREATION
> intg/src/main/python/apache_atlas/client/__init__.py PRE-CREATION
> intg/src/main/python/apache_atlas/client/discovery.py PRE-CREATION
> intg/src/main/python/apache_atlas/client/entity.py PRE-CREATION
> intg/src/main/python/apache_atlas/client/glossary.py PRE-CREATION
> intg/src/main/python/apache_atlas/client/lineage.py PRE-CREATION
> intg/src/main/python/apache_atlas/client/relationship.py PRE-CREATION
> intg/src/main/python/apache_atlas/client/typedef.py PRE-CREATION
> intg/src/main/python/apache_atlas/exceptions.py PRE-CREATION
> intg/src/main/python/apache_atlas/model/__init__.py PRE-CREATION
> intg/src/main/python/apache_atlas/model/discovery.py PRE-CREATION
> intg/src/main/python/apache_atlas/model/entity.py PRE-CREATION
> intg/src/main/python/apache_atlas/model/glossary.py PRE-CREATION
> intg/src/main/python/apache_atlas/model/lineage.py PRE-CREATION
> intg/src/main/python/apache_atlas/model/relationship.py PRE-CREATION
> intg/src/main/python/apache_atlas/model/typedef.py PRE-CREATION
> intg/src/main/python/apache_atlas/utils.py PRE-CREATION
> intg/src/main/python/requirements.txt PRE-CREATION
> intg/src/main/python/setup.py PRE-CREATION
> intg/src/main/python/tests/__init__.py PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/72902/diff/2/
>
>
> Testing
> -------
>
> Local testing done
>
>
> Thanks,
>
> Sarath Subramanian
>
>
Re: Review Request 72902: ATLAS-3875: Introduce python client for
Atlas (updated patch from https://reviews.apache.org/r/72730/)
Posted by Sarath Subramanian <sa...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72902/
-----------------------------------------------------------
(Updated Oct. 12, 2020, 12:12 a.m.)
Review request for atlas, Ashutosh Mestry and Madhan Neethiraj.
Bugs: ATLAS-3875
https://issues.apache.org/jira/browse/ATLAS-3875
Repository: atlas
Description
-------
This is a updated patch from https://reviews.apache.org/r/72730/
Few additional changes:
1. Formatting changes
2. Renamed atlas_client to apache_atlas
3. Moved client and model files into intg module
4. Updated README files.
---------------------------------
Added basic structure for Python client
This includes all classes for Entity and TypeDef
Added all endpoints for typedef, Entity, Glossary, Lineage and Relationship
Added Python Sample project to test basic APIs and as a guideline
Added logging and readme file
Diffs (updated)
-----
.gitignore 90ca27646
atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/GlossaryExample.java e4fc4edbf
atlas-examples/sample-app/src/main/python/README.md PRE-CREATION
atlas-examples/sample-app/src/main/python/discovery_example.py PRE-CREATION
atlas-examples/sample-app/src/main/python/entity_example.py PRE-CREATION
atlas-examples/sample-app/src/main/python/glossary_example.py PRE-CREATION
atlas-examples/sample-app/src/main/python/lineage_example.py PRE-CREATION
atlas-examples/sample-app/src/main/python/request_json/entity_create_db.json PRE-CREATION
atlas-examples/sample-app/src/main/python/request_json/entity_create_process.json PRE-CREATION
atlas-examples/sample-app/src/main/python/request_json/entity_create_table_canada.json PRE-CREATION
atlas-examples/sample-app/src/main/python/request_json/entity_create_table_us.json PRE-CREATION
atlas-examples/sample-app/src/main/python/request_json/typedef_create.json PRE-CREATION
atlas-examples/sample-app/src/main/python/sample_client.py PRE-CREATION
atlas-examples/sample-app/src/main/python/typedef_example.py PRE-CREATION
atlas-examples/sample-app/src/main/python/utils.py PRE-CREATION
intg/src/main/python/LICENSE PRE-CREATION
intg/src/main/python/README.md PRE-CREATION
intg/src/main/python/apache_atlas/__init__.py PRE-CREATION
intg/src/main/python/apache_atlas/base_client.py PRE-CREATION
intg/src/main/python/apache_atlas/client/__init__.py PRE-CREATION
intg/src/main/python/apache_atlas/client/discovery.py PRE-CREATION
intg/src/main/python/apache_atlas/client/entity.py PRE-CREATION
intg/src/main/python/apache_atlas/client/glossary.py PRE-CREATION
intg/src/main/python/apache_atlas/client/lineage.py PRE-CREATION
intg/src/main/python/apache_atlas/client/relationship.py PRE-CREATION
intg/src/main/python/apache_atlas/client/typedef.py PRE-CREATION
intg/src/main/python/apache_atlas/exceptions.py PRE-CREATION
intg/src/main/python/apache_atlas/model/__init__.py PRE-CREATION
intg/src/main/python/apache_atlas/model/discovery.py PRE-CREATION
intg/src/main/python/apache_atlas/model/entity.py PRE-CREATION
intg/src/main/python/apache_atlas/model/glossary.py PRE-CREATION
intg/src/main/python/apache_atlas/model/lineage.py PRE-CREATION
intg/src/main/python/apache_atlas/model/relationship.py PRE-CREATION
intg/src/main/python/apache_atlas/model/typedef.py PRE-CREATION
intg/src/main/python/apache_atlas/utils.py PRE-CREATION
intg/src/main/python/requirements.txt PRE-CREATION
intg/src/main/python/setup.py PRE-CREATION
intg/src/main/python/tests/__init__.py PRE-CREATION
Diff: https://reviews.apache.org/r/72902/diff/2/
Changes: https://reviews.apache.org/r/72902/diff/1-2/
Testing
-------
Local testing done
Thanks,
Sarath Subramanian
Re: Review Request 72902: ATLAS-3875: Introduce python client for
Atlas (updated patch from https://reviews.apache.org/r/72730/)
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72902/#review221999
-----------------------------------------------------------
Fix it, then Ship it!
Looks good Sarath!
intg/src/main/python/README.md
Lines 8 (patched)
<https://reviews.apache.org/r/72902/#comment311065>
'python setup.py install' - this seems to be performed by Atlas team, and not the end user of the library. Please review and update.
intg/src/main/python/apache_atlas/base_client.py
Lines 81 (patched)
<https://reviews.apache.org/r/72902/#comment311067>
'response' doesn't have to an attribute of AtlasClient instance. Since this is used only within call_api() method, consider using a local variable instead i.e. get rid of 'self.' prefix.
- Madhan Neethiraj
On Sept. 23, 2020, 6:58 a.m., Sarath Subramanian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72902/
> -----------------------------------------------------------
>
> (Updated Sept. 23, 2020, 6:58 a.m.)
>
>
> Review request for atlas, Ashutosh Mestry and Madhan Neethiraj.
>
>
> Bugs: ATLAS-3875
> https://issues.apache.org/jira/browse/ATLAS-3875
>
>
> Repository: atlas
>
>
> Description
> -------
>
> This is a updated patch from https://reviews.apache.org/r/72730/
>
> Few additional changes:
> 1. Formatting changes
> 2. Renamed atlas_client to apache_atlas
> 3. Moved client and model files into intg module
> 4. Updated README files.
>
> ---------------------------------
> Added basic structure for Python client
> This includes all classes for Entity and TypeDef
> Added all endpoints for typedef, Entity, Glossary, Lineage and Relationship
> Added Python Sample project to test basic APIs and as a guideline
> Added logging and readme file
>
>
> Diffs
> -----
>
> .gitignore 90ca27646
> atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/GlossaryExample.java e4fc4edbf
> atlas-examples/sample-app/src/main/python/README.md PRE-CREATION
> atlas-examples/sample-app/src/main/python/discovery_example.py PRE-CREATION
> atlas-examples/sample-app/src/main/python/entity_example.py PRE-CREATION
> atlas-examples/sample-app/src/main/python/glossary_example.py PRE-CREATION
> atlas-examples/sample-app/src/main/python/lineage_example.py PRE-CREATION
> atlas-examples/sample-app/src/main/python/request_json/entity_create_db.json PRE-CREATION
> atlas-examples/sample-app/src/main/python/request_json/entity_create_process.json PRE-CREATION
> atlas-examples/sample-app/src/main/python/request_json/entity_create_table_canada.json PRE-CREATION
> atlas-examples/sample-app/src/main/python/request_json/entity_create_table_us.json PRE-CREATION
> atlas-examples/sample-app/src/main/python/request_json/typedef_create.json PRE-CREATION
> atlas-examples/sample-app/src/main/python/sample_client.py PRE-CREATION
> atlas-examples/sample-app/src/main/python/typedef_example.py PRE-CREATION
> atlas-examples/sample-app/src/main/python/utils.py PRE-CREATION
> intg/src/main/python/LICENSE PRE-CREATION
> intg/src/main/python/README.md PRE-CREATION
> intg/src/main/python/apache_atlas/__init__.py PRE-CREATION
> intg/src/main/python/apache_atlas/base_client.py PRE-CREATION
> intg/src/main/python/apache_atlas/client/__init__.py PRE-CREATION
> intg/src/main/python/apache_atlas/client/discovery.py PRE-CREATION
> intg/src/main/python/apache_atlas/client/entity.py PRE-CREATION
> intg/src/main/python/apache_atlas/client/glossary.py PRE-CREATION
> intg/src/main/python/apache_atlas/client/lineage.py PRE-CREATION
> intg/src/main/python/apache_atlas/client/relationship.py PRE-CREATION
> intg/src/main/python/apache_atlas/client/typedef.py PRE-CREATION
> intg/src/main/python/apache_atlas/exceptions.py PRE-CREATION
> intg/src/main/python/apache_atlas/model/__init__.py PRE-CREATION
> intg/src/main/python/apache_atlas/model/discovery.py PRE-CREATION
> intg/src/main/python/apache_atlas/model/entity.py PRE-CREATION
> intg/src/main/python/apache_atlas/model/glossary.py PRE-CREATION
> intg/src/main/python/apache_atlas/model/lineage.py PRE-CREATION
> intg/src/main/python/apache_atlas/model/relationship.py PRE-CREATION
> intg/src/main/python/apache_atlas/model/typedef.py PRE-CREATION
> intg/src/main/python/apache_atlas/utils.py PRE-CREATION
> intg/src/main/python/requirements.txt PRE-CREATION
> intg/src/main/python/setup.py PRE-CREATION
> intg/src/main/python/tests/__init__.py PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/72902/diff/1/
>
>
> Testing
> -------
>
> Local testing done
>
>
> Thanks,
>
> Sarath Subramanian
>
>