You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/06/24 10:19:51 UTC
[GitHub] [incubator-nuttx] anchao opened a new pull request #1290: tools/mkdeps: add long path name support
anchao opened a new pull request #1290:
URL: https://github.com/apache/incubator-nuttx/pull/1290
## Summary
tools/mkdeps: add long path name support
Generated dependency will be invalid if the compile target with multi-directory level
## Impact
make dependence
## Testing
make a test file:
```
diff --git a/examples/hello/Makefile b/examples/hello/Makefile
index 96ba358..76ee850 100644
--- a/examples/hello/Makefile
+++ b/examples/hello/Makefile
@@ -42,6 +42,8 @@ PRIORITY = $(CONFIG_EXAMPLES_HELLO_PRIORITY)
STACKSIZE = $(CONFIG_EXAMPLES_HELLO_STACKSIZE)
MODULE = $(CONFIG_EXAMPLES_HELLO)
+CSRCS = testdir/test.c
+
# Hello, World! Example
MAINSRC = hello_main.c
apps/examples/hello$ ls testdir/
test.c
```
Check the Make.dep:
Before patch:
```
apps/examples/hello$ ls testdir/
test.c test.home.archer.code.apps.examples.hello.o
apps/examples/hello$ cat Make.dep
test.home.archer.code.apps.examples.hello.o: testdir/test.c \
/usr/include/stdc-predef.h
```
After patch:
```
apps/examples/hello$ cat Make.dep
testdir/test.home.archer.code.apps.examples.hello.o: testdir/test.c \
/usr/include/stdc-predef.h
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] anchao commented on pull request #1290: tools/mkdeps: add long path name support
Posted by GitBox <gi...@apache.org>.
anchao commented on pull request #1290:
URL: https://github.com/apache/incubator-nuttx/pull/1290#issuecomment-648771168
Depends on https://github.com/apache/incubator-nuttx-apps/pull/304
Please review the apps/ changes first
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] anchao commented on pull request #1290: tools/mkdeps: add long path name support
Posted by GitBox <gi...@apache.org>.
anchao commented on pull request #1290:
URL: https://github.com/apache/incubator-nuttx/pull/1290#issuecomment-648911212
Oops...this change will have the side effects on "clean" stage, abandon for reconsider the implementation
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] anchao closed pull request #1290: tools/mkdeps: add long path name support
Posted by GitBox <gi...@apache.org>.
anchao closed pull request #1290:
URL: https://github.com/apache/incubator-nuttx/pull/1290
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org