You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@kyuubi.apache.org by GitBox <gi...@apache.org> on 2021/10/09 06:46:55 UTC

[GitHub] [incubator-kyuubi] pan3793 commented on a change in pull request #1129: [KYUUBI #1085][FOLLOWUP] Fix-Enforce maxOutputRows for aggregate with having statement

pan3793 commented on a change in pull request #1129:
URL: https://github.com/apache/incubator-kyuubi/pull/1129#discussion_r725444300



##########
File path: dev/kyuubi-extension-spark-3-1/src/main/scala/org/apache/kyuubi/sql/KyuubiSparkSQLExtension.scala
##########
@@ -54,5 +54,6 @@ class KyuubiSparkSQLExtension extends (SparkSessionExtensions => Unit) {
     extensions.injectQueryStagePrepRule(FinalStageConfigIsolation(_))
     extensions.injectPlannerStrategy(MaxHivePartitionStrategy)
     extensions.injectPostHocResolutionRule(ForcedMaxOutputRowsRule)
+    extensions.injectResolutionRule(MarkAggregateOrderRule)

Review comment:
       Can move these 2 rules up? Let `Rule` and `Strategy` be sorted by execution.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org