You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@eventmesh.apache.org by "Alonexc (via GitHub)" <gi...@apache.org> on 2023/05/04 02:38:10 UTC
[GitHub] [eventmesh] Alonexc commented on a diff in pull request #3857: [ISSUE #3832]Do some code optimization.[storage ProducerImpl]
Alonexc commented on code in PR #3857:
URL: https://github.com/apache/eventmesh/pull/3857#discussion_r1184485363
##########
eventmesh-storage-plugin/eventmesh-storage-kafka/src/main/java/org/apache/eventmesh/storage/kafka/producer/ProducerImpl.java:
##########
@@ -107,7 +107,7 @@ public void sendOneway(CloudEvent message) {
public void sendAsync(CloudEvent cloudEvent, SendCallback sendCallback) {
try {
- this.producer.send(new ProducerRecord<>(cloudEvent.getSubject(), cloudEvent), (metadata, exception) -> {
+ this.producer.send(new ProducerRecord<>(Objects.requireNonNull(cloudEvent.getSubject(), cloudEvent), (metadata, exception) -> {
Review Comment:
Need to add a `)`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org