You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2025/06/25 04:25:55 UTC
[kudu-CR] KUDU-3671 severity level filtering for /metrics prometheus
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/23093
Change subject: KUDU-3671 severity level filtering for /metrics_prometheus
......................................................................
KUDU-3671 severity level filtering for /metrics_prometheus
This changelist implements severity level filtering for the
/metrics_prometheus endpoint of the embedded Kudu webserver based
on the current setting for the --metrics_default_level flag. This
is now similar to the filtering for the /metrics endpoints, but the
severity level filtering for the /metrics_prometheus cannot be
overridden by query options as of this changelist. Basic test
scenarios for Kudu master and tablet server are included.
Change-Id: If1542476f06d575594e8b3636cab3681f1b6fdfa
---
M src/kudu/master/master-test.cc
M src/kudu/server/default_path_handlers.cc
M src/kudu/tserver/tablet_server-test.cc
M src/kudu/util/metrics-test.cc
M src/kudu/util/metrics.cc
M src/kudu/util/metrics.h
6 files changed, 135 insertions(+), 24 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/93/23093/1
--
To view, visit http://gerrit.cloudera.org:8080/23093
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If1542476f06d575594e8b3636cab3681f1b6fdfa
Gerrit-Change-Number: 23093
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
[kudu-CR] KUDU-3671 severity level filtering for /metrics prometheus
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/23093 )
Change subject: KUDU-3671 severity level filtering for /metrics_prometheus
......................................................................
KUDU-3671 severity level filtering for /metrics_prometheus
This changelist implements severity level filtering for the
/metrics_prometheus endpoint of the embedded Kudu webserver based
on the current setting for the --metrics_default_level flag. This
is now similar to the filtering for the /metrics endpoints, but the
severity level filtering for the /metrics_prometheus cannot be
overridden by query options as of this changelist. Basic test
scenarios for Kudu master and tablet server are included.
Change-Id: If1542476f06d575594e8b3636cab3681f1b6fdfa
Reviewed-on: http://gerrit.cloudera.org:8080/23093
Reviewed-by: Abhishek Chennaka <ac...@cloudera.com>
Tested-by: Alexey Serbin <al...@apache.org>
---
M src/kudu/master/master-test.cc
M src/kudu/server/default_path_handlers.cc
M src/kudu/tserver/tablet_server-test.cc
M src/kudu/util/metrics-test.cc
M src/kudu/util/metrics.cc
M src/kudu/util/metrics.h
6 files changed, 135 insertions(+), 24 deletions(-)
Approvals:
Abhishek Chennaka: Looks good to me, approved
Alexey Serbin: Verified
--
To view, visit http://gerrit.cloudera.org:8080/23093
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: If1542476f06d575594e8b3636cab3681f1b6fdfa
Gerrit-Change-Number: 23093
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] KUDU-3671 severity level filtering for /metrics prometheus
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/23093 )
Change subject: KUDU-3671 severity level filtering for /metrics_prometheus
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/23093
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If1542476f06d575594e8b3636cab3681f1b6fdfa
Gerrit-Change-Number: 23093
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 25 Jun 2025 04:36:39 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3671 severity level filtering for /metrics prometheus
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23093 )
Change subject: KUDU-3671 severity level filtering for /metrics_prometheus
......................................................................
Patch Set 1: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/1505/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/23093
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If1542476f06d575594e8b3636cab3681f1b6fdfa
Gerrit-Change-Number: 23093
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 25 Jun 2025 07:11:50 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3671 severity level filtering for /metrics prometheus
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23093 )
Change subject: KUDU-3671 severity level filtering for /metrics_prometheus
......................................................................
Patch Set 1:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/1505/
--
To view, visit http://gerrit.cloudera.org:8080/23093
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If1542476f06d575594e8b3636cab3681f1b6fdfa
Gerrit-Change-Number: 23093
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 25 Jun 2025 04:26:02 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3671 severity level filtering for /metrics prometheus
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23093 )
Change subject: KUDU-3671 severity level filtering for /metrics_prometheus
......................................................................
Patch Set 1: Verified+1
unrelated test failures:
* DEBUG: master_replication-itest
* TSAN: org.apache.kudu.client.TestKuduClient
--
To view, visit http://gerrit.cloudera.org:8080/23093
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If1542476f06d575594e8b3636cab3681f1b6fdfa
Gerrit-Change-Number: 23093
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 25 Jun 2025 15:04:20 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3671 severity level filtering for /metrics prometheus
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: KUDU-3671 severity level filtering for /metrics_prometheus
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/23093
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: If1542476f06d575594e8b3636cab3681f1b6fdfa
Gerrit-Change-Number: 23093
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)