You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/04/14 09:00:32 UTC
[GitHub] [incubator-shardingsphere] tristaZero opened a new pull request
#5177: Use Standard Algorithm instead of Old one
tristaZero opened a new pull request #5177: Use Standard Algorithm instead of Old one
URL: https://github.com/apache/incubator-shardingsphere/pull/5177
Ref #5017
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #5177: Use
Standard Algorithm instead of Old one
Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #5177: Use Standard Algorithm instead of Old one
URL: https://github.com/apache/incubator-shardingsphere/pull/5177#issuecomment-613369185
## Pull Request Test Coverage Report for [Build 11036](https://coveralls.io/builds/30063103)
* **8** of **11** **(72.73%)** changed or added relevant lines in **2** files are covered.
* **11** unchanged lines in **3** files lost coverage.
* Overall coverage decreased (**-0.04%**) to **57.548%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [sharding-core/sharding-core-common/src/main/java/org/apache/shardingsphere/core/strategy/route/standard/StandardShardingStrategy.java](https://coveralls.io/builds/30063103/source?filename=sharding-core%2Fsharding-core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Fstrategy%2Froute%2Fstandard%2FStandardShardingStrategy.java#L88) | 6 | 9 | 66.67%
<!-- | **Total:** | **8** | **11** | **72.73%** | -->
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [sharding-core/sharding-core-common/src/main/java/org/apache/shardingsphere/core/strategy/route/standard/StandardShardingStrategy.java](https://coveralls.io/builds/30063103/source?filename=sharding-core%2Fsharding-core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Fstrategy%2Froute%2Fstandard%2FStandardShardingStrategy.java#L79) | 2 | 61.76% |
| [sharding-core/sharding-core-common/src/main/java/org/apache/shardingsphere/core/strategy/route/ShardingAlgorithmFactory.java](https://coveralls.io/builds/30063103/source?filename=sharding-core%2Fsharding-core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Fstrategy%2Froute%2FShardingAlgorithmFactory.java#L43) | 3 | 0% |
| [sharding-core/sharding-core-common/src/main/java/org/apache/shardingsphere/core/yaml/swapper/ShardingStrategyConfigurationYamlSwapper.java](https://coveralls.io/builds/30063103/source?filename=sharding-core%2Fsharding-core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Fyaml%2Fswapper%2FShardingStrategyConfigurationYamlSwapper.java#L84) | 6 | 89.19% |
<!-- | **Total:** | **11** | | -->
| Totals | [](https://coveralls.io/builds/30063103) |
| :-- | --: |
| Change from base [Build 11029](https://coveralls.io/builds/30061739): | -0.04% |
| Covered Lines: | 11841 |
| Relevant Lines: | 20576 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu merged pull request #5177: Use
Standard Algorithm instead of Old one
Posted by GitBox <gi...@apache.org>.
terrymanu merged pull request #5177: Use Standard Algorithm instead of Old one
URL: https://github.com/apache/incubator-shardingsphere/pull/5177
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] codecov-io commented on issue #5177: Use
Standard Algorithm instead of Old one
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #5177: Use Standard Algorithm instead of Old one
URL: https://github.com/apache/incubator-shardingsphere/pull/5177#issuecomment-613367313
# [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5177?src=pr&el=h1) Report
> Merging [#5177](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5177?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-shardingsphere/commit/f00955686375eb2708e94ed6f573c4992fffe9cd&el=desc) will **decrease** coverage by `0.04%`.
> The diff coverage is `36.36%`.
[](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5177?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5177 +/- ##
============================================
- Coverage 54.15% 54.10% -0.05%
Complexity 406 406
============================================
Files 1158 1158
Lines 20568 20576 +8
Branches 3707 3712 +5
============================================
- Hits 11138 11133 -5
- Misses 8737 8749 +12
- Partials 693 694 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5177?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ategy/route/standard/StandardShardingStrategy.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5177/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvY29yZS9zdHJhdGVneS9yb3V0ZS9zdGFuZGFyZC9TdGFuZGFyZFNoYXJkaW5nU3RyYXRlZ3kuamF2YQ==) | `50.00% <33.33%> (-12.97%)` | `0.00 <0.00> (ø)` | |
| [...pper/ShardingStrategyConfigurationYamlSwapper.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5177/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvY29yZS95YW1sL3N3YXBwZXIvU2hhcmRpbmdTdHJhdGVneUNvbmZpZ3VyYXRpb25ZYW1sU3dhcHBlci5qYXZh) | `82.43% <50.00%> (-5.24%)` | `0.00 <0.00> (ø)` | |
| [.../core/strategy/route/ShardingAlgorithmFactory.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5177/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvY29yZS9zdHJhdGVneS9yb3V0ZS9TaGFyZGluZ0FsZ29yaXRobUZhY3RvcnkuamF2YQ==) | `0.00% <0.00%> (-40.00%)` | `0.00% <0.00%> (ø%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5177?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5177?src=pr&el=footer). Last update [f009556...08f1e64](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5177?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services