You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/01/25 03:46:53 UTC

[GitHub] [superset] AAfghahi commented on a change in pull request #18157: fix: remove standalone

AAfghahi commented on a change in pull request #18157:
URL: https://github.com/apache/superset/pull/18157#discussion_r791334059



##########
File path: tests/integration_tests/reports/commands_tests.py
##########
@@ -1767,7 +1767,7 @@ def test_when_tabs_are_selected_it_takes_screenshots_for_every_tabs(
     assert dashboard_screenshot_mock.call_count == 2
     for index, tab in enumerate(tabs):
         assert dashboard_screenshot_mock.call_args_list[index].args == (
-            f"http://0.0.0.0:8080/superset/dashboard/{dashboard.id}/?standalone=3#{tab}",
+            f"http://0.0.0.0:8080/superset/dashboard/{dashboard.id}/?#{tab}",

Review comment:
       ```suggestion
               f"http://0.0.0.0:8080/superset/dashboard/{dashboard.id}/#{tab}",
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org