You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hop.apache.org by "mattcasters (via GitHub)" <gi...@apache.org> on 2026/09/25 15:06:40 UTC
[PR] Issue #8621 : Find a value in a table view (hop)
mattcasters opened a new pull request, #8622:
URL: https://github.com/apache/hop/pull/8622
The table search button stays the only find icon. Clicking it opens a menu with **Find value** and **Find column**. Find column is the existing column picker. Find value opens a dialog with the columns on the left (all checked) and the search string, case sensitive, and regular expression options on the right. Find first and Find next keep the dialog open. A match scrolls the row and column into view; in an editable grid the cell text is selected. Ctrl-F (Command-F on macOS) opens Find value. Filtered selection no longer advertises Ctrl-F, which was not wired to a key.
fixes #8621
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Run `mvn clean install apache-rat:check` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
- [x] If you have a group of commits related to the same change, please squash your commits into one and force push your branch using `git rebase -i`.
- [x] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable.
To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [x] I hereby declare this contribution to be licensed under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Issue #8621 : Find a value in a table view (hop)
Posted by "mattcasters (via GitHub)" <gi...@apache.org>.
mattcasters merged PR #8622:
URL: https://github.com/apache/hop/pull/8622
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Issue #8621 : Find a value in a table view (hop)
Posted by "bamaer (via GitHub)" <gi...@apache.org>.
bamaer commented on PR #8622:
URL: https://github.com/apache/hop/pull/8622#issuecomment-5846508614
**Blockers**
**1. `revealFoundCell()` reuses `edit()`, so a hit performs a click.** `editText` returns early to fire the column's selection adapter (`TableView.java:3279`) or open the multi-line pop-out (`TableView.java:3290`). Six dialogs put an adapter on their `COLUMN_TYPE_TEXT` value column — Formula, Janino, Calculator, Random value, System data, Neo4j Get logging info — so every hit there opens a sub-dialog over the modal find dialog. And the pop-out's queued `asyncExec` (`TableView.java:2337`) steals focus back out of the search field after `showHit` set it, so Enter closes the pop-out instead of finding next.
```java
ColumnInfo colinfo = columns[dataColumn];
if (!readonly
&& !colinfo.isReadOnly()
&& colinfo.getSelectionAdapter() == null
&& indexOfLineBreak(getCellValue(item, tableColumnIndex)) < 0) {
edit(row, tableColumnIndex);
}
```
`setPosition` already ran, so the skipped case still leaves the active cell right.
**2. `lastHit` is never reset.** Change the search text, press Enter (Find next is the default button) and the scan resumes from the previous query's hit — earlier rows are never looked at, and `continued` makes the status say "No more matches". Reset it from a `ModifyListener` on `wFind` and selection listeners on the two checkboxes.
**Should fix**
**3. Dead reuse path.** `open()` runs its own event loop (`BaseDialog.java:929`) and the `finally` nulls `findDialog`, and `APPLICATION_MODAL` stops the table's Ctrl-F handlers firing, so `findDialog` / `isOpen()` are unreachable. Drop them, or make the shell modeless — which is what "stays open" implies, and would let the user type in the cell the search revealed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org