You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/09/30 16:49:05 UTC

[GitHub] [spark] amaliujia commented on pull request #38061: [SPARK-40448][CONNECT][FOLLOWUP] Use more suitable message name.

amaliujia commented on PR #38061:
URL: https://github.com/apache/spark/pull/38061#issuecomment-1263798502

   It's ok to fix code style on, for example, scala server side. 
   
   I want to hold a bit on the proto side. The proto itself will evolve quickly and itself is not at a stable position now. Whatever we change now could be no longer useful soon. Plus every time we update the proto we need to update the generate file on the python side. We are planing to change the python side with some sort of automatic way for python proto generation. 
   
   Before that is achieved, the idea could be that we limit changes on the proto to only core API coverage to unblock other pieces (DataFrame API etc.)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org