[GitHub] [incubator-dolphinscheduler] Jave-Chen commented on a change in pull request #1910: Adapting partial code(file name start with A) to the sonar cloud rules

[GitBox <gi...@apache.org>]

Jave-Chen commented on a change in pull request #1910: Adapting partial code(file name start with A) to the sonar cloud rules
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1910#discussion_r376751616
 
 

 ##########
 File path: dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/shell/AbstractShell.java
 ##########
 @@ -281,7 +283,7 @@ public void run() {
         //Process has not terminated.
         //So check if it has completed 
         //if not just destroy it.
-        if (p != null && !shell.completed.get()) {
+        if (!shell.completed.get()) {
           shell.setTimedOut();
 
 Review comment:
   If  runCommand is not called, process may  be null , use ` !(p  instanceof Process) ` to check it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services