You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Alejandro Abdelnur (Created) (JIRA)" <ji...@apache.org> on 2011/12/19 19:57:31 UTC
[jira] [Created] (HDFS-2705) HttpFS server should check that upload
requests have correct content-type
HttpFS server should check that upload requests have correct content-type
-------------------------------------------------------------------------
Key: HDFS-2705
URL: https://issues.apache.org/jira/browse/HDFS-2705
Project: Hadoop HDFS
Issue Type: Bug
Affects Versions: 0.24.0, 0.23.1
Reporter: Alejandro Abdelnur
Assignee: Alejandro Abdelnur
Fix For: 0.24.0, 0.23.1
The append/create requests should require 'application/octet-stream' as content-type when uploading data. This is to prevent the default content-type form-encoded (used as default by some HTTP libraries) to be used or text based content-types to be used.
If the form-encoded content type is used, then Jersey tries to process the upload stream as parameters
If a test base content-type is used, HTTP proxies/gateways could do attempt some transcoding on the stream thus corrupting the data.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-2705) HttpFS server should check that upload
requests have correct content-type
Posted by "Alejandro Abdelnur (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alejandro Abdelnur updated HDFS-2705:
-------------------------------------
Attachment: HDFS-2705.patch
> HttpFS server should check that upload requests have correct content-type
> -------------------------------------------------------------------------
>
> Key: HDFS-2705
> URL: https://issues.apache.org/jira/browse/HDFS-2705
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 0.24.0, 0.23.1
> Reporter: Alejandro Abdelnur
> Assignee: Alejandro Abdelnur
> Fix For: 0.24.0, 0.23.1
>
>
> The append/create requests should require 'application/octet-stream' as content-type when uploading data. This is to prevent the default content-type form-encoded (used as default by some HTTP libraries) to be used or text based content-types to be used.
> If the form-encoded content type is used, then Jersey tries to process the upload stream as parameters
> If a test base content-type is used, HTTP proxies/gateways could do attempt some transcoding on the stream thus corrupting the data.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2705) HttpFS server should check that
upload requests have correct content-type
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13174067#comment-13174067 ]
Hudson commented on HDFS-2705:
------------------------------
Integrated in Hadoop-Hdfs-0.23-Build #114 (See [https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/114/])
Merge -r 1221615:1221616 from trunk to branch. FIXES: HDFS-2705
tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1221619
Files :
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs-httpfs/src/main/java/org/apache/hadoop/fs/http/client/HttpFSFileSystem.java
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs-httpfs/src/main/java/org/apache/hadoop/fs/http/server/CheckUploadContentTypeFilter.java
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs-httpfs/src/main/webapp/WEB-INF/web.xml
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs-httpfs/src/test/java/org/apache/hadoop/fs/http/server/TestCheckUploadContentTypeFilter.java
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
> HttpFS server should check that upload requests have correct content-type
> -------------------------------------------------------------------------
>
> Key: HDFS-2705
> URL: https://issues.apache.org/jira/browse/HDFS-2705
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 0.24.0, 0.23.1
> Reporter: Alejandro Abdelnur
> Assignee: Alejandro Abdelnur
> Fix For: 0.24.0, 0.23.1
>
> Attachments: HDFS-2705.patch, HDFS-2705.patch, HDFS-2705.patch
>
>
> The append/create requests should require 'application/octet-stream' as content-type when uploading data. This is to prevent the default content-type form-encoded (used as default by some HTTP libraries) to be used or text based content-types to be used.
> If the form-encoded content type is used, then Jersey tries to process the upload stream as parameters
> If a test base content-type is used, HTTP proxies/gateways could do attempt some transcoding on the stream thus corrupting the data.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-2705) HttpFS server should check that upload
requests have correct content-type
Posted by "Alejandro Abdelnur (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alejandro Abdelnur updated HDFS-2705:
-------------------------------------
Fix Version/s: (was: 0.24.0)
> HttpFS server should check that upload requests have correct content-type
> -------------------------------------------------------------------------
>
> Key: HDFS-2705
> URL: https://issues.apache.org/jira/browse/HDFS-2705
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 0.24.0, 0.23.1
> Reporter: Alejandro Abdelnur
> Assignee: Alejandro Abdelnur
> Fix For: 0.23.1
>
> Attachments: HDFS-2705.patch, HDFS-2705.patch, HDFS-2705.patch
>
>
> The append/create requests should require 'application/octet-stream' as content-type when uploading data. This is to prevent the default content-type form-encoded (used as default by some HTTP libraries) to be used or text based content-types to be used.
> If the form-encoded content type is used, then Jersey tries to process the upload stream as parameters
> If a test base content-type is used, HTTP proxies/gateways could do attempt some transcoding on the stream thus corrupting the data.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2705) HttpFS server should check that
upload requests have correct content-type
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13173884#comment-13173884 ]
Hudson commented on HDFS-2705:
------------------------------
Integrated in Hadoop-Hdfs-0.23-Commit #305 (See [https://builds.apache.org/job/Hadoop-Hdfs-0.23-Commit/305/])
Merge -r 1221615:1221616 from trunk to branch. FIXES: HDFS-2705
tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1221619
Files :
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs-httpfs/src/main/java/org/apache/hadoop/fs/http/client/HttpFSFileSystem.java
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs-httpfs/src/main/java/org/apache/hadoop/fs/http/server/CheckUploadContentTypeFilter.java
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs-httpfs/src/main/webapp/WEB-INF/web.xml
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs-httpfs/src/test/java/org/apache/hadoop/fs/http/server/TestCheckUploadContentTypeFilter.java
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
> HttpFS server should check that upload requests have correct content-type
> -------------------------------------------------------------------------
>
> Key: HDFS-2705
> URL: https://issues.apache.org/jira/browse/HDFS-2705
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 0.24.0, 0.23.1
> Reporter: Alejandro Abdelnur
> Assignee: Alejandro Abdelnur
> Fix For: 0.24.0, 0.23.1
>
> Attachments: HDFS-2705.patch, HDFS-2705.patch, HDFS-2705.patch
>
>
> The append/create requests should require 'application/octet-stream' as content-type when uploading data. This is to prevent the default content-type form-encoded (used as default by some HTTP libraries) to be used or text based content-types to be used.
> If the form-encoded content type is used, then Jersey tries to process the upload stream as parameters
> If a test base content-type is used, HTTP proxies/gateways could do attempt some transcoding on the stream thus corrupting the data.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2705) HttpFS server should check that
upload requests have correct content-type
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13173911#comment-13173911 ]
Hudson commented on HDFS-2705:
------------------------------
Integrated in Hadoop-Mapreduce-0.23-Commit #327 (See [https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Commit/327/])
Merge -r 1221615:1221616 from trunk to branch. FIXES: HDFS-2705
tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1221619
Files :
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs-httpfs/src/main/java/org/apache/hadoop/fs/http/client/HttpFSFileSystem.java
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs-httpfs/src/main/java/org/apache/hadoop/fs/http/server/CheckUploadContentTypeFilter.java
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs-httpfs/src/main/webapp/WEB-INF/web.xml
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs-httpfs/src/test/java/org/apache/hadoop/fs/http/server/TestCheckUploadContentTypeFilter.java
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
> HttpFS server should check that upload requests have correct content-type
> -------------------------------------------------------------------------
>
> Key: HDFS-2705
> URL: https://issues.apache.org/jira/browse/HDFS-2705
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 0.24.0, 0.23.1
> Reporter: Alejandro Abdelnur
> Assignee: Alejandro Abdelnur
> Fix For: 0.24.0, 0.23.1
>
> Attachments: HDFS-2705.patch, HDFS-2705.patch, HDFS-2705.patch
>
>
> The append/create requests should require 'application/octet-stream' as content-type when uploading data. This is to prevent the default content-type form-encoded (used as default by some HTTP libraries) to be used or text based content-types to be used.
> If the form-encoded content type is used, then Jersey tries to process the upload stream as parameters
> If a test base content-type is used, HTTP proxies/gateways could do attempt some transcoding on the stream thus corrupting the data.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2705) HttpFS server should check that
upload requests have correct content-type
Posted by "Eli Collins (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13173760#comment-13173760 ]
Eli Collins commented on HDFS-2705:
-----------------------------------
+1 looks great
> HttpFS server should check that upload requests have correct content-type
> -------------------------------------------------------------------------
>
> Key: HDFS-2705
> URL: https://issues.apache.org/jira/browse/HDFS-2705
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 0.24.0, 0.23.1
> Reporter: Alejandro Abdelnur
> Assignee: Alejandro Abdelnur
> Fix For: 0.24.0, 0.23.1
>
> Attachments: HDFS-2705.patch, HDFS-2705.patch, HDFS-2705.patch
>
>
> The append/create requests should require 'application/octet-stream' as content-type when uploading data. This is to prevent the default content-type form-encoded (used as default by some HTTP libraries) to be used or text based content-types to be used.
> If the form-encoded content type is used, then Jersey tries to process the upload stream as parameters
> If a test base content-type is used, HTTP proxies/gateways could do attempt some transcoding on the stream thus corrupting the data.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-2705) HttpFS server should check that upload
requests have correct content-type
Posted by "Alejandro Abdelnur (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alejandro Abdelnur updated HDFS-2705:
-------------------------------------
Status: Patch Available (was: Open)
> HttpFS server should check that upload requests have correct content-type
> -------------------------------------------------------------------------
>
> Key: HDFS-2705
> URL: https://issues.apache.org/jira/browse/HDFS-2705
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 0.24.0, 0.23.1
> Reporter: Alejandro Abdelnur
> Assignee: Alejandro Abdelnur
> Fix For: 0.24.0, 0.23.1
>
> Attachments: HDFS-2705.patch
>
>
> The append/create requests should require 'application/octet-stream' as content-type when uploading data. This is to prevent the default content-type form-encoded (used as default by some HTTP libraries) to be used or text based content-types to be used.
> If the form-encoded content type is used, then Jersey tries to process the upload stream as parameters
> If a test base content-type is used, HTTP proxies/gateways could do attempt some transcoding on the stream thus corrupting the data.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2705) HttpFS server should check that
upload requests have correct content-type
Posted by "Uma Maheswara Rao G (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13174090#comment-13174090 ]
Uma Maheswara Rao G commented on HDFS-2705:
-------------------------------------------
Looks JIRA id missed in trunk CHANGES.txt :-)
{quote}
HDFS-2657. TestHttpFSServer and TestServerWebApp are failing on trunk.
(tucu)
HttpFS server should check that upload requests have correct
content-type. (tucu)
Release 0.23.1 - UNRELEASED{quote}
> HttpFS server should check that upload requests have correct content-type
> -------------------------------------------------------------------------
>
> Key: HDFS-2705
> URL: https://issues.apache.org/jira/browse/HDFS-2705
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 0.24.0, 0.23.1
> Reporter: Alejandro Abdelnur
> Assignee: Alejandro Abdelnur
> Fix For: 0.24.0, 0.23.1
>
> Attachments: HDFS-2705.patch, HDFS-2705.patch, HDFS-2705.patch
>
>
> The append/create requests should require 'application/octet-stream' as content-type when uploading data. This is to prevent the default content-type form-encoded (used as default by some HTTP libraries) to be used or text based content-types to be used.
> If the form-encoded content type is used, then Jersey tries to process the upload stream as parameters
> If a test base content-type is used, HTTP proxies/gateways could do attempt some transcoding on the stream thus corrupting the data.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-2705) HttpFS server should check that upload
requests have correct content-type
Posted by "Alejandro Abdelnur (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alejandro Abdelnur updated HDFS-2705:
-------------------------------------
Attachment: (was: HDFS-2705.patch)
> HttpFS server should check that upload requests have correct content-type
> -------------------------------------------------------------------------
>
> Key: HDFS-2705
> URL: https://issues.apache.org/jira/browse/HDFS-2705
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 0.24.0, 0.23.1
> Reporter: Alejandro Abdelnur
> Assignee: Alejandro Abdelnur
> Fix For: 0.24.0, 0.23.1
>
>
> The append/create requests should require 'application/octet-stream' as content-type when uploading data. This is to prevent the default content-type form-encoded (used as default by some HTTP libraries) to be used or text based content-types to be used.
> If the form-encoded content type is used, then Jersey tries to process the upload stream as parameters
> If a test base content-type is used, HTTP proxies/gateways could do attempt some transcoding on the stream thus corrupting the data.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-2705) HttpFS server should check that upload
requests have correct content-type
Posted by "Alejandro Abdelnur (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alejandro Abdelnur updated HDFS-2705:
-------------------------------------
Resolution: Fixed
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
thanks Eli.
Committed to trunk & branch-0.23
> HttpFS server should check that upload requests have correct content-type
> -------------------------------------------------------------------------
>
> Key: HDFS-2705
> URL: https://issues.apache.org/jira/browse/HDFS-2705
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 0.24.0, 0.23.1
> Reporter: Alejandro Abdelnur
> Assignee: Alejandro Abdelnur
> Fix For: 0.24.0, 0.23.1
>
> Attachments: HDFS-2705.patch, HDFS-2705.patch, HDFS-2705.patch
>
>
> The append/create requests should require 'application/octet-stream' as content-type when uploading data. This is to prevent the default content-type form-encoded (used as default by some HTTP libraries) to be used or text based content-types to be used.
> If the form-encoded content type is used, then Jersey tries to process the upload stream as parameters
> If a test base content-type is used, HTTP proxies/gateways could do attempt some transcoding on the stream thus corrupting the data.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2705) HttpFS server should check that
upload requests have correct content-type
Posted by "Alejandro Abdelnur (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13172934#comment-13172934 ]
Alejandro Abdelnur commented on HDFS-2705:
------------------------------------------
test failures are not related.
4 findbugs are addressed by HDFS-2646, one not related.
the javadoc warnings are not related (the 2 related have been addressed by HDFS-2658)
> HttpFS server should check that upload requests have correct content-type
> -------------------------------------------------------------------------
>
> Key: HDFS-2705
> URL: https://issues.apache.org/jira/browse/HDFS-2705
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 0.24.0, 0.23.1
> Reporter: Alejandro Abdelnur
> Assignee: Alejandro Abdelnur
> Fix For: 0.24.0, 0.23.1
>
> Attachments: HDFS-2705.patch, HDFS-2705.patch, HDFS-2705.patch
>
>
> The append/create requests should require 'application/octet-stream' as content-type when uploading data. This is to prevent the default content-type form-encoded (used as default by some HTTP libraries) to be used or text based content-types to be used.
> If the form-encoded content type is used, then Jersey tries to process the upload stream as parameters
> If a test base content-type is used, HTTP proxies/gateways could do attempt some transcoding on the stream thus corrupting the data.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2705) HttpFS server should check that
upload requests have correct content-type
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13172554#comment-13172554 ]
Hadoop QA commented on HDFS-2705:
---------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12507949/HDFS-2705.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 2 new or modified tests.
-1 javadoc. The javadoc tool appears to have generated 20 warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
-1 findbugs. The patch appears to cause Findbugs (version 1.3.9) to fail.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hdfs.TestFileAppend2
org.apache.hadoop.hdfs.TestDatanodeDeath
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/1726//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1726//console
This message is automatically generated.
> HttpFS server should check that upload requests have correct content-type
> -------------------------------------------------------------------------
>
> Key: HDFS-2705
> URL: https://issues.apache.org/jira/browse/HDFS-2705
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 0.24.0, 0.23.1
> Reporter: Alejandro Abdelnur
> Assignee: Alejandro Abdelnur
> Fix For: 0.24.0, 0.23.1
>
> Attachments: HDFS-2705.patch, HDFS-2705.patch
>
>
> The append/create requests should require 'application/octet-stream' as content-type when uploading data. This is to prevent the default content-type form-encoded (used as default by some HTTP libraries) to be used or text based content-types to be used.
> If the form-encoded content type is used, then Jersey tries to process the upload stream as parameters
> If a test base content-type is used, HTTP proxies/gateways could do attempt some transcoding on the stream thus corrupting the data.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2705) HttpFS server should check that
upload requests have correct content-type
Posted by "Eli Collins (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13173761#comment-13173761 ]
Eli Collins commented on HDFS-2705:
-----------------------------------
+1 looks great
> HttpFS server should check that upload requests have correct content-type
> -------------------------------------------------------------------------
>
> Key: HDFS-2705
> URL: https://issues.apache.org/jira/browse/HDFS-2705
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 0.24.0, 0.23.1
> Reporter: Alejandro Abdelnur
> Assignee: Alejandro Abdelnur
> Fix For: 0.24.0, 0.23.1
>
> Attachments: HDFS-2705.patch, HDFS-2705.patch, HDFS-2705.patch
>
>
> The append/create requests should require 'application/octet-stream' as content-type when uploading data. This is to prevent the default content-type form-encoded (used as default by some HTTP libraries) to be used or text based content-types to be used.
> If the form-encoded content type is used, then Jersey tries to process the upload stream as parameters
> If a test base content-type is used, HTTP proxies/gateways could do attempt some transcoding on the stream thus corrupting the data.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2705) HttpFS server should check that
upload requests have correct content-type
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13174083#comment-13174083 ]
Hudson commented on HDFS-2705:
------------------------------
Integrated in Hadoop-Mapreduce-0.23-Build #135 (See [https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Build/135/])
Merge -r 1221615:1221616 from trunk to branch. FIXES: HDFS-2705
tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1221619
Files :
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs-httpfs/src/main/java/org/apache/hadoop/fs/http/client/HttpFSFileSystem.java
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs-httpfs/src/main/java/org/apache/hadoop/fs/http/server/CheckUploadContentTypeFilter.java
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs-httpfs/src/main/webapp/WEB-INF/web.xml
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs-httpfs/src/test/java/org/apache/hadoop/fs/http/server/TestCheckUploadContentTypeFilter.java
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
> HttpFS server should check that upload requests have correct content-type
> -------------------------------------------------------------------------
>
> Key: HDFS-2705
> URL: https://issues.apache.org/jira/browse/HDFS-2705
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 0.24.0, 0.23.1
> Reporter: Alejandro Abdelnur
> Assignee: Alejandro Abdelnur
> Fix For: 0.24.0, 0.23.1
>
> Attachments: HDFS-2705.patch, HDFS-2705.patch, HDFS-2705.patch
>
>
> The append/create requests should require 'application/octet-stream' as content-type when uploading data. This is to prevent the default content-type form-encoded (used as default by some HTTP libraries) to be used or text based content-types to be used.
> If the form-encoded content type is used, then Jersey tries to process the upload stream as parameters
> If a test base content-type is used, HTTP proxies/gateways could do attempt some transcoding on the stream thus corrupting the data.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2705) HttpFS server should check that
upload requests have correct content-type
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13172874#comment-13172874 ]
Hadoop QA commented on HDFS-2705:
---------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12508017/HDFS-2705.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 2 new or modified tests.
-1 javadoc. The javadoc tool appears to have generated 20 warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
-1 findbugs. The patch appears to introduce 5 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hdfs.TestFileAppend2
org.apache.hadoop.hdfs.TestDatanodeDeath
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/1728//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/1728//artifact/trunk/hadoop-hdfs-project/patchprocess/newPatchFindbugsWarningshadoop-hdfs-httpfs.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/1728//artifact/trunk/hadoop-hdfs-project/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1728//console
This message is automatically generated.
> HttpFS server should check that upload requests have correct content-type
> -------------------------------------------------------------------------
>
> Key: HDFS-2705
> URL: https://issues.apache.org/jira/browse/HDFS-2705
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 0.24.0, 0.23.1
> Reporter: Alejandro Abdelnur
> Assignee: Alejandro Abdelnur
> Fix For: 0.24.0, 0.23.1
>
> Attachments: HDFS-2705.patch, HDFS-2705.patch, HDFS-2705.patch
>
>
> The append/create requests should require 'application/octet-stream' as content-type when uploading data. This is to prevent the default content-type form-encoded (used as default by some HTTP libraries) to be used or text based content-types to be used.
> If the form-encoded content type is used, then Jersey tries to process the upload stream as parameters
> If a test base content-type is used, HTTP proxies/gateways could do attempt some transcoding on the stream thus corrupting the data.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-2705) HttpFS server should check that upload
requests have correct content-type
Posted by "Alejandro Abdelnur (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alejandro Abdelnur updated HDFS-2705:
-------------------------------------
Attachment: HDFS-2705.patch
amended patch with AL header in the new testcase
> HttpFS server should check that upload requests have correct content-type
> -------------------------------------------------------------------------
>
> Key: HDFS-2705
> URL: https://issues.apache.org/jira/browse/HDFS-2705
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 0.24.0, 0.23.1
> Reporter: Alejandro Abdelnur
> Assignee: Alejandro Abdelnur
> Fix For: 0.24.0, 0.23.1
>
> Attachments: HDFS-2705.patch, HDFS-2705.patch
>
>
> The append/create requests should require 'application/octet-stream' as content-type when uploading data. This is to prevent the default content-type form-encoded (used as default by some HTTP libraries) to be used or text based content-types to be used.
> If the form-encoded content type is used, then Jersey tries to process the upload stream as parameters
> If a test base content-type is used, HTTP proxies/gateways could do attempt some transcoding on the stream thus corrupting the data.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2705) HttpFS server should check that
upload requests have correct content-type
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13173887#comment-13173887 ]
Hudson commented on HDFS-2705:
------------------------------
Integrated in Hadoop-Common-0.23-Commit #316 (See [https://builds.apache.org/job/Hadoop-Common-0.23-Commit/316/])
Merge -r 1221615:1221616 from trunk to branch. FIXES: HDFS-2705
tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1221619
Files :
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs-httpfs/src/main/java/org/apache/hadoop/fs/http/client/HttpFSFileSystem.java
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs-httpfs/src/main/java/org/apache/hadoop/fs/http/server/CheckUploadContentTypeFilter.java
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs-httpfs/src/main/webapp/WEB-INF/web.xml
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs-httpfs/src/test/java/org/apache/hadoop/fs/http/server/TestCheckUploadContentTypeFilter.java
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
> HttpFS server should check that upload requests have correct content-type
> -------------------------------------------------------------------------
>
> Key: HDFS-2705
> URL: https://issues.apache.org/jira/browse/HDFS-2705
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 0.24.0, 0.23.1
> Reporter: Alejandro Abdelnur
> Assignee: Alejandro Abdelnur
> Fix For: 0.24.0, 0.23.1
>
> Attachments: HDFS-2705.patch, HDFS-2705.patch, HDFS-2705.patch
>
>
> The append/create requests should require 'application/octet-stream' as content-type when uploading data. This is to prevent the default content-type form-encoded (used as default by some HTTP libraries) to be used or text based content-types to be used.
> If the form-encoded content type is used, then Jersey tries to process the upload stream as parameters
> If a test base content-type is used, HTTP proxies/gateways could do attempt some transcoding on the stream thus corrupting the data.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-2705) HttpFS server should check that upload
requests have correct content-type
Posted by "Alejandro Abdelnur (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alejandro Abdelnur updated HDFS-2705:
-------------------------------------
Attachment: HDFS-2705.patch
> HttpFS server should check that upload requests have correct content-type
> -------------------------------------------------------------------------
>
> Key: HDFS-2705
> URL: https://issues.apache.org/jira/browse/HDFS-2705
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 0.24.0, 0.23.1
> Reporter: Alejandro Abdelnur
> Assignee: Alejandro Abdelnur
> Fix For: 0.24.0, 0.23.1
>
> Attachments: HDFS-2705.patch
>
>
> The append/create requests should require 'application/octet-stream' as content-type when uploading data. This is to prevent the default content-type form-encoded (used as default by some HTTP libraries) to be used or text based content-types to be used.
> If the form-encoded content type is used, then Jersey tries to process the upload stream as parameters
> If a test base content-type is used, HTTP proxies/gateways could do attempt some transcoding on the stream thus corrupting the data.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-2705) HttpFS server should check that upload
requests have correct content-type
Posted by "Alejandro Abdelnur (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alejandro Abdelnur updated HDFS-2705:
-------------------------------------
Attachment: HDFS-2705.patch
Minor correction in patch to cover the case there is no op parameter
> HttpFS server should check that upload requests have correct content-type
> -------------------------------------------------------------------------
>
> Key: HDFS-2705
> URL: https://issues.apache.org/jira/browse/HDFS-2705
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 0.24.0, 0.23.1
> Reporter: Alejandro Abdelnur
> Assignee: Alejandro Abdelnur
> Fix For: 0.24.0, 0.23.1
>
> Attachments: HDFS-2705.patch, HDFS-2705.patch, HDFS-2705.patch
>
>
> The append/create requests should require 'application/octet-stream' as content-type when uploading data. This is to prevent the default content-type form-encoded (used as default by some HTTP libraries) to be used or text based content-types to be used.
> If the form-encoded content type is used, then Jersey tries to process the upload stream as parameters
> If a test base content-type is used, HTTP proxies/gateways could do attempt some transcoding on the stream thus corrupting the data.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira