You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "greyp9 (via GitHub)" <gi...@apache.org> on 2023/05/16 22:00:03 UTC
[GitHub] [nifi] greyp9 opened a new pull request, #7255: NIFI-11553 - additional configurability for GCP processors
greyp9 opened a new pull request, #7255:
URL: https://github.com/apache/nifi/pull/7255
# Summary
[NIFI-11553](https://issues.apache.org/jira/browse/NIFI-11553)
# Tracking
Please complete the following tracking steps prior to pull request creation.
### Issue Tracking
- [x] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created
### Pull Request Tracking
- [x] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000`
- [x] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000`
### Pull Request Formatting
- [x] Pull Request based on current revision of the `main` branch
- [x] Pull Request refers to a feature branch with one commit containing changes
# Verification
Please indicate the verification steps performed prior to pull request creation.
### Build
- [x] Build completed using `mvn clean install -P contrib-check`
- [x] JDK 11
- [x] JDK 17
### Licensing
- [x] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)
- [x] New dependencies are documented in applicable `LICENSE` and `NOTICE` files
### Documentation
- [x] Documentation formatting appears as expected in rendered files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] greyp9 commented on a diff in pull request #7255: NIFI-11553 - additional configurability for GCP processors
Posted by "greyp9 (via GitHub)" <gi...@apache.org>.
greyp9 commented on code in PR #7255:
URL: https://github.com/apache/nifi/pull/7255#discussion_r1195727879
##########
nifi-nar-bundles/nifi-gcp-bundle/nifi-gcp-processors/src/main/java/org/apache/nifi/processors/gcp/pubsub/AbstractGCPubSubProcessor.java:
##########
@@ -36,16 +37,47 @@
public abstract class AbstractGCPubSubProcessor extends AbstractGCPProcessor implements VerifiableProcessor {
- public static final PropertyDescriptor BATCH_SIZE = new PropertyDescriptor.Builder()
+ public static final PropertyDescriptor BATCH_SIZE_THRESHOLD = new PropertyDescriptor.Builder()
Review Comment:
This rename in order to align with sibling descriptors. The descriptor name stays the same, so should be no backward compat issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] greyp9 commented on a diff in pull request #7255: NIFI-11553 - additional configurability for GCP processors
Posted by "greyp9 (via GitHub)" <gi...@apache.org>.
greyp9 commented on code in PR #7255:
URL: https://github.com/apache/nifi/pull/7255#discussion_r1195728445
##########
nifi-nar-bundles/nifi-gcp-bundle/nifi-gcp-processors/src/main/java/org/apache/nifi/processors/gcp/pubsub/lite/PublishGCPubSubLite.java:
##########
@@ -112,26 +112,16 @@ public class PublishGCPubSubLite extends AbstractGCPubSubProcessor implements Ve
.addValidator(StandardValidators.NON_BLANK_VALIDATOR)
.build();
- public static final PropertyDescriptor BATCH_BYTES = new PropertyDescriptor
Review Comment:
This descriptor hoisted up to super class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] greyp9 commented on a diff in pull request #7255: NIFI-11553 - additional configurability for GCP processors
Posted by "greyp9 (via GitHub)" <gi...@apache.org>.
greyp9 commented on code in PR #7255:
URL: https://github.com/apache/nifi/pull/7255#discussion_r1195729117
##########
nifi-nar-bundles/nifi-gcp-bundle/nifi-gcp-processors/src/main/java/org/apache/nifi/processors/gcp/pubsub/lite/PublishGCPubSubLite.java:
##########
@@ -290,9 +280,9 @@ private Publisher getPublisher(final ProcessContext context) {
.setTopicPath(topicPath)
Review Comment:
The "Lite" API does not offer override of endpoint.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] greyp9 commented on pull request #7255: NIFI-11553 - additional configurability for GCP processors
Posted by "greyp9 (via GitHub)" <gi...@apache.org>.
greyp9 commented on PR #7255:
URL: https://github.com/apache/nifi/pull/7255#issuecomment-1552133431
Closing this PR, and altering the scope of the JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] greyp9 closed pull request #7255: NIFI-11553 - additional configurability for GCP processors
Posted by "greyp9 (via GitHub)" <gi...@apache.org>.
greyp9 closed pull request #7255: NIFI-11553 - additional configurability for GCP processors
URL: https://github.com/apache/nifi/pull/7255
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org