[GitHub] incubator-apex-core pull request: APEX-92 Fixing Configuration of ...

[gauravgopi123 <gi...@git.apache.org>]

Github user gauravgopi123 commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-core/pull/98#discussion_r43978974
  
    --- Diff: engine/src/main/java/com/datatorrent/stram/StreamingAppMasterService.java ---
    @@ -647,8 +645,8 @@ private void execute() throws YarnException, IOException
         int minVcores = conf.getInt("yarn.scheduler.minimum-allocation-vcores", 0);
         LOG.info("Max mem {}m, Min mem {}m, Max vcores {} and Min vcores {} capabililty of resources in this cluster ", maxMem, minMem, maxVcores, minVcores);
     
    -    int maxConsecutiveContainerFailures = conf.getInt("MAX_CONSECUTIVE_CONTAINER_FAILURES", MAX_CONTAINER_FAILURES_PER_NODE);
    -    long blacklistRemovalTime = conf.getLong("BLACKLIST_REMOVAL_TIME", BLACKLIST_REMOVAL_TIME);
    +    int maxConsecutiveContainerFailures = dag.getValue(LogicalPlan.MAX_CONSECUTIVE_CONTAINER_FAILURES);
    --- End diff --
    
    @tweise did you mean how was this tested on cluster by making sure that containers failed on a node for those many times?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---