You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/05/03 20:45:43 UTC
[GitHub] [arrow] pachamaltese opened a new pull request #10232: remove jpype
pachamaltese opened a new pull request #10232:
URL: https://github.com/apache/arrow/pull/10232
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pachamaltese commented on pull request #10232: ARROW-11146: [CI] Remove test-conda-python-3.8-jpype build
Posted by GitBox <gi...@apache.org>.
pachamaltese commented on pull request #10232:
URL: https://github.com/apache/arrow/pull/10232#issuecomment-831577715
ready :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pachamaltese commented on pull request #10232: ARROW-11146: [CI] Remove test-conda-python-3.8-jpype build
Posted by GitBox <gi...@apache.org>.
pachamaltese commented on pull request #10232:
URL: https://github.com/apache/arrow/pull/10232#issuecomment-831584996
I did a rebase and then a push and it went well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jonkeane commented on pull request #10232: ARROW-11146: [CI] Remove test-conda-python-3.8-jpype build
Posted by GitBox <gi...@apache.org>.
jonkeane commented on pull request #10232:
URL: https://github.com/apache/arrow/pull/10232#issuecomment-831579037
I'm still seeing a bunch of commits that seem unrelated to this change — how did you go about squashing or rebasing so that you don't have that unrelated history in this branch?
Additionally: Dig more into the failure that you noted. What failed? Does it make sense that these changes are touching that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pachamaltese commented on pull request #10232: ARROW-11146: [CI] Remove test-conda-python-3.8-jpype build
Posted by GitBox <gi...@apache.org>.
pachamaltese commented on pull request #10232:
URL: https://github.com/apache/arrow/pull/10232#issuecomment-831584780
hmm... i'm not so sure
here I see 1 file changed https://github.com/apache/arrow/pull/10232/files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #10232: ARROW-11146: [CI] Remove test-conda-python-3.8-jpype build
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10232:
URL: https://github.com/apache/arrow/pull/10232#issuecomment-831576855
https://issues.apache.org/jira/browse/ARROW-11146
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pachamaltese commented on pull request #10232: ARROW-11146: [CI] Remove test-conda-python-3.8-jpype build
Posted by GitBox <gi...@apache.org>.
pachamaltese commented on pull request #10232:
URL: https://github.com/apache/arrow/pull/10232#issuecomment-831587268
i'll open a new pr... it's better i think
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #10232: remove jpype
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10232:
URL: https://github.com/apache/arrow/pull/10232#issuecomment-831522809
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for opening a pull request!
If this is not a [minor PR](https://github.com/apache/arrow/blob/master/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW
Opening JIRAs ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
Then could you also rename pull request title in the following format?
ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
See also:
* [Other pull requests](https://github.com/apache/arrow/pulls/)
* [Contribution Guidelines - How to contribute patches](https://arrow.apache.org/docs/developers/contributing.html#how-to-contribute-patches)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pachamaltese commented on pull request #10232: ARROW-11146: [CI] Remove test-conda-python-3.8-jpype build
Posted by GitBox <gi...@apache.org>.
pachamaltese commented on pull request #10232:
URL: https://github.com/apache/arrow/pull/10232#issuecomment-831600381
moved to https://github.com/apache/arrow/pull/10238
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pachamaltese closed pull request #10232: ARROW-11146: [CI] Remove test-conda-python-3.8-jpype build
Posted by GitBox <gi...@apache.org>.
pachamaltese closed pull request #10232:
URL: https://github.com/apache/arrow/pull/10232
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pachamaltese commented on pull request #10232: [CI] Remove test-conda-python-3.8-jpype build
Posted by GitBox <gi...@apache.org>.
pachamaltese commented on pull request #10232:
URL: https://github.com/apache/arrow/pull/10232#issuecomment-831573973
> The changes to tasks.yml looks good, however a few notes:
>
> * Could you rebase/squash your commits here so that we don't have all of that extraneous history? It should be fine when we squash + merge it, but we want to make sure we're being clean with this and it's not touching other things accidentally / unnecessarily
>
> * Dig more into the failure that you noted. What failed? Does it make sense that these changes are touching that?
>
> * Could you update the format of the PR to match our style (pick either of the two tickets we have for this to use as the ticket number + mark the other as a duplicate)
sure !!
no problem, I'll do that now and push again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jonkeane commented on pull request #10232: [CI] Remove test-conda-python-3.8-jpype build
Posted by GitBox <gi...@apache.org>.
jonkeane commented on pull request #10232:
URL: https://github.com/apache/arrow/pull/10232#issuecomment-831565905
The changes to tasks.yml looks good, however a few notes:
* Could you rebase/squash your commits here so that we don't have all of that extraneous history? It should be fine when we squash + merge it, but we want to make sure we're being clean with this and it's not touching other things accidentally / unnecessarily
* Dig more into the failure that you noted. What failed? Does it make sense that these changes are touching that?
* Could you update the format of the PR to match our style (pick either of the two tickets we have for this to use as the ticket number + mark the other as a duplicate)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org