[GitHub] [lucene-solr] epugh commented on a change in pull request #1033: SOLR-13965: Use Plugin to add new expressions to GraphHandler

[GitBox <gi...@apache.org>]

epugh commented on a change in pull request #1033: SOLR-13965: Use Plugin to add new expressions to GraphHandler
URL: https://github.com/apache/lucene-solr/pull/1033#discussion_r356635101
 
 

 ##########
 File path: solr/core/src/java/org/apache/solr/handler/GraphHandler.java
 ##########
 @@ -87,14 +88,10 @@ public void inform(SolrCore core) {
     }
 
     // This pulls all the overrides and additions from the config
-    Object functionMappingsObj = initArgs.get("streamFunctions");
 
 Review comment:
   I wondered the same thing.   I don't think anyone actually customizes this handler, but that is just a guess.   I can add a deprecated warning, do you have a good example that I could copy of how we normally do that?  

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org