You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/08/23 20:03:54 UTC
[GitHub] [spark] MaxGekk opened a new pull request #33816: [WIP][SPARK-36567][SQL] Support foldable special datetime strings by `CAST`
MaxGekk opened a new pull request #33816:
URL: https://github.com/apache/spark/pull/33816
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #33816: [SPARK-36567][SQL] Support foldable special datetime strings by `CAST`
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on pull request #33816:
URL: https://github.com/apache/spark/pull/33816#issuecomment-905852735
Here is the update for the SQL migration guide https://github.com/apache/spark/pull/33840
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #33816: [SPARK-36567][SQL] Support foldable special datetime strings by `CAST`
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #33816:
URL: https://github.com/apache/spark/pull/33816#issuecomment-905213362
@MaxGekk I think we should also update the migration guide?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33816: [WIP][SPARK-36567][SQL] Support foldable special datetime strings by `CAST`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33816:
URL: https://github.com/apache/spark/pull/33816#issuecomment-904154316
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47209/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33816: [WIP][SPARK-36567][SQL] Support foldable special datetime strings by `CAST`
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33816:
URL: https://github.com/apache/spark/pull/33816#issuecomment-904144921
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47209/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33816: [WIP][SPARK-36567][SQL] Support foldable special datetime strings by `CAST`
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33816:
URL: https://github.com/apache/spark/pull/33816#issuecomment-904082662
**[Test build #142708 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142708/testReport)** for PR 33816 at commit [`16371f7`](https://github.com/apache/spark/commit/16371f7a42947d73360245d269f803613031742e).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33816: [WIP][SPARK-36567][SQL] Support foldable special datetime strings by `CAST`
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33816:
URL: https://github.com/apache/spark/pull/33816#issuecomment-904880825
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47241/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33816: [WIP][SPARK-36567][SQL] Support foldable special datetime strings by `CAST`
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33816:
URL: https://github.com/apache/spark/pull/33816#issuecomment-904177482
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47210/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33816: [SPARK-36567][SQL] Support foldable special datetime strings by `CAST`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33816:
URL: https://github.com/apache/spark/pull/33816#issuecomment-904925546
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47241/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #33816: [WIP][SPARK-36567][SQL] Support foldable special datetime strings by `CAST`
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #33816:
URL: https://github.com/apache/spark/pull/33816#discussion_r694445672
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/finishAnalysis.scala
##########
@@ -119,3 +120,25 @@ case class ReplaceCurrentLike(catalogManager: CatalogManager) extends Rule[Logic
}
}
}
+
+/**
+ * Replaces casts of special datetime strings by its date/timestamp values
+ * if the input strings are foldable.
Review comment:
Should this be placed under constant folding? cc @cloud-fan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #33816: [WIP][SPARK-36567][SQL] Support foldable special datetime strings by `CAST`
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #33816:
URL: https://github.com/apache/spark/pull/33816#issuecomment-904154609
**[Test build #142709 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142709/testReport)** for PR 33816 at commit [`59933d2`](https://github.com/apache/spark/commit/59933d2995de7ac866081ce5515a58369d55a800).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33816: [WIP][SPARK-36567][SQL] Support foldable special datetime strings by `CAST`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33816:
URL: https://github.com/apache/spark/pull/33816#issuecomment-904112816
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142708/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33816: [WIP][SPARK-36567][SQL] Support foldable special datetime strings by `CAST`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33816:
URL: https://github.com/apache/spark/pull/33816#issuecomment-904277615
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142709/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33816: [WIP][SPARK-36567][SQL] Support foldable special datetime strings by `CAST`
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33816:
URL: https://github.com/apache/spark/pull/33816#issuecomment-904199863
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47210/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33816: [WIP][SPARK-36567][SQL] Support foldable special datetime strings by `CAST`
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33816:
URL: https://github.com/apache/spark/pull/33816#issuecomment-904120813
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47209/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33816: [WIP][SPARK-36567][SQL] Support foldable special datetime strings by `CAST`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33816:
URL: https://github.com/apache/spark/pull/33816#issuecomment-904112816
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142708/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33816: [SPARK-36567][SQL] Support foldable special datetime strings by `CAST`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33816:
URL: https://github.com/apache/spark/pull/33816#issuecomment-904925546
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47241/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33816: [SPARK-36567][SQL] Support foldable special datetime strings by `CAST`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33816:
URL: https://github.com/apache/spark/pull/33816#issuecomment-905025922
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142741/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33816: [SPARK-36567][SQL] Support foldable special datetime strings by `CAST`
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33816:
URL: https://github.com/apache/spark/pull/33816#issuecomment-904916276
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47241/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33816: [WIP][SPARK-36567][SQL] Support foldable special datetime strings by `CAST`
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33816:
URL: https://github.com/apache/spark/pull/33816#issuecomment-904154609
**[Test build #142709 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142709/testReport)** for PR 33816 at commit [`59933d2`](https://github.com/apache/spark/commit/59933d2995de7ac866081ce5515a58369d55a800).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33816: [WIP][SPARK-36567][SQL] Support foldable special datetime strings by `CAST`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33816:
URL: https://github.com/apache/spark/pull/33816#issuecomment-904209446
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47210/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33816: [WIP][SPARK-36567][SQL] Support foldable special datetime strings by `CAST`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33816:
URL: https://github.com/apache/spark/pull/33816#issuecomment-904154316
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47209/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a change in pull request #33816: [WIP][SPARK-36567][SQL] Support foldable special datetime strings by `CAST`
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on a change in pull request #33816:
URL: https://github.com/apache/spark/pull/33816#discussion_r694502921
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/finishAnalysis.scala
##########
@@ -119,3 +120,25 @@ case class ReplaceCurrentLike(catalogManager: CatalogManager) extends Rule[Logic
}
}
}
+
+/**
+ * Replaces casts of special datetime strings by its date/timestamp values
+ * if the input strings are foldable.
Review comment:
Do you mean `ConstantFolding`? but it is an optimization rule. Could you explain me, please, why do you think that placing "correctness" (analysis) rule to an optimization rule (which can be disabled potentially w/o violating of correctness) is good idea.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #33816: [WIP][SPARK-36567][SQL] Support foldable special datetime strings by `CAST`
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #33816:
URL: https://github.com/apache/spark/pull/33816#discussion_r694559923
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/finishAnalysis.scala
##########
@@ -119,3 +120,25 @@ case class ReplaceCurrentLike(catalogManager: CatalogManager) extends Rule[Logic
}
}
}
+
+/**
+ * Replaces casts of special datetime strings by its date/timestamp values
+ * if the input strings are foldable.
Review comment:
Oh I see, this is in the "finish analysis" batch, then there is no rule order problem with `ConstantFolding`. LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #33816: [SPARK-36567][SQL] Support foldable special datetime strings by `CAST`
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #33816:
URL: https://github.com/apache/spark/pull/33816#issuecomment-905212240
thanks, merging to master/3.2!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33816: [WIP][SPARK-36567][SQL] Support foldable special datetime strings by `CAST`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33816:
URL: https://github.com/apache/spark/pull/33816#issuecomment-904209446
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47210/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33816: [WIP][SPARK-36567][SQL] Support foldable special datetime strings by `CAST`
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33816:
URL: https://github.com/apache/spark/pull/33816#issuecomment-904265313
**[Test build #142709 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142709/testReport)** for PR 33816 at commit [`59933d2`](https://github.com/apache/spark/commit/59933d2995de7ac866081ce5515a58369d55a800).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #33816: [WIP][SPARK-36567][SQL] Support foldable special datetime strings by `CAST`
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #33816:
URL: https://github.com/apache/spark/pull/33816#discussion_r694480550
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/finishAnalysis.scala
##########
@@ -119,3 +120,25 @@ case class ReplaceCurrentLike(catalogManager: CatalogManager) extends Rule[Logic
}
}
}
+
+/**
+ * Replaces casts of special datetime strings by its date/timestamp values
+ * if the input strings are foldable.
Review comment:
Yea I think so, to avoid the side effect of rule order.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #33816: [SPARK-36567][SQL] Support foldable special datetime strings by `CAST`
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on pull request #33816:
URL: https://github.com/apache/spark/pull/33816#issuecomment-904927037
@cloud-fan @gengliangwang @HyukjinKwon Could you review this PR, please.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33816: [WIP][SPARK-36567][SQL] Support foldable special datetime strings by `CAST`
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33816:
URL: https://github.com/apache/spark/pull/33816#issuecomment-904103000
**[Test build #142708 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142708/testReport)** for PR 33816 at commit [`16371f7`](https://github.com/apache/spark/commit/16371f7a42947d73360245d269f803613031742e).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #33816: [SPARK-36567][SQL] Support foldable special datetime strings by `CAST`
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #33816:
URL: https://github.com/apache/spark/pull/33816#issuecomment-904849502
**[Test build #142741 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142741/testReport)** for PR 33816 at commit [`d7a1787`](https://github.com/apache/spark/commit/d7a17871aec6996445d8455fef8e6fb15fb2fcea).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33816: [SPARK-36567][SQL] Support foldable special datetime strings by `CAST`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33816:
URL: https://github.com/apache/spark/pull/33816#issuecomment-905025922
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142741/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #33816: [WIP][SPARK-36567][SQL] Support foldable special datetime strings by `CAST`
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #33816:
URL: https://github.com/apache/spark/pull/33816#issuecomment-904082662
**[Test build #142708 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142708/testReport)** for PR 33816 at commit [`16371f7`](https://github.com/apache/spark/commit/16371f7a42947d73360245d269f803613031742e).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33816: [WIP][SPARK-36567][SQL] Support foldable special datetime strings by `CAST`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33816:
URL: https://github.com/apache/spark/pull/33816#issuecomment-904277615
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142709/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33816: [SPARK-36567][SQL] Support foldable special datetime strings by `CAST`
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33816:
URL: https://github.com/apache/spark/pull/33816#issuecomment-905019632
**[Test build #142741 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142741/testReport)** for PR 33816 at commit [`d7a1787`](https://github.com/apache/spark/commit/d7a17871aec6996445d8455fef8e6fb15fb2fcea).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33816: [WIP][SPARK-36567][SQL] Support foldable special datetime strings by `CAST`
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33816:
URL: https://github.com/apache/spark/pull/33816#issuecomment-904849502
**[Test build #142741 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142741/testReport)** for PR 33816 at commit [`d7a1787`](https://github.com/apache/spark/commit/d7a17871aec6996445d8455fef8e6fb15fb2fcea).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #33816: [SPARK-36567][SQL] Support foldable special datetime strings by `CAST`
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #33816:
URL: https://github.com/apache/spark/pull/33816
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org