You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2013/11/21 00:23:02 UTC
Review Request 15741: Fixed balloon framework test's flags.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15741/
-----------------------------------------------------------
Review request for mesos and Ben Mahler.
Bugs: MESOS-828
https://issues.apache.org/jira/browse/MESOS-828
Repository: mesos-git
Description
-------
See bug.
Diffs
-----
src/tests/balloon_framework_test.sh 213743fc791ef15df2f1fd1cc3682f0adb12697a
Diff: https://reviews.apache.org/r/15741/diff/
Testing
-------
make check (OSX)
sudo make check (Linux)
Thanks,
Vinod Kone
Re: Review Request 15741: Fixed balloon framework test's flags.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15741/#review29199
-----------------------------------------------------------
Ship it!
Maybe the better strategy is to set the work directory in the scripts as was done in the balloon test, ensuring that cleanup happens at exit?
Otherwise the test scripts when run standalone will leak in /tmp?
Gave you a ship it regardless, but I'm not sure this is the right strategy since the scripts should work when run alone as well.
- Ben Mahler
On Nov. 20, 2013, 11:23 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15741/
> -----------------------------------------------------------
>
> (Updated Nov. 20, 2013, 11:23 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-828
> https://issues.apache.org/jira/browse/MESOS-828
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See bug.
>
>
> Diffs
> -----
>
> src/tests/balloon_framework_test.sh 213743fc791ef15df2f1fd1cc3682f0adb12697a
>
> Diff: https://reviews.apache.org/r/15741/diff/
>
>
> Testing
> -------
>
> make check (OSX)
> sudo make check (Linux)
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 15741: Fixed example tests to use temporary work
directory for slaves.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15741/#review29258
-----------------------------------------------------------
Ship it!
Ship It!
- Ben Mahler
On Nov. 21, 2013, 10:52 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15741/
> -----------------------------------------------------------
>
> (Updated Nov. 21, 2013, 10:52 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-828
> https://issues.apache.org/jira/browse/MESOS-828
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See bug.
>
>
> Diffs
> -----
>
> src/tests/balloon_framework_test.sh 213743fc791ef15df2f1fd1cc3682f0adb12697a
> src/tests/java_exception_test.sh 02a8798fb4c0fcf920a1ea5747ee27c6d86b43f9
> src/tests/java_framework_test.sh c77112d78f7e1d5ff7dde4cc66407b2699069a4b
> src/tests/no_executor_framework_test.sh 41866008fa938c310465057cc5061e62b079a571
> src/tests/python_framework_test.sh cecd8af409718de0c6ae3e4313fdaa74a1903f46
> src/tests/test_framework_test.sh ed5b7330a9d97665d60fa54d71ff0f6589a167fd
>
> Diff: https://reviews.apache.org/r/15741/diff/
>
>
> Testing
> -------
>
> make check (OSX)
> sudo make check (Linux)
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 15741: Fixed example tests to use temporary work
directory for slaves.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15741/
-----------------------------------------------------------
(Updated Nov. 21, 2013, 10:52 p.m.)
Review request for mesos and Ben Mahler.
Changes
-------
Benm's comments. PTAL.
Too bad mktemp behaves just a bit differently on OSX and Linux.
Summary (updated)
-----------------
Fixed example tests to use temporary work directory for slaves.
Bugs: MESOS-828
https://issues.apache.org/jira/browse/MESOS-828
Repository: mesos-git
Description
-------
See bug.
Diffs (updated)
-----
src/tests/balloon_framework_test.sh 213743fc791ef15df2f1fd1cc3682f0adb12697a
src/tests/java_exception_test.sh 02a8798fb4c0fcf920a1ea5747ee27c6d86b43f9
src/tests/java_framework_test.sh c77112d78f7e1d5ff7dde4cc66407b2699069a4b
src/tests/no_executor_framework_test.sh 41866008fa938c310465057cc5061e62b079a571
src/tests/python_framework_test.sh cecd8af409718de0c6ae3e4313fdaa74a1903f46
src/tests/test_framework_test.sh ed5b7330a9d97665d60fa54d71ff0f6589a167fd
Diff: https://reviews.apache.org/r/15741/diff/
Testing
-------
make check (OSX)
sudo make check (Linux)
Thanks,
Vinod Kone