[GitHub] [hbase] ndimiduk commented on a change in pull request #2215: HBASE-24627 Normalize one table at a time

[GitBox <gi...@apache.org>]

ndimiduk commented on a change in pull request #2215:
URL: https://github.com/apache/hbase/pull/2215#discussion_r468085257



##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/NormalizeTableFilterParams.java
##########
@@ -0,0 +1,91 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.client;
+
+import java.util.List;
+import org.apache.hadoop.hbase.TableName;
+import org.apache.yetus.audience.InterfaceAudience;
+import org.apache.yetus.audience.InterfaceStability;
+
+/**
+ * A collection of criteria used for table selection.
+ */
+@InterfaceAudience.Public
+@InterfaceStability.Evolving
+public class NormalizeTableFilterParams {
+  private final List<TableName> tableNames;
+  private final String regex;
+  private final String namespace;
+
+  public NormalizeTableFilterParams(

Review comment:
       No thanks. Why would we force a caller to go through the object allocation of a builder if they have all the parameters they want to set up-front?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org