You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@dubbo.apache.org by "kimmking (GitHub)" <gi...@apache.org> on 2018/10/06 02:26:10 UTC

[GitHub] [incubator-dubbo] kimmking commented on issue #2586: Optimize RoundRobinLoadBalance

> This pull request looks good to me. Nice work!
> The time complexity is O(n), where n is the number of invokers, which is a significant improvement to the previous one, which is O(n*w), where n is the number of invokers, and w is the max weight of the invokers.
> I'd prefer to have more unit tests for this algorithm.

great, I also writed some UT for it. we can PR our UTs after merging it.

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2586 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org