You are viewing a plain text version of this content. The canonical link for it is here.
Posted to graffito-dev@incubator.apache.org by Greg Reddin <gr...@apache.org> on 2005/11/23 22:27:48 UTC

Is File Upload Broken?

I am not able to upload binary files using the latest source  
including the most recent patch.

I don't see anywhere that the upload() method in DocumentAction is  
being called.  If you go through the Graffito Browser portlet and try  
to upload a document, then select a file in the upload step, then  
click "Upload Document" it simply takes you back to the same screen  
without doing anything.  DocumentAction's createWizard method is  
called a couple times, but it doesn't appear the flow ever gets  
around to calling the upload() method.

I admit that I don't know very much about Velocity and the  
GraffitoPortlet or how the flow works, but I think I'm getting  
there.  It appears to me there's some missing functionality somewhere.

Greg

Re: Is File Upload Broken?

Posted by Greg Reddin <gr...@apache.org>.
On Nov 26, 2005, at 4:29 PM, Christophe Lombart wrote:

> If you update Jetspeed  2 trunk, the problem is solved.

Thank you.  I will verify that today.

Greg


Re: Is File Upload Broken?

Posted by Greg Reddin <gr...@apache.org>.
On Nov 26, 2005, at 4:29 PM, Christophe Lombart wrote:

> Greg,
>
> If you update Jetspeed  2 trunk, the problem is solved.
>
> Christophe

Ok, it took me most of yesterday, but I can confirm that file upload  
now works.  I had to download portal-bridges and build from source to  
get Jetspeed to build from source.  Then, to get graffito to build,  
for some reason I had to install the torque plugin.  But from looking  
at the build scripts it would seem I would've needed torque a long  
time ago.  So I don't know if I somehow deleted it or managed to get  
around it.

Anyway, bottom line is it is now working and I can verify that all my  
security requirements are met.  I am amazed at the responsiveness  
here :-)  Thank you!

Greg


Re: Is File Upload Broken?

Posted by Christophe Lombart <ch...@gmail.com>.
Greg,

If you update Jetspeed  2 trunk, the problem is solved.

Christophe


On 11/24/05, Christophe Lombart <ch...@gmail.com> wrote:
> I found the cause but not yet the solution :-)
>
> ActionRequest .getContentType() return null. With J2 M3, it returns
> "MULTIPART ..." when an upload is submitted. I continue my
> investigations.
>
> Christophe
>
> On 11/24/05, Christophe Lombart <ch...@gmail.com> wrote:
> > Thanks Shinsuke,
> >
> > Can you explain what kind of issue is it ?
> >
> > Christophe
> >
> > On 11/24/05, Shinsuke SUGAYA <sh...@yahoo.co.jp> wrote:
> > > Hi Christophe,
> > >
> > > In the latest J2 code, ActionRequest seems to have issues.
> > > The cause may be:
> > >
> > > http://svn.apache.org/viewcvs/portals/jetspeed-2/trunk/components/portal/src/java/org/apache/jetspeed/engine/servlet/ServletRequestImpl.java?rev=331663&r1=331662&r2=331663&view=diff
> > >
> > > Ate,
> > >
> > > Could you check it?
> > >
> > > Regards,
> > >   shinsuke
> > >
> > >
> > > Christophe Lombart wrote:
> > > > Correct, file upload is broken.
> > > > I'm going to review the code ASAP.
> > > >
> > > > Christophe
> > > > On 11/23/05, Greg Reddin <gr...@apache.org> wrote:
> > > >
> > > >>I am not able to upload binary files using the latest source
> > > >>including the most recent patch.
> > > >>
> > > >>I don't see anywhere that the upload() method in DocumentAction is
> > > >>being called.  If you go through the Graffito Browser portlet and try
> > > >>to upload a document, then select a file in the upload step, then
> > > >>click "Upload Document" it simply takes you back to the same screen
> > > >>without doing anything.  DocumentAction's createWizard method is
> > > >>called a couple times, but it doesn't appear the flow ever gets
> > > >>around to calling the upload() method.
> > > >>
> > > >>I admit that I don't know very much about Velocity and the
> > > >>GraffitoPortlet or how the flow works, but I think I'm getting
> > > >>there.  It appears to me there's some missing functionality somewhere.
> > > >>
> > > >>Greg
> > > >>
> > > >
> > > >
> > >
> > > --------------------------------------
> > > STOP HIV/AIDS.
> > > Yahoo! JAPAN Redribbon Campaign 2005
> > > http://pr.mail.yahoo.co.jp/redribbon/
> > >
> >
>

Re: Is File Upload Broken?

Posted by Christophe Lombart <ch...@gmail.com>.
I found the cause but not yet the solution :-)

ActionRequest .getContentType() return null. With J2 M3, it returns
"MULTIPART ..." when an upload is submitted. I continue my
investigations.

Christophe

On 11/24/05, Christophe Lombart <ch...@gmail.com> wrote:
> Thanks Shinsuke,
>
> Can you explain what kind of issue is it ?
>
> Christophe
>
> On 11/24/05, Shinsuke SUGAYA <sh...@yahoo.co.jp> wrote:
> > Hi Christophe,
> >
> > In the latest J2 code, ActionRequest seems to have issues.
> > The cause may be:
> >
> > http://svn.apache.org/viewcvs/portals/jetspeed-2/trunk/components/portal/src/java/org/apache/jetspeed/engine/servlet/ServletRequestImpl.java?rev=331663&r1=331662&r2=331663&view=diff
> >
> > Ate,
> >
> > Could you check it?
> >
> > Regards,
> >   shinsuke
> >
> >
> > Christophe Lombart wrote:
> > > Correct, file upload is broken.
> > > I'm going to review the code ASAP.
> > >
> > > Christophe
> > > On 11/23/05, Greg Reddin <gr...@apache.org> wrote:
> > >
> > >>I am not able to upload binary files using the latest source
> > >>including the most recent patch.
> > >>
> > >>I don't see anywhere that the upload() method in DocumentAction is
> > >>being called.  If you go through the Graffito Browser portlet and try
> > >>to upload a document, then select a file in the upload step, then
> > >>click "Upload Document" it simply takes you back to the same screen
> > >>without doing anything.  DocumentAction's createWizard method is
> > >>called a couple times, but it doesn't appear the flow ever gets
> > >>around to calling the upload() method.
> > >>
> > >>I admit that I don't know very much about Velocity and the
> > >>GraffitoPortlet or how the flow works, but I think I'm getting
> > >>there.  It appears to me there's some missing functionality somewhere.
> > >>
> > >>Greg
> > >>
> > >
> > >
> >
> > --------------------------------------
> > STOP HIV/AIDS.
> > Yahoo! JAPAN Redribbon Campaign 2005
> > http://pr.mail.yahoo.co.jp/redribbon/
> >
>

Re: Is File Upload Broken?

Posted by Christophe Lombart <ch...@gmail.com>.
Thanks Shinsuke,

Can you explain what kind of issue is it ?

Christophe

On 11/24/05, Shinsuke SUGAYA <sh...@yahoo.co.jp> wrote:
> Hi Christophe,
>
> In the latest J2 code, ActionRequest seems to have issues.
> The cause may be:
>
> http://svn.apache.org/viewcvs/portals/jetspeed-2/trunk/components/portal/src/java/org/apache/jetspeed/engine/servlet/ServletRequestImpl.java?rev=331663&r1=331662&r2=331663&view=diff
>
> Ate,
>
> Could you check it?
>
> Regards,
>   shinsuke
>
>
> Christophe Lombart wrote:
> > Correct, file upload is broken.
> > I'm going to review the code ASAP.
> >
> > Christophe
> > On 11/23/05, Greg Reddin <gr...@apache.org> wrote:
> >
> >>I am not able to upload binary files using the latest source
> >>including the most recent patch.
> >>
> >>I don't see anywhere that the upload() method in DocumentAction is
> >>being called.  If you go through the Graffito Browser portlet and try
> >>to upload a document, then select a file in the upload step, then
> >>click "Upload Document" it simply takes you back to the same screen
> >>without doing anything.  DocumentAction's createWizard method is
> >>called a couple times, but it doesn't appear the flow ever gets
> >>around to calling the upload() method.
> >>
> >>I admit that I don't know very much about Velocity and the
> >>GraffitoPortlet or how the flow works, but I think I'm getting
> >>there.  It appears to me there's some missing functionality somewhere.
> >>
> >>Greg
> >>
> >
> >
>
> --------------------------------------
> STOP HIV/AIDS.
> Yahoo! JAPAN Redribbon Campaign 2005
> http://pr.mail.yahoo.co.jp/redribbon/
>

Re: Is File Upload Broken?

Posted by Shinsuke SUGAYA <sh...@yahoo.co.jp>.
Hi Christophe,

In the latest J2 code, ActionRequest seems to have issues.
The cause may be:

http://svn.apache.org/viewcvs/portals/jetspeed-2/trunk/components/portal/src/java/org/apache/jetspeed/engine/servlet/ServletRequestImpl.java?rev=331663&r1=331662&r2=331663&view=diff

Ate,

Could you check it?

Regards,
  shinsuke


Christophe Lombart wrote:
> Correct, file upload is broken.
> I'm going to review the code ASAP.
> 
> Christophe
> On 11/23/05, Greg Reddin <gr...@apache.org> wrote:
> 
>>I am not able to upload binary files using the latest source
>>including the most recent patch.
>>
>>I don't see anywhere that the upload() method in DocumentAction is
>>being called.  If you go through the Graffito Browser portlet and try
>>to upload a document, then select a file in the upload step, then
>>click "Upload Document" it simply takes you back to the same screen
>>without doing anything.  DocumentAction's createWizard method is
>>called a couple times, but it doesn't appear the flow ever gets
>>around to calling the upload() method.
>>
>>I admit that I don't know very much about Velocity and the
>>GraffitoPortlet or how the flow works, but I think I'm getting
>>there.  It appears to me there's some missing functionality somewhere.
>>
>>Greg
>>
> 
> 

--------------------------------------
STOP HIV/AIDS.
Yahoo! JAPAN Redribbon Campaign 2005
http://pr.mail.yahoo.co.jp/redribbon/

Re: Is File Upload Broken?

Posted by Christophe Lombart <ch...@gmail.com>.
Correct, file upload is broken.
I'm going to review the code ASAP.

Christophe
On 11/23/05, Greg Reddin <gr...@apache.org> wrote:
> I am not able to upload binary files using the latest source
> including the most recent patch.
>
> I don't see anywhere that the upload() method in DocumentAction is
> being called.  If you go through the Graffito Browser portlet and try
> to upload a document, then select a file in the upload step, then
> click "Upload Document" it simply takes you back to the same screen
> without doing anything.  DocumentAction's createWizard method is
> called a couple times, but it doesn't appear the flow ever gets
> around to calling the upload() method.
>
> I admit that I don't know very much about Velocity and the
> GraffitoPortlet or how the flow works, but I think I'm getting
> there.  It appears to me there's some missing functionality somewhere.
>
> Greg
>