You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by dawidwys <gi...@git.apache.org> on 2018/07/11 12:03:56 UTC

[GitHub] flink pull request #6120: [FLINK-7251] [types] Remove the flink-java8 module...

Github user dawidwys commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6120#discussion_r201655466
  
    --- Diff: flink-core/src/main/java/org/apache/flink/api/java/typeutils/TypeExtractor.java ---
    @@ -584,21 +581,6 @@ private static void registerFactory(Type t, Class<? extends TypeInfoFactory> fac
     				// number of parameters the SAM of implemented interface has; the parameter indexing applies to this range
     				final int baseParametersLen = sam.getParameterTypes().length;
     
    -				// executable references "this" implicitly
    -				if (paramLen <= 0) {
    --- End diff --
    
    Why you removed checking the input type information?


---