You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/06/13 08:54:49 UTC
[GitHub] [iceberg] findepi opened a new pull request, #5021: Add API changes for statistics information in table snapshot
findepi opened a new pull request, #5021:
URL: https://github.com/apache/iceberg/pull/5021
API for https://github.com/apache/iceberg/pull/4945
Implementation PR: https://github.com/apache/iceberg/pull/4741
Extracted from https://github.com/apache/iceberg/pull/4741 per https://github.com/apache/iceberg/pull/4741#discussion_r895213091
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] findepi commented on pull request #5021: Add API changes for statistics information in table metadata
Posted by GitBox <gi...@apache.org>.
findepi commented on PR #5021:
URL: https://github.com/apache/iceberg/pull/5021#issuecomment-1209488025
Build failure
```
> Could not resolve all files for configuration ':classpath'.
> Could not resolve com.palantir.baseline:gradle-baseline-java:4.0.0.
Required by:
project :
> Could not resolve com.palantir.baseline:gradle-baseline-java:4.0.0.
> Could not get resource 'https://plugins.gradle.org/m2/com/palantir/baseline/gradle-baseline-java/4.0.0/gradle-baseline-java-4.0.0.pom'.
> Could not GET 'https://plugins.gradle.org/m2/com/palantir/baseline/gradle-baseline-java/4.0.0/gradle-baseline-java-4.0.0.pom'.
> The server may not support the client's requested TLS protocol versions: (TLSv1.2, TLSv1.3). You may need to configure the client to allow other protocols to be used. See: https://docs.gradle.org/7.4.2/userguide/build_environment.html#gradle_system_properties
> Received fatal alert: handshake_failure
```
looks unrelated.
Let me push amended commit to restart the build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] findepi commented on pull request #5021: Add API changes for statistics information in table metadata
Posted by GitBox <gi...@apache.org>.
findepi commented on PR #5021:
URL: https://github.com/apache/iceberg/pull/5021#issuecomment-1206737909
@rdblue thank you for a careful review. Comments applied, the code is much better now.
The potentially immature changes to TableMetadata are moved to https://github.com/apache/iceberg/pull/5450
Can you please take another look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue merged pull request #5021: Add API changes for statistics information in table metadata
Posted by GitBox <gi...@apache.org>.
rdblue merged PR #5021:
URL: https://github.com/apache/iceberg/pull/5021
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] findepi commented on a diff in pull request #5021: Add API changes for statistics information in table snapshot
Posted by GitBox <gi...@apache.org>.
findepi commented on code in PR #5021:
URL: https://github.com/apache/iceberg/pull/5021#discussion_r896498351
##########
api/src/main/java/org/apache/iceberg/Transaction.java:
##########
@@ -137,6 +137,14 @@ default AppendFiles newFastAppend() {
*/
DeleteFiles newDelete();
+ /**
+ * Create a new {@link UpdateTableStatistics update table statistics API} to add or remove statistics
+ * files in this table.
+ *
+ * @return a new {@link UpdateTableStatistics}
+ */
+ UpdateTableStatistics updateTableStatistics();
Review Comment:
while working on https://github.com/apache/iceberg/pull/4741 I didn't realize i should have changes in Table as well. sure, will add.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on a diff in pull request #5021: Add API changes for statistics information in table snapshot
Posted by GitBox <gi...@apache.org>.
rdblue commented on code in PR #5021:
URL: https://github.com/apache/iceberg/pull/5021#discussion_r898352453
##########
api/src/main/java/org/apache/iceberg/BlobMetadata.java:
##########
@@ -0,0 +1,35 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.iceberg;
+
+import edu.umd.cs.findbugs.annotations.NonNull;
+import java.util.List;
+import java.util.Map;
+
+public interface BlobMetadata {
Review Comment:
Can you add Javadoc to this and other public classes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] findepi commented on pull request #5021: Add API changes for statistics information in table metadata
Posted by GitBox <gi...@apache.org>.
findepi commented on PR #5021:
URL: https://github.com/apache/iceberg/pull/5021#issuecomment-1229270069
I have applied the requested changes. @rdblue please take another look
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] findepi commented on a diff in pull request #5021: Add API changes for statistics information in table snapshot
Posted by GitBox <gi...@apache.org>.
findepi commented on code in PR #5021:
URL: https://github.com/apache/iceberg/pull/5021#discussion_r901362209
##########
core/src/main/java/org/apache/iceberg/BaseMetadataTable.java:
##########
@@ -216,6 +216,11 @@ public DeleteFiles newDelete() {
throw new UnsupportedOperationException("Cannot delete from a metadata table");
}
+ @Override
+ public UpdateTableStatistics updateTableStatistics() {
+ throw new UnsupportedOperationException("Cannot update statistics of a metadata table");
Review Comment:
Sure, added default method and removed impl stubs from BaseTable and BaseTransaction.
Impl in BaseMetadataTable stays because it includes "a metadata table" in the exc msg (consistently with all other methods in this class).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on a diff in pull request #5021: Add API changes for statistics information in table snapshot
Posted by GitBox <gi...@apache.org>.
rdblue commented on code in PR #5021:
URL: https://github.com/apache/iceberg/pull/5021#discussion_r896258956
##########
api/src/main/java/org/apache/iceberg/Transaction.java:
##########
@@ -137,6 +137,14 @@ default AppendFiles newFastAppend() {
*/
DeleteFiles newDelete();
+ /**
+ * Create a new {@link UpdateTableStatistics update table statistics API} to add or remove statistics
+ * files in this table.
+ *
+ * @return a new {@link UpdateTableStatistics}
+ */
+ UpdateTableStatistics updateTableStatistics();
Review Comment:
Usually we add new methods to Table and Transaction at the same time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on a diff in pull request #5021: Add API changes for statistics information in table metadata
Posted by GitBox <gi...@apache.org>.
rdblue commented on code in PR #5021:
URL: https://github.com/apache/iceberg/pull/5021#discussion_r936916111
##########
build.gradle:
##########
@@ -224,6 +224,7 @@ project(':iceberg-api') {
dependencies {
implementation project(path: ':iceberg-bundled-guava', configuration: 'shadow')
+ compileOnly "com.google.code.findbugs:jsr305"
Review Comment:
This has license issues and is not allowed. Instead, we use `com.github.stephenc.findbugs`, which is already available.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] findepi commented on a diff in pull request #5021: Add API changes for statistics information in table metadata
Posted by GitBox <gi...@apache.org>.
findepi commented on code in PR #5021:
URL: https://github.com/apache/iceberg/pull/5021#discussion_r955366507
##########
api/src/main/java/org/apache/iceberg/UpdateTableStatistics.java:
##########
@@ -0,0 +1,32 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.iceberg;
+
+import edu.umd.cs.findbugs.annotations.Nullable;
+
+/** API for updating statistics files in a table. */
+public interface UpdateTableStatistics extends PendingUpdate<Snapshot> {
Review Comment:
renamed, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] findepi commented on pull request #5021: Add API changes for statistics information in table snapshot
Posted by GitBox <gi...@apache.org>.
findepi commented on PR #5021:
URL: https://github.com/apache/iceberg/pull/5021#issuecomment-1154854904
@rdblue thank you for your review. Updated accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] findepi commented on pull request #5021: Add API changes for statistics information in table metadata
Posted by GitBox <gi...@apache.org>.
findepi commented on PR #5021:
URL: https://github.com/apache/iceberg/pull/5021#issuecomment-1227126065
> Currently, depends on #5450
rebased after that one is merged.
@rdblue please take a look
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] findepi commented on a diff in pull request #5021: Add API changes for statistics information in table metadata
Posted by GitBox <gi...@apache.org>.
findepi commented on code in PR #5021:
URL: https://github.com/apache/iceberg/pull/5021#discussion_r939049964
##########
core/src/main/java/org/apache/iceberg/TableMetadata.java:
##########
@@ -884,6 +895,17 @@ private Builder(TableMetadata base) {
this.previousFileLocation = base.metadataFileLocation;
this.previousFiles = base.previousFiles;
this.refs = Maps.newHashMap(base.refs);
+ this.statistics =
+ base.statistics.stream()
+ .collect(
+ Collectors.toMap(
+ StatisticsFile::snapshotId,
+ Function.identity(),
+ (a, b) -> {
+ throw new IllegalArgumentException(
+ "Two statistics files for same snapshot");
Review Comment:
good point
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on a diff in pull request #5021: Add API changes for statistics information in table metadata
Posted by GitBox <gi...@apache.org>.
rdblue commented on code in PR #5021:
URL: https://github.com/apache/iceberg/pull/5021#discussion_r936917943
##########
api/src/main/java/org/apache/iceberg/Table.java:
##########
@@ -263,6 +263,17 @@ default AppendFiles newFastAppend() {
*/
DeleteFiles newDelete();
+ /**
+ * Create a new {@link UpdateTableStatistics update table statistics API} to add or remove
+ * statistics files in this table.
+ *
+ * @return a new {@link UpdateTableStatistics}
+ */
+ default UpdateTableStatistics updateTableStatistics() {
Review Comment:
I think it is sufficient to call this `updateStatistics`. Is there a reason to qualify it with `table`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on a diff in pull request #5021: Add API changes for statistics information in table snapshot
Posted by GitBox <gi...@apache.org>.
rdblue commented on code in PR #5021:
URL: https://github.com/apache/iceberg/pull/5021#discussion_r898352930
##########
api/src/main/java/org/apache/iceberg/StatisticsFile.java:
##########
@@ -0,0 +1,34 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.iceberg;
+
+import java.util.List;
+
+public interface StatisticsFile {
+ String location();
Review Comment:
Should this be `path` to match the spec changes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on a diff in pull request #5021: Add API changes for statistics information in table snapshot
Posted by GitBox <gi...@apache.org>.
rdblue commented on code in PR #5021:
URL: https://github.com/apache/iceberg/pull/5021#discussion_r898353592
##########
core/src/main/java/org/apache/iceberg/BaseMetadataTable.java:
##########
@@ -216,6 +216,11 @@ public DeleteFiles newDelete() {
throw new UnsupportedOperationException("Cannot delete from a metadata table");
}
+ @Override
+ public UpdateTableStatistics updateTableStatistics() {
+ throw new UnsupportedOperationException("Cannot update statistics of a metadata table");
Review Comment:
Could you add this as a default implementation rather than adding it in this class? That way, if anyone is using the interface it doesn't break them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] findepi commented on pull request #5021: Add API changes for statistics information in table snapshot
Posted by GitBox <gi...@apache.org>.
findepi commented on PR #5021:
URL: https://github.com/apache/iceberg/pull/5021#issuecomment-1160102351
Currently, based on https://github.com/apache/iceberg/pull/4978
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on a diff in pull request #5021: Add API changes for statistics information in table metadata
Posted by GitBox <gi...@apache.org>.
rdblue commented on code in PR #5021:
URL: https://github.com/apache/iceberg/pull/5021#discussion_r936919462
##########
core/src/main/java/org/apache/iceberg/TableMetadata.java:
##########
@@ -884,6 +895,17 @@ private Builder(TableMetadata base) {
this.previousFileLocation = base.metadataFileLocation;
this.previousFiles = base.previousFiles;
this.refs = Maps.newHashMap(base.refs);
+ this.statistics =
+ base.statistics.stream()
+ .collect(
+ Collectors.toMap(
+ StatisticsFile::snapshotId,
+ Function.identity(),
+ (a, b) -> {
+ throw new IllegalArgumentException(
+ "Two statistics files for same snapshot");
Review Comment:
Is it a good idea to reject duplicate stats files? That seems like a way to needlessly break a table.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] findepi commented on a diff in pull request #5021: Add API changes for statistics information in table metadata
Posted by GitBox <gi...@apache.org>.
findepi commented on code in PR #5021:
URL: https://github.com/apache/iceberg/pull/5021#discussion_r939954652
##########
core/src/main/java/org/apache/iceberg/TableMetadata.java:
##########
@@ -1176,6 +1198,19 @@ public Builder removeBranch(String branch) {
return this;
}
+ public Builder setStatistics(String snapshotId, @Nullable StatisticsFile statisticsFile) {
+ Preconditions.checkNotNull(snapshotId, "snapshotId is null");
+ Preconditions.checkNotNull(statisticsFile, "statisticsFile is null");
+ this.statistics.put(snapshotId, statisticsFile);
+ return this;
Review Comment:
Thanks @rdblue for the pointer.
FYI, per the suggestion, i backed out `TableMetadata` changes from this PR. Will address these tests in the other one.
Can I assume the tests for `TableMetadata` changes are not prerequisite for this PR being merged?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] findepi commented on pull request #5021: Add API changes for statistics information in table metadata
Posted by GitBox <gi...@apache.org>.
findepi commented on PR #5021:
URL: https://github.com/apache/iceberg/pull/5021#issuecomment-1224039488
Currently, depends on https://github.com/apache/iceberg/pull/5450
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on a diff in pull request #5021: Add API changes for statistics information in table metadata
Posted by GitBox <gi...@apache.org>.
rdblue commented on code in PR #5021:
URL: https://github.com/apache/iceberg/pull/5021#discussion_r956271196
##########
api/src/main/java/org/apache/iceberg/UpdateStatistics.java:
##########
@@ -0,0 +1,32 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.iceberg;
+
+import edu.umd.cs.findbugs.annotations.Nullable;
+
+/** API for updating statistics files in a table. */
+public interface UpdateStatistics extends PendingUpdate<Snapshot> {
+ /**
+ * Set the table's statistics file for given snapshot, replacing the previous statistics file for
+ * the snapshot if any exists.
+ *
+ * @return this for method chaining
+ */
+ UpdateStatistics setStatisticsFile(long snapshotId, @Nullable StatisticsFile statisticsFile);
Review Comment:
Can you remove the `@Nullable` annotation?
How about naming this `setStatistics` like in `TableMetadata.Builder`?
Also, I thought we needed a `removeStatistics` method as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on a diff in pull request #5021: Add API changes for statistics information in table metadata
Posted by GitBox <gi...@apache.org>.
rdblue commented on code in PR #5021:
URL: https://github.com/apache/iceberg/pull/5021#discussion_r936925981
##########
core/src/main/java/org/apache/iceberg/TableMetadata.java:
##########
@@ -1176,6 +1198,19 @@ public Builder removeBranch(String branch) {
return this;
}
+ public Builder setStatistics(String snapshotId, @Nullable StatisticsFile statisticsFile) {
+ Preconditions.checkNotNull(snapshotId, "snapshotId is null");
+ Preconditions.checkNotNull(statisticsFile, "statisticsFile is null");
+ this.statistics.put(snapshotId, statisticsFile);
+ return this;
Review Comment:
If these methods don't add changes to the `changes` list, then the builder won't recognize that anything has been updated and will return the original metadata. This should be picked up by tests of the table metadata updates.
I think you should probably move the changes to this file (and change additions) to a separate PR. We're going to need to add `MetadataUpdate` types for this, and update the JSON parser for serializing those updates. That, and testing everything. This is probably best separated from the API changes, which can be done independently without an implementation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] findepi commented on a diff in pull request #5021: Add API changes for statistics information in table metadata
Posted by GitBox <gi...@apache.org>.
findepi commented on code in PR #5021:
URL: https://github.com/apache/iceberg/pull/5021#discussion_r939046562
##########
api/src/main/java/org/apache/iceberg/Table.java:
##########
@@ -263,6 +263,17 @@ default AppendFiles newFastAppend() {
*/
DeleteFiles newDelete();
+ /**
+ * Create a new {@link UpdateTableStatistics update table statistics API} to add or remove
+ * statistics files in this table.
+ *
+ * @return a new {@link UpdateTableStatistics}
+ */
+ default UpdateTableStatistics updateTableStatistics() {
Review Comment:
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] findepi commented on a diff in pull request #5021: Add API changes for statistics information in table metadata
Posted by GitBox <gi...@apache.org>.
findepi commented on code in PR #5021:
URL: https://github.com/apache/iceberg/pull/5021#discussion_r956625223
##########
api/src/main/java/org/apache/iceberg/UpdateStatistics.java:
##########
@@ -0,0 +1,32 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.iceberg;
+
+import edu.umd.cs.findbugs.annotations.Nullable;
+
+/** API for updating statistics files in a table. */
+public interface UpdateStatistics extends PendingUpdate<Snapshot> {
+ /**
+ * Set the table's statistics file for given snapshot, replacing the previous statistics file for
+ * the snapshot if any exists.
+ *
+ * @return this for method chaining
+ */
+ UpdateStatistics setStatisticsFile(long snapshotId, @Nullable StatisticsFile statisticsFile);
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on a diff in pull request #5021: Add API changes for statistics information in table metadata
Posted by GitBox <gi...@apache.org>.
rdblue commented on code in PR #5021:
URL: https://github.com/apache/iceberg/pull/5021#discussion_r936926538
##########
core/src/main/java/org/apache/iceberg/TableMetadataParser.java:
##########
@@ -498,6 +498,7 @@ static TableMetadata fromJson(FileIO io, String metadataLocation, JsonNode node)
entries.build(),
metadataEntries.build(),
refs,
+ ImmutableList.of(), /* TODO: support statistics */
Review Comment:
I think this should be done in a PR with the `TableMetadata` updates.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] findepi commented on a diff in pull request #5021: Add API changes for statistics information in table metadata
Posted by GitBox <gi...@apache.org>.
findepi commented on code in PR #5021:
URL: https://github.com/apache/iceberg/pull/5021#discussion_r939080621
##########
core/src/main/java/org/apache/iceberg/TableMetadata.java:
##########
@@ -1176,6 +1198,19 @@ public Builder removeBranch(String branch) {
return this;
}
+ public Builder setStatistics(String snapshotId, @Nullable StatisticsFile statisticsFile) {
+ Preconditions.checkNotNull(snapshotId, "snapshotId is null");
+ Preconditions.checkNotNull(statisticsFile, "statisticsFile is null");
+ this.statistics.put(snapshotId, statisticsFile);
+ return this;
Review Comment:
moved to https://github.com/apache/iceberg/pull/5450
##########
core/src/main/java/org/apache/iceberg/TableMetadataParser.java:
##########
@@ -498,6 +498,7 @@ static TableMetadata fromJson(FileIO io, String metadataLocation, JsonNode node)
entries.build(),
metadataEntries.build(),
refs,
+ ImmutableList.of(), /* TODO: support statistics */
Review Comment:
moved to https://github.com/apache/iceberg/pull/5450
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] findepi commented on a diff in pull request #5021: Add API changes for statistics information in table metadata
Posted by GitBox <gi...@apache.org>.
findepi commented on code in PR #5021:
URL: https://github.com/apache/iceberg/pull/5021#discussion_r939083288
##########
core/src/main/java/org/apache/iceberg/TableMetadata.java:
##########
@@ -1176,6 +1198,19 @@ public Builder removeBranch(String branch) {
return this;
}
+ public Builder setStatistics(String snapshotId, @Nullable StatisticsFile statisticsFile) {
+ Preconditions.checkNotNull(snapshotId, "snapshotId is null");
+ Preconditions.checkNotNull(statisticsFile, "statisticsFile is null");
+ this.statistics.put(snapshotId, statisticsFile);
+ return this;
Review Comment:
Can you perhaps point me to existing test coverage I should follow for these?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] findepi commented on pull request #5021: Add API changes for statistics information in table metadata
Posted by GitBox <gi...@apache.org>.
findepi commented on PR #5021:
URL: https://github.com/apache/iceberg/pull/5021#issuecomment-1207907487
Updated to apply https://github.com/apache/iceberg/pull/5450#discussion_r939727956.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] findepi commented on pull request #5021: Add API changes for statistics information in table metadata
Posted by GitBox <gi...@apache.org>.
findepi commented on PR #5021:
URL: https://github.com/apache/iceberg/pull/5021#issuecomment-1231966833
Thank you for the merge!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] findepi commented on pull request #5021: Add API changes for statistics information in table metadata
Posted by GitBox <gi...@apache.org>.
findepi commented on PR #5021:
URL: https://github.com/apache/iceberg/pull/5021#issuecomment-1201385884
Updated after merge of https://github.com/apache/iceberg/pull/4945.
@rdblue can you please take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on a diff in pull request #5021: Add API changes for statistics information in table metadata
Posted by GitBox <gi...@apache.org>.
rdblue commented on code in PR #5021:
URL: https://github.com/apache/iceberg/pull/5021#discussion_r939727576
##########
core/src/main/java/org/apache/iceberg/TableMetadata.java:
##########
@@ -1176,6 +1198,19 @@ public Builder removeBranch(String branch) {
return this;
}
+ public Builder setStatistics(String snapshotId, @Nullable StatisticsFile statisticsFile) {
+ Preconditions.checkNotNull(snapshotId, "snapshotId is null");
+ Preconditions.checkNotNull(statisticsFile, "statisticsFile is null");
+ this.statistics.put(snapshotId, statisticsFile);
+ return this;
Review Comment:
@findepi, the newer tests are going into `TestTableMetadata`. Before the builder, `TableMetadata` exposed methods like `replaceSortOrder` that are tested directly (that's why it's hard to find the tests). And quite a few things are still tested end-to-end using the table operations themselves (like `UpdateSchema`). I'd take a look at the tests for `replaceSortOrder` in `TestTableMetadata`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] findepi commented on a diff in pull request #5021: Add API changes for statistics information in table metadata
Posted by GitBox <gi...@apache.org>.
findepi commented on code in PR #5021:
URL: https://github.com/apache/iceberg/pull/5021#discussion_r939042603
##########
build.gradle:
##########
@@ -224,6 +224,7 @@ project(':iceberg-api') {
dependencies {
implementation project(path: ':iceberg-bundled-guava', configuration: 'shadow')
+ compileOnly "com.google.code.findbugs:jsr305"
Review Comment:
dropping
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on a diff in pull request #5021: Add API changes for statistics information in table metadata
Posted by GitBox <gi...@apache.org>.
rdblue commented on code in PR #5021:
URL: https://github.com/apache/iceberg/pull/5021#discussion_r936919462
##########
core/src/main/java/org/apache/iceberg/TableMetadata.java:
##########
@@ -884,6 +895,17 @@ private Builder(TableMetadata base) {
this.previousFileLocation = base.metadataFileLocation;
this.previousFiles = base.previousFiles;
this.refs = Maps.newHashMap(base.refs);
+ this.statistics =
+ base.statistics.stream()
+ .collect(
+ Collectors.toMap(
+ StatisticsFile::snapshotId,
+ Function.identity(),
+ (a, b) -> {
+ throw new IllegalArgumentException(
+ "Two statistics files for same snapshot");
Review Comment:
Is it a good idea to reject duplicate stats files? That seems like a way to needlessly break a table.
As long as this is in the builder, you'd be able to read but not modify metadata. But I'd still prefer to be able to fix this somehow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on a diff in pull request #5021: Add API changes for statistics information in table metadata
Posted by GitBox <gi...@apache.org>.
rdblue commented on code in PR #5021:
URL: https://github.com/apache/iceberg/pull/5021#discussion_r955209143
##########
api/src/main/java/org/apache/iceberg/UpdateTableStatistics.java:
##########
@@ -0,0 +1,32 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.iceberg;
+
+import edu.umd.cs.findbugs.annotations.Nullable;
+
+/** API for updating statistics files in a table. */
+public interface UpdateTableStatistics extends PendingUpdate<Snapshot> {
Review Comment:
Looks like this didn't get renamed after updating the method. It should be `UpdateStatistics`, I think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #5021: Add API changes for statistics information in table metadata
Posted by GitBox <gi...@apache.org>.
rdblue commented on PR #5021:
URL: https://github.com/apache/iceberg/pull/5021#issuecomment-1228761243
@findepi, this is looking close. I think we just need to finalize the `UpdateStatistics` methods. Do you have a PR for the `UpdateStatistics` implementation? We should be able to work on that in parallel.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] findepi commented on a diff in pull request #5021: Add API changes for statistics information in table snapshot
Posted by GitBox <gi...@apache.org>.
findepi commented on code in PR #5021:
URL: https://github.com/apache/iceberg/pull/5021#discussion_r901358525
##########
api/src/main/java/org/apache/iceberg/BlobMetadata.java:
##########
@@ -0,0 +1,35 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.iceberg;
+
+import edu.umd.cs.findbugs.annotations.NonNull;
+import java.util.List;
+import java.util.Map;
+
+public interface BlobMetadata {
Review Comment:
Added
##########
api/src/main/java/org/apache/iceberg/StatisticsFile.java:
##########
@@ -0,0 +1,34 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.iceberg;
+
+import java.util.List;
+
+public interface StatisticsFile {
+ String location();
Review Comment:
Right, changed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] findepi commented on pull request #5021: Add API changes for statistics information in table snapshot
Posted by GitBox <gi...@apache.org>.
findepi commented on PR #5021:
URL: https://github.com/apache/iceberg/pull/5021#issuecomment-1163533152
@rdblue updated this to have one stats file for a table.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] findepi commented on pull request #5021: Add API changes for statistics information in table snapshot
Posted by GitBox <gi...@apache.org>.
findepi commented on PR #5021:
URL: https://github.com/apache/iceberg/pull/5021#issuecomment-1165433241
Per offline ask from @rdblue , I extracted prep change here: https://github.com/apache/iceberg/pull/5129
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org