[GitHub] [calcite] vlsi commented on a change in pull request #1606: [CALCITE-3466] Do not drop the "group by" clause of subquery in a select statement with "group by" clause in JDBC adapter.

[GitBox <gi...@apache.org>]

vlsi commented on a change in pull request #1606: [CALCITE-3466] Do not drop the "group by" clause of subquery in a select statement with "group by" clause in JDBC adapter.
URL: https://github.com/apache/calcite/pull/1606#discussion_r364918048
 
 

 ##########
 File path: core/src/main/java/org/apache/calcite/rel/rel2sql/SqlImplementor.java
 ##########
 @@ -1224,10 +1224,18 @@ public Builder builder(RelNode rel, Clause... clauses) {
           needNew = true;
         }
       }
-      if (rel instanceof Aggregate
-          && !dialect.supportsNestedAggregations()
-          && hasNestedAggregations((Aggregate) rel)) {
-        needNew = true;
+
+      if (rel instanceof Aggregate) {
+        Aggregate e = (Aggregate) rel;
+        final boolean nestedAgg = hasNestedAggregations(e);
+        if (withGroupBy() && (!e.getGroupSet().toList().isEmpty()
+            || !nestedAgg || !dialect.supportsNestedAggregations())) {
 
 Review comment:
   `if (..` above is confusing.
   
   What is `!e.getGroupSet().toList().isEmpty()`?
   Is it equivalent to `isNotGrandTotal(e)`?
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services