You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Yifan Zhang (Code Review)" <ge...@cloudera.org> on 2019/11/21 08:49:49 UTC
[kudu-CR] www: Add tablet On-Disk Size info to /table
Yifan Zhang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14771
Change subject: www: Add tablet On-Disk Size info to /table
......................................................................
www: Add tablet On-Disk Size info to /table
This patch added 'On-Disk Size' info for each tablet of a table
on master webui /table page, so that we could easily find the
data skew of the table.
Screenshot: http://ww1.sinaimg.cn/large/9b7ebaddly1g95qi53zcsj21ef0qgq9k.jpg
Change-Id: I8cd84420968383d11658df45719a5b2070505291
---
M src/kudu/master/master_path_handlers.cc
M www/table.mustache
2 files changed, 6 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/71/14771/1
--
To view, visit http://gerrit.cloudera.org:8080/14771
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8cd84420968383d11658df45719a5b2070505291
Gerrit-Change-Number: 14771
Gerrit-PatchSet: 1
Gerrit-Owner: Yifan Zhang <ch...@163.com>
[kudu-CR] www: Add tablet on disk size info to /table
Posted by "Yifan Zhang (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14771
to look at the new patch set (#2).
Change subject: www: Add tablet on_disk_size info to /table
......................................................................
www: Add tablet on_disk_size info to /table
This patch added on_disk_size info for each tablet of a table
on master webui /table page, and supported sorting on tablets by
on_disk_size, so that we could easily find the data skew of the table.
Screenshot: http://ww1.sinaimg.cn/large/9b7ebaddly1g95qi53zcsj21ef0qgq9k.jpg
Change-Id: I8cd84420968383d11658df45719a5b2070505291
---
M src/kudu/master/master_path_handlers.cc
M www/table.mustache
2 files changed, 6 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/71/14771/2
--
To view, visit http://gerrit.cloudera.org:8080/14771
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8cd84420968383d11658df45719a5b2070505291
Gerrit-Change-Number: 14771
Gerrit-PatchSet: 2
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] www: Add tablet On-Disk Size info to /table
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14771 )
Change subject: www: Add tablet On-Disk Size info to /table
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14771
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8cd84420968383d11658df45719a5b2070505291
Gerrit-Change-Number: 14771
Gerrit-PatchSet: 3
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Fri, 22 Nov 2019 02:29:51 +0000
Gerrit-HasComments: No
[kudu-CR] www: Add tablet On-Disk Size info to /table
Posted by "Yifan Zhang (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Andrew Wong, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14771
to look at the new patch set (#3).
Change subject: www: Add tablet On-Disk Size info to /table
......................................................................
www: Add tablet On-Disk Size info to /table
This patch added 'On-Disk Size' info for each tablet of a table
on master webui /table page, and supported sorting on tablets by
on_disk_size, so that we could easily find the data skew of the table.
Screenshot: http://ww1.sinaimg.cn/large/9b7ebaddly1g96lqe35qgj21eg0q87au.jpg
Change-Id: I8cd84420968383d11658df45719a5b2070505291
---
M src/kudu/master/master_path_handlers.cc
M www/table.mustache
2 files changed, 6 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/71/14771/3
--
To view, visit http://gerrit.cloudera.org:8080/14771
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8cd84420968383d11658df45719a5b2070505291
Gerrit-Change-Number: 14771
Gerrit-PatchSet: 3
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] www: Add tablet On-Disk Size info to /table
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14771 )
Change subject: www: Add tablet On-Disk Size info to /table
......................................................................
www: Add tablet On-Disk Size info to /table
This patch added 'On-Disk Size' info for each tablet of a table
on master webui /table page, and supported sorting on tablets by
on_disk_size, so that we could easily find the data skew of the table.
Screenshot: http://ww1.sinaimg.cn/large/9b7ebaddly1g96lqe35qgj21eg0q87au.jpg
Change-Id: I8cd84420968383d11658df45719a5b2070505291
Reviewed-on: http://gerrit.cloudera.org:8080/14771
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
---
M src/kudu/master/master_path_handlers.cc
M www/table.mustache
2 files changed, 6 insertions(+), 1 deletion(-)
Approvals:
Adar Dembo: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/14771
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I8cd84420968383d11658df45719a5b2070505291
Gerrit-Change-Number: 14771
Gerrit-PatchSet: 4
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
[kudu-CR] www: Add tablet On-Disk Size info to /table
Posted by "Yifan Zhang (Code Review)" <ge...@cloudera.org>.
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/14771 )
Change subject: www: Add tablet On-Disk Size info to /table
......................................................................
Patch Set 3:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/14771/2/www/table.mustache
File www/table.mustache:
http://gerrit.cloudera.org:8080/#/c/14771/2/www/table.mustache@99
PS2, Line 99: <table data-toggle="table" class='table table-striped table-hover'>
> Remind me what this does?
This is used to sort columns.
http://gerrit.cloudera.org:8080/#/c/14771/2/www/table.mustache@105
PS2, Line 105: <th data-sorter="bytesSorter" data-sortable="true">On-Disk Size (leaders only)</th>
> Yeah, perhaps "On-Disk Size (leaders only)" or somesuch
Done
--
To view, visit http://gerrit.cloudera.org:8080/14771
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8cd84420968383d11658df45719a5b2070505291
Gerrit-Change-Number: 14771
Gerrit-PatchSet: 3
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Fri, 22 Nov 2019 02:28:04 +0000
Gerrit-HasComments: Yes
[kudu-CR] www: Add tablet on disk size info to /table
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14771 )
Change subject: www: Add tablet on_disk_size info to /table
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/14771/2/www/table.mustache
File www/table.mustache:
http://gerrit.cloudera.org:8080/#/c/14771/2/www/table.mustache@105
PS2, Line 105: <th data-sorter="bytesSorter" data-sortable="true">On-Disk Size (pre-replication)</th>
> Should we somehow stipulate that this is based on what the LEADER replica r
Yeah, perhaps "On-Disk Size (leaders only)" or somesuch
--
To view, visit http://gerrit.cloudera.org:8080/14771
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8cd84420968383d11658df45719a5b2070505291
Gerrit-Change-Number: 14771
Gerrit-PatchSet: 2
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 21 Nov 2019 22:39:38 +0000
Gerrit-HasComments: Yes
[kudu-CR] www: Add tablet on disk size info to /table
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14771 )
Change subject: www: Add tablet on_disk_size info to /table
......................................................................
Patch Set 2: Code-Review+2
(2 comments)
http://gerrit.cloudera.org:8080/#/c/14771/2/www/table.mustache
File www/table.mustache:
http://gerrit.cloudera.org:8080/#/c/14771/2/www/table.mustache@99
PS2, Line 99: <table data-toggle="table" class='table table-striped table-hover'>
Remind me what this does?
http://gerrit.cloudera.org:8080/#/c/14771/2/www/table.mustache@105
PS2, Line 105: <th data-sorter="bytesSorter" data-sortable="true">On-Disk Size (pre-replication)</th>
Should we somehow stipulate that this is based on what the LEADER replica reported? Seems useful to know, but hard to describe all that in just the table header.
--
To view, visit http://gerrit.cloudera.org:8080/14771
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8cd84420968383d11658df45719a5b2070505291
Gerrit-Change-Number: 14771
Gerrit-PatchSet: 2
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 21 Nov 2019 22:38:19 +0000
Gerrit-HasComments: Yes