[GitHub] [beam] tvalentyn commented on a diff in pull request #21968: Replace distutils with supported modules.

[GitBox <gi...@apache.org>]

tvalentyn commented on code in PR #21968:
URL: https://github.com/apache/beam/pull/21968#discussion_r918205440


##########
sdks/python/setup.py:
##########
@@ -30,9 +28,15 @@
 from pkg_resources import DistributionNotFound
 from pkg_resources import get_distribution
 from pkg_resources import normalize_path
+from pkg_resources import parse_version
 from pkg_resources import to_filename
 from setuptools import Command
 
+# distutils from stdlib is deprecated from python 3.10.
+# setuptools has been maintaining a copy of distutils and importing
+# setuptools will replace stdlib/distutils with setuptools/distutils.

Review Comment:
   Add: 
   # It is recommended to import setuptools prior to importing distutils to avoid
   # using legacy behavior from distutils.
   # https://setuptools.readthedocs.io/en/latest/history.html#v48-0-0



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org