You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/12/02 06:25:22 UTC

[GitHub] [apisix-dashboard] spacewander commented on a change in pull request #948: fix: remote_addrs

spacewander commented on a change in pull request #948:
URL: https://github.com/apache/apisix-dashboard/pull/948#discussion_r533924354



##########
File path: web/src/pages/Route/transform.ts
##########
@@ -82,6 +82,7 @@ export const transformStepData = ({
       !Object.keys(step3DataCloned.script || {}).length ? 'script' : '',
       form1Data.hosts.filter(Boolean).length === 0 ? 'hosts' : '',
       form1Data.redirectOption === 'disabled' ? 'redirect' : '',
+      data.remote_addrs?.filter(Boolean).length === 0 ? 'remote_addrs' : '',

Review comment:
       Why `empty array` is equal to `omit that field`? They are quite different things. The former one is a `[]`, while the latter one is `nil`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org