[GitHub] [trafficcontrol] rob05c opened a new pull request #6626: Fix t3c Capability to not continue on error

[GitBox <gi...@apache.org>]

rob05c opened a new pull request #6626:
URL: https://github.com/apache/trafficcontrol/pull/6626


   This bug causes catastrophic config gen errors if the TO request
   for ds_required_caps fails but server_reqs succeeds,
   because then no servers have required caps, causing remap lines
   for all DSes with required caps to be omitted.
   
   This fixes it by making capability failures fail, rather than
   continuing.
   
   It formerly continued, because when capabilities were introduced,
   it was necessary to continue if TO was older than t3c/ORT. But
   now, the fallback API major version is 3.0, which has Capabilities.
   
   If this bug wasn't fixed by simply always failing, it would have to
   be fixed by making a server_caps error also set ds_req_caps to nil.
   
   ## Which Traffic Control components are affected by this PR?
   - Traffic Control Cache Config (`t3c`, formerly ORT)
   
   ## What is the best way to verify this PR?
   Verify t3c fails when it fails to get server_capabilities or delivery_service_required_capabilities, rather than continuing.
   
   ## If this is a bugfix, which Traffic Control versions contained the bug?
   - 4.0 thru 6.1
   
   ## PR submission checklist
   - ~[x] This PR has tests~ no tests, unfortunately the t3c integration test framework isn't capable of simulating TO failures, it would require considerable extension to do so, and this is a TO request so it can't be unit tested.
   - ~[x] This PR has documentation~ no docs, no interface change
   - [x] This PR has a CHANGELOG.md entry <!-- A fix for a bug from an ATC release, an improvement, or a new feature should have a changelog entry. -->
   - [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://apache.org/security) for details)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficcontrol] mitchell852 merged pull request #6626: Fix t3c Capability to not continue on error

[GitBox <gi...@apache.org>]

mitchell852 merged pull request #6626:
URL: https://github.com/apache/trafficcontrol/pull/6626


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org