You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2015/03/26 00:13:14 UTC
Review Request 32506: Added output stream operators for scheduler
Calls and Events.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32506/
-----------------------------------------------------------
Review request for mesos and Ben Mahler.
Bugs: MESOS-1127
https://issues.apache.org/jira/browse/MESOS-1127
Repository: mesos
Description
-------
For readable output in logs.
Diffs
-----
include/mesos/type_utils.hpp cdf5864389a72002b538c263d70bcade2bdffa45
Diff: https://reviews.apache.org/r/32506/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request 32506: Added output stream operators for scheduler
Calls and Events.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32506/
-----------------------------------------------------------
(Updated April 22, 2015, 9:46 p.m.)
Review request for mesos and Ben Mahler.
Changes
-------
updated "depends on". NNFR.
Bugs: MESOS-1127
https://issues.apache.org/jira/browse/MESOS-1127
Repository: mesos
Description
-------
For readable output in logs.
Diffs
-----
include/mesos/type_utils.hpp cdf5864389a72002b538c263d70bcade2bdffa45
src/master/master.cpp e30b951eda2b3b0d5b2a80716f0b32c6bbe041bc
Diff: https://reviews.apache.org/r/32506/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request 32506: Added output stream operators for scheduler
Calls and Events.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32506/#review80992
-----------------------------------------------------------
Ship it!
Ship It!
- Alexander Rukletsov
On April 20, 2015, 8:02 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32506/
> -----------------------------------------------------------
>
> (Updated April 20, 2015, 8:02 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-1127
> https://issues.apache.org/jira/browse/MESOS-1127
>
>
> Repository: mesos
>
>
> Description
> -------
>
> For readable output in logs.
>
>
> Diffs
> -----
>
> include/mesos/type_utils.hpp cdf5864389a72002b538c263d70bcade2bdffa45
> src/master/master.cpp e30b951eda2b3b0d5b2a80716f0b32c6bbe041bc
>
> Diff: https://reviews.apache.org/r/32506/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 32506: Added output stream operators for scheduler
Calls and Events.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32506/
-----------------------------------------------------------
(Updated April 20, 2015, 8:02 p.m.)
Review request for mesos and Ben Mahler.
Changes
-------
Alex's. NNFR.
Bugs: MESOS-1127
https://issues.apache.org/jira/browse/MESOS-1127
Repository: mesos
Description
-------
For readable output in logs.
Diffs (updated)
-----
include/mesos/type_utils.hpp cdf5864389a72002b538c263d70bcade2bdffa45
src/master/master.cpp e30b951eda2b3b0d5b2a80716f0b32c6bbe041bc
Diff: https://reviews.apache.org/r/32506/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request 32506: Added output stream operators for scheduler
Calls and Events.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32506/#review79376
-----------------------------------------------------------
Ship it!
include/mesos/type_utils.hpp
<https://reviews.apache.org/r/32506/#comment128651>
Shall we include <ostream> as well?
include/mesos/type_utils.hpp
<https://reviews.apache.org/r/32506/#comment128655>
`scheduler::Call_Type_Name()` for clarity?
include/mesos/type_utils.hpp
<https://reviews.apache.org/r/32506/#comment128656>
`scheduler::Event_Type_Name()` for clarity?
- Alexander Rukletsov
On April 3, 2015, 11:42 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32506/
> -----------------------------------------------------------
>
> (Updated April 3, 2015, 11:42 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-1127
> https://issues.apache.org/jira/browse/MESOS-1127
>
>
> Repository: mesos
>
>
> Description
> -------
>
> For readable output in logs.
>
>
> Diffs
> -----
>
> include/mesos/type_utils.hpp cdf5864389a72002b538c263d70bcade2bdffa45
> src/master/master.cpp 618db68ee4163b06e479cf3413eda4b63c9c5a4b
>
> Diff: https://reviews.apache.org/r/32506/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 32506: Added output stream operators for scheduler
Calls and Events.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32506/
-----------------------------------------------------------
(Updated April 3, 2015, 11:42 p.m.)
Review request for mesos and Ben Mahler.
Changes
-------
updated dependency. NNFR.
Bugs: MESOS-1127
https://issues.apache.org/jira/browse/MESOS-1127
Repository: mesos
Description
-------
For readable output in logs.
Diffs (updated)
-----
include/mesos/type_utils.hpp cdf5864389a72002b538c263d70bcade2bdffa45
src/master/master.cpp 618db68ee4163b06e479cf3413eda4b63c9c5a4b
Diff: https://reviews.apache.org/r/32506/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request 32506: Added output stream operators for scheduler
Calls and Events.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32506/
-----------------------------------------------------------
(Updated March 31, 2015, 12:09 a.m.)
Review request for mesos and Ben Mahler.
Changes
-------
rebased. NNFR.
Bugs: MESOS-1127
https://issues.apache.org/jira/browse/MESOS-1127
Repository: mesos
Description
-------
For readable output in logs.
Diffs (updated)
-----
include/mesos/type_utils.hpp cdf5864389a72002b538c263d70bcade2bdffa45
src/master/master.cpp 618db68ee4163b06e479cf3413eda4b63c9c5a4b
Diff: https://reviews.apache.org/r/32506/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request 32506: Added output stream operators for scheduler
Calls and Events.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32506/
-----------------------------------------------------------
(Updated March 27, 2015, 12:05 a.m.)
Review request for mesos and Ben Mahler.
Changes
-------
Minor fix. NNFR.
Bugs: MESOS-1127
https://issues.apache.org/jira/browse/MESOS-1127
Repository: mesos
Description
-------
For readable output in logs.
Diffs (updated)
-----
include/mesos/type_utils.hpp cdf5864389a72002b538c263d70bcade2bdffa45
src/master/master.cpp dccd7c635da4b7031cd109bd84e7f17b31777ef1
Diff: https://reviews.apache.org/r/32506/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request 32506: Added output stream operators for scheduler
Calls and Events.
Posted by Michael Park <mc...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32506/#review77858
-----------------------------------------------------------
LGTM!
- Michael Park
On March 25, 2015, 11:13 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32506/
> -----------------------------------------------------------
>
> (Updated March 25, 2015, 11:13 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-1127
> https://issues.apache.org/jira/browse/MESOS-1127
>
>
> Repository: mesos
>
>
> Description
> -------
>
> For readable output in logs.
>
>
> Diffs
> -----
>
> include/mesos/type_utils.hpp cdf5864389a72002b538c263d70bcade2bdffa45
>
> Diff: https://reviews.apache.org/r/32506/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 32506: Added output stream operators for scheduler
Calls and Events.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32506/#review77847
-----------------------------------------------------------
Ship it!
Ship It!
- Ben Mahler
On March 25, 2015, 11:13 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32506/
> -----------------------------------------------------------
>
> (Updated March 25, 2015, 11:13 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-1127
> https://issues.apache.org/jira/browse/MESOS-1127
>
>
> Repository: mesos
>
>
> Description
> -------
>
> For readable output in logs.
>
>
> Diffs
> -----
>
> include/mesos/type_utils.hpp cdf5864389a72002b538c263d70bcade2bdffa45
>
> Diff: https://reviews.apache.org/r/32506/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>