You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "thelproad (GitHub)" <gi...@apache.org> on 2019/08/19 07:34:24 UTC
[GitHub] [dubbo] thelproad opened pull request #4872: Optimize
StringBuilder#append
Optimize StringBuilder#append.
[ Full content available at: https://github.com/apache/dubbo/pull/4872 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo] codecov-io commented on issue #4872: Optimize
StringBuilder#append
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/4872?src=pr&el=h1) Report
> Merging [#4872](https://codecov.io/gh/apache/dubbo/pull/4872?src=pr&el=desc) into [master](https://codecov.io/gh/apache/dubbo/commit/171ed255a05ef82f47bc5bacd424019004e5bb49?src=pr&el=desc) will **decrease** coverage by `0.06%`.
> The diff coverage is `72.22%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/4872/graphs/tree.svg?width=650&token=VnEIkiFQT0&height=150&src=pr)](https://codecov.io/gh/apache/dubbo/pull/4872?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4872 +/- ##
============================================
- Coverage 63.97% 63.91% -0.07%
+ Complexity 452 450 -2
============================================
Files 769 769
Lines 33177 33174 -3
Branches 5229 5229
============================================
- Hits 21226 21204 -22
- Misses 9530 9547 +17
- Partials 2421 2423 +2
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/4872?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../rpc/protocol/dubbo/telnet/CountTelnetHandler.java](https://codecov.io/gh/apache/dubbo/pull/4872/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL3Byb3RvY29sL2R1YmJvL3RlbG5ldC9Db3VudFRlbG5ldEhhbmRsZXIuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...protocol/dubbo/status/ThreadPoolStatusChecker.java](https://codecov.io/gh/apache/dubbo/pull/4872/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL3Byb3RvY29sL2R1YmJvL3N0YXR1cy9UaHJlYWRQb29sU3RhdHVzQ2hlY2tlci5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...rpc/protocol/dubbo/telnet/InvokeTelnetHandler.java](https://codecov.io/gh/apache/dubbo/pull/4872/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL3Byb3RvY29sL2R1YmJvL3RlbG5ldC9JbnZva2VUZWxuZXRIYW5kbGVyLmphdmE=) | `72.86% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...bo/rpc/protocol/dubbo/telnet/LogTelnetHandler.java](https://codecov.io/gh/apache/dubbo/pull/4872/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL3Byb3RvY29sL2R1YmJvL3RlbG5ldC9Mb2dUZWxuZXRIYW5kbGVyLmphdmE=) | `71.42% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...rpc/protocol/dubbo/telnet/ChangeTelnetHandler.java](https://codecov.io/gh/apache/dubbo/pull/4872/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL3Byb3RvY29sL2R1YmJvL3RlbG5ldC9DaGFuZ2VUZWxuZXRIYW5kbGVyLmphdmE=) | `86.36% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...o/rpc/protocol/dubbo/telnet/PortTelnetHandler.java](https://codecov.io/gh/apache/dubbo/pull/4872/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL3Byb3RvY29sL2R1YmJvL3RlbG5ldC9Qb3J0VGVsbmV0SGFuZGxlci5qYXZh) | `87.17% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...che/dubbo/remoting/transport/mina/MinaChannel.java](https://codecov.io/gh/apache/dubbo/pull/4872/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbWluYS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcmVtb3RpbmcvdHJhbnNwb3J0L21pbmEvTWluYUNoYW5uZWwuamF2YQ==) | `43.42% <0%> (-10.53%)` | `16% <0%> (-1%)` | |
| [.../remoting/transport/netty4/NettyServerHandler.java](https://codecov.io/gh/apache/dubbo/pull/4872/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHk0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHk0L05ldHR5U2VydmVySGFuZGxlci5qYXZh) | `61.9% <0%> (-9.53%)` | `0% <0%> (ø)` | |
| [...ng/transport/dispatcher/all/AllChannelHandler.java](https://codecov.io/gh/apache/dubbo/pull/4872/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvZGlzcGF0Y2hlci9hbGwvQWxsQ2hhbm5lbEhhbmRsZXIuamF2YQ==) | `51.42% <0%> (-5.72%)` | `0% <0%> (ø)` | |
| [...ng/exchange/support/header/HeartbeatTimerTask.java](https://codecov.io/gh/apache/dubbo/pull/4872/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9leGNoYW5nZS9zdXBwb3J0L2hlYWRlci9IZWFydGJlYXRUaW1lclRhc2suamF2YQ==) | `73.68% <0%> (-5.27%)` | `0% <0%> (ø)` | |
| ... and [4 more](https://codecov.io/gh/apache/dubbo/pull/4872/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/4872?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/4872?src=pr&el=footer). Last update [171ed25...934b456](https://codecov.io/gh/apache/dubbo/pull/4872?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/dubbo/pull/4872 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org