You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by la...@apache.org on 2013/08/13 02:02:29 UTC
svn commit: r1513304 - in
/hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver:
IncreasingToUpperBoundRegionSplitPolicy.java RegionSplitPolicy.java
Author: larsh
Date: Tue Aug 13 00:02:29 2013
New Revision: 1513304
URL: http://svn.apache.org/r1513304
Log:
HBASE-9189 IncreasingToUpperBoundRegionSplitPolicy.shouldSplit() should check all the stores before returning. (Jean-Marc Spaggiari)
Modified:
hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/IncreasingToUpperBoundRegionSplitPolicy.java
hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/RegionSplitPolicy.java
Modified: hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/IncreasingToUpperBoundRegionSplitPolicy.java
URL: http://svn.apache.org/viewvc/hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/IncreasingToUpperBoundRegionSplitPolicy.java?rev=1513304&r1=1513303&r2=1513304&view=diff
==============================================================================
--- hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/IncreasingToUpperBoundRegionSplitPolicy.java (original)
+++ hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/IncreasingToUpperBoundRegionSplitPolicy.java Tue Aug 13 00:02:29 2013
@@ -80,7 +80,6 @@ extends ConstantSizeRegionSplitPolicy {
" size=" + size + ", sizeToCheck=" + sizeToCheck +
", regionsWithCommonTable=" + tableRegionsCount);
foundABigStore = true;
- break;
}
}
Modified: hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/RegionSplitPolicy.java
URL: http://svn.apache.org/viewvc/hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/RegionSplitPolicy.java?rev=1513304&r1=1513303&r2=1513304&view=diff
==============================================================================
--- hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/RegionSplitPolicy.java (original)
+++ hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/RegionSplitPolicy.java Tue Aug 13 00:02:29 2013
@@ -42,7 +42,7 @@ public abstract class RegionSplitPolicy
* The region configured for this split policy.
*/
protected HRegion region;
-
+
/**
* Upon construction, this method will be called with the region
* to be governed. It will be called once and only once.
@@ -52,7 +52,7 @@ public abstract class RegionSplitPolicy
this.region == null,
"Policy already configured for region {}",
this.region);
-
+
this.region = region;
}
@@ -83,7 +83,7 @@ public abstract class RegionSplitPolicy
largestStoreSize = storeSize;
}
}
-
+
return splitPointFromLargestStore;
}
@@ -97,14 +97,13 @@ public abstract class RegionSplitPolicy
*/
public static RegionSplitPolicy create(HRegion region,
Configuration conf) throws IOException {
-
Class<? extends RegionSplitPolicy> clazz = getSplitPolicyClass(
region.getTableDesc(), conf);
RegionSplitPolicy policy = ReflectionUtils.newInstance(clazz, conf);
policy.configureForRegion(region);
return policy;
}
-
+
static Class<? extends RegionSplitPolicy> getSplitPolicyClass(
HTableDescriptor htd, Configuration conf) throws IOException {
String className = htd.getRegionSplitPolicyClassName();