You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@couchdb.apache.org by robertkowalski <gi...@git.apache.org> on 2014/04/20 15:50:42 UTC
[GitHub] couchdb pull request: Fix accidental globals and enable JSHint Fla...
GitHub user robertkowalski opened a pull request:
https://github.com/apache/couchdb/pull/215
Fix accidental globals and enable JSHint Flag to detect them
As a developer, I don't want to accidentally pollute the global
namespace and rely on global state.
I enabled the JSHint flag in the grunt task and removed all
the globals.
PTAL @deathbearbrown and @garrensmith
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/robertkowalski/couchdb fix-accidental-globals-grunt-rebase
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb/pull/215.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #215
----
commit 97c75a165c1ce710cfdfafb5184cce7813c9b90a
Author: Robert Kowalski <ro...@kowalski.gd>
Date: 2014-04-20T13:32:42Z
Fauxton: test for globals
As a developer, I don't want to accidentally pollute the global
namespace and rely on global state.
commit ef283c41326a50f853a86ed5f2ea48a5fc6f8899
Author: Robert Kowalski <ro...@kowalski.gd>
Date: 2014-04-20T13:34:36Z
Fauxton: remove superfluous console.log
commit 4add7bc487c98cb53794bb93538933837b567d33
Author: Robert Kowalski <ro...@kowalski.gd>
Date: 2014-04-20T13:36:47Z
Fix stats
commit de2c070a316f89b34d6636d5a4e39fcc49b5e5b5
Author: Robert Kowalski <ro...@kowalski.gd>
Date: 2014-04-20T13:37:52Z
fix permissions
commit 7737a046c514da08b724e28283f54c459ff86466
Author: Robert Kowalski <ro...@kowalski.gd>
Date: 2014-04-20T13:38:46Z
fix activetasks
commit 130ac2093c209f9f06634377d2b0f23a9c6da8e4
Author: Robert Kowalski <ro...@kowalski.gd>
Date: 2014-04-20T13:39:29Z
fix auth
commit 366b0f8d196766b470a638067eea40729b2f877d
Author: Robert Kowalski <ro...@kowalski.gd>
Date: 2014-04-20T13:40:25Z
fix pouchdb.mapreduce.js
commit 7cbe78f00b77e2819db9677cf0e06d73d256f77f
Author: Robert Kowalski <ro...@kowalski.gd>
Date: 2014-04-20T13:41:17Z
fix documents
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb pull request: Fix accidental globals and enable JSHint Fla...
Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb/pull/215#issuecomment-40942984
LGTM +1. Merge it!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb pull request: Fix accidental globals and enable JSHint Fla...
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb/pull/215#issuecomment-41315763
merged :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb pull request: Fix accidental globals and enable JSHint Fla...
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski closed the pull request at:
https://github.com/apache/couchdb/pull/215
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---