You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@shiro.apache.org by GitBox <gi...@apache.org> on 2020/06/14 15:30:27 UTC
[GitHub] [shiro] fpapon opened a new pull request #239: [SHIRO-780] NOTICE files of shiro components don't match NOTICE in so…
fpapon opened a new pull request #239:
URL: https://github.com/apache/shiro/pull/239
…urce code repository
The apache-jar-resource-bundle generate default NOTICE file from velocity template, so we have to override this default NOTICE file by the root project one.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shiro] bdemers commented on pull request #239: [SHIRO-780] NOTICE files of shiro components don't match NOTICE in so…
Posted by GitBox <gi...@apache.org>.
bdemers commented on pull request #239:
URL: https://github.com/apache/shiro/pull/239#issuecomment-644271663
We should probably filter these files in if/when needed, possibly just in the core/lang module (and if they get repackaged in the `all` module). Or copy a single static NOTICE file in from the root (instead of duplicating it)
Ideas:
A side note, we can also use the `org.jasig.maven:maven-notice-plugin` plugin to generate a notice
https://github.com/paseto-toolkit/jpaseto/blob/master/pom.xml#L239-L251
(**NOTE:** the usage above differs from the ASF requirements)
Another trick is to define a `root.dir` property: in the parent pom:
```xml
<root.dir>${session.executionRootDirectory}</root.dir>
```
And include the resource as `${root.dir}/NOTICE`
But... depending on how maven multi-modules are being used in the project it _might_ be easier to reference them as `../../NOTICE` instead.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shiro] bdemers commented on pull request #239: [SHIRO-780] NOTICE files of shiro components don't match NOTICE in so…
Posted by GitBox <gi...@apache.org>.
bdemers commented on pull request #239:
URL: https://github.com/apache/shiro/pull/239#issuecomment-644272854
@fpapon I'm not sure if any of these suggestions work around the template issue either)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shiro] bdemers commented on pull request #239: [SHIRO-780] NOTICE files of shiro components don't match NOTICE in so…
Posted by GitBox <gi...@apache.org>.
bdemers commented on pull request #239:
URL: https://github.com/apache/shiro/pull/239#issuecomment-644331776
OHHH, I see now.
I didn't realize where that was coming from. We can probably get away with the template for most modules. And only include a custom NOTICE (just copied in as you have) in the modules were needed (for example `lang`)
But I'm not sure if/how the bundle plugin plays into this, because IIRC the bundle plugin repacks some of the dependencies?
We could also "skip" this plugin's execution and make sure the LICENSE & NOTICE files are included by other means.
Anyway, I'm not trying to create more work just to work around a NOTICE bundling issue. If you can simplify it, great, if not, what you have in this PR is legally correct (which is more important)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shiro] bdemers commented on pull request #239: [SHIRO-780] NOTICE files of shiro components don't match NOTICE in so…
Posted by GitBox <gi...@apache.org>.
bdemers commented on pull request #239:
URL: https://github.com/apache/shiro/pull/239#issuecomment-669256545
Works for me
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shiro] fpapon commented on pull request #239: [SHIRO-780] NOTICE files of shiro components don't match NOTICE in so…
Posted by GitBox <gi...@apache.org>.
fpapon commented on pull request #239:
URL: https://github.com/apache/shiro/pull/239#issuecomment-669178979
@bdemers I'm not sure to have more time to work on this for the 1.5.x/1.6 release
I propose to merge this one as-is and work on your proposal for the plugin adjust on the 2.0.0 release
Thoughts?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shiro] fpapon commented on pull request #239: [SHIRO-780] NOTICE files of shiro components don't match NOTICE in so…
Posted by GitBox <gi...@apache.org>.
fpapon commented on pull request #239:
URL: https://github.com/apache/shiro/pull/239#issuecomment-644312616
@bdemers the problem is the apache pom parent definition with the apache-jar-resource-bundle, it generate the NOTICE file from Apache template.
I'm agree that it's not nice to maintain... I will made some tests, may be by copying the root NOTICE file in target folder during process cycle. I'll keep you posted ;)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shiro] fpapon commented on pull request #239: [SHIRO-780] NOTICE files of shiro components don't match NOTICE in so…
Posted by GitBox <gi...@apache.org>.
fpapon commented on pull request #239:
URL: https://github.com/apache/shiro/pull/239#issuecomment-644337173
Ok, no problem ;)
I will try to config the apache plugin.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shiro] bdemers commented on pull request #239: [SHIRO-780] NOTICE files of shiro components don't match NOTICE in so…
Posted by GitBox <gi...@apache.org>.
bdemers commented on pull request #239:
URL: https://github.com/apache/shiro/pull/239#issuecomment-644272432
NOTE: I'm not against maintaining the NOTICE by hand. It might be easier to handwrite notice files in a couple of the modules were needed, and merge them into the project's root NOTICE file.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shiro] fpapon merged pull request #239: [SHIRO-780] NOTICE files of shiro components don't match NOTICE in so…
Posted by GitBox <gi...@apache.org>.
fpapon merged pull request #239:
URL: https://github.com/apache/shiro/pull/239
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org