You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2021/04/14 04:05:07 UTC

[GitHub] [helix] jiajunwang commented on issue #1661: Flaky test: TestCleanupExternalView.test

jiajunwang commented on issue #1661:
URL: https://github.com/apache/helix/issues/1661#issuecomment-819212408


   The test logic is not very up-to-date. IMO, the original test was trying to test if EV is removed when all CSs are gone. However, the current logic does not really care about CS existence. It only remove EV under two conditions,
   1. isExternalViewDisabled == true
   2. The resource has been dropped
   
   So we should change the test logic accordingly.
   Though, according to the code logic, the test shall still pass since we drop the resource first. There might be a race condition that brings the EV back. Need more investigation on condition 2.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org