You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by JasonHao123 <gi...@git.apache.org> on 2018/12/02 13:56:12 UTC

[GitHub] ofbiz pull request #23: Release16.11

GitHub user JasonHao123 opened a pull request:

    https://github.com/apache/ofbiz/pull/23

    Release16.11

    Implemented session replication using redisson-tomcat, the main work include three items:
    1. set RedissonSessionManager in CatalinaContainer
    2. Make session attributes serializable
    3. so far didn't find solution to save delegator, dispatcher, security to session, just commented the code, tested from my side, it works fine.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/JasonHao123/ofbiz release16.11

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/ofbiz/pull/23.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #23
    
----
commit 35043f1a2fc59842300309d27215ee2ec0e451a1
Author: Hao, Yanfeng <ya...@...>
Date:   2018-12-02T13:46:26Z

    session replication using redis

commit 3b4d545e2cb4fcc4448bc8bebe40114e5d421ff7
Author: Hao, Yanfeng <ya...@...>
Date:   2018-12-02T13:51:45Z

    remove unnecessary comments

----


---

Re: [GitHub] ofbiz pull request #23: Release16.11

Posted by Deepak Dixit <de...@hotwax.co>.
I added a comment on the mentioned git pull request and asked user to
follow OFBiz Contributors Best Practices

Thanks & Regards
--
Deepak Dixit



On Sun, Dec 2, 2018 at 8:35 PM JasonHao123 <gi...@git.apache.org> wrote:

> GitHub user JasonHao123 opened a pull request:
>
>     https://github.com/apache/ofbiz/pull/23
>
>     Release16.11
>
>     Implemented session replication using redisson-tomcat, the main work
> include three items:
>     1. set RedissonSessionManager in CatalinaContainer
>     2. Make session attributes serializable
>     3. so far didn't find solution to save delegator, dispatcher, security
> to session, just commented the code, tested from my side, it works fine.
>
> You can merge this pull request into a Git repository by running:
>
>     $ git pull https://github.com/JasonHao123/ofbiz release16.11
>
> Alternatively you can review and apply these changes as the patch at:
>
>     https://github.com/apache/ofbiz/pull/23.patch
>
> To close this pull request, make a commit to your master/trunk branch
> with (at least) the following in the commit message:
>
>     This closes #23
>
> ----
> commit 35043f1a2fc59842300309d27215ee2ec0e451a1
> Author: Hao, Yanfeng <ya...@...>
> Date:   2018-12-02T13:46:26Z
>
>     session replication using redis
>
> commit 3b4d545e2cb4fcc4448bc8bebe40114e5d421ff7
> Author: Hao, Yanfeng <ya...@...>
> Date:   2018-12-02T13:51:45Z
>
>     remove unnecessary comments
>
> ----
>
>
> ---
>