[GitHub] harshp8l closed pull request #13427: Nit on string conversion for mxdoc.py

[GitBox <gi...@apache.org>]

harshp8l closed pull request #13427: Nit on string conversion for mxdoc.py
URL: https://github.com/apache/incubator-mxnet/pull/13427
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/docs/mxdoc.py b/docs/mxdoc.py
index 7be4b90e799..524a6a21c15 100644
--- a/docs/mxdoc.py
+++ b/docs/mxdoc.py
@@ -29,7 +29,7 @@
 from six.moves import configparser
 
 _BUILD_VER = os.getenv('BUILD_VER', 'default')
-print("Building version {}".format(_BUILD_VER))
+print(f'Building version {_BUILD_VER}')
 _DOC_SET = 'document_sets_' + _BUILD_VER
 
 parser = configparser.SafeConfigParser()
@@ -119,8 +119,7 @@ def build_scala_docs(app):
     ])
     # There are unresolvable errors on mxnet 1.2.x. We are ignoring those errors while aborting the ci on newer versions
     scala_ignore_errors = '; exit 0' if '1.2.' in _BUILD_VER else ''
-    _run_cmd('cd {}; scaladoc `{}` -classpath {} -feature -deprecation {}'
-             .format(scala_path, scala_doc_sources, scala_doc_classpath, scala_ignore_errors))
+    _run_cmd(f'cd {scala_path}; scaladoc `{scala_doc_sources}` -classpath {scala_doc_classpath} -feature -deprecation {scala_ignore_errors}')
     dest_path = app.builder.outdir + '/api/scala/docs'
     _run_cmd('rm -rf ' + dest_path)
     _run_cmd('mkdir -p ' + dest_path)
@@ -139,8 +138,7 @@ def build_java_docs(app):
         '`find core -name "*-SNAPSHOT.jar" | tr "\\n" ":" `',
         '`find infer -name "*-SNAPSHOT.jar" | tr "\\n" ":" `'
     ])
-    _run_cmd('cd {}; scaladoc `{}` -classpath {} -feature -deprecation'
-             .format(java_path, java_doc_sources, java_doc_classpath))
+    _run_cmd(f'cd {java_path}; scaladoc `{java_doc_sources}` -classpath {java_doc_classpath} -feature -deprecation')
     dest_path = app.builder.outdir + '/api/java/docs'
     _run_cmd('rm -rf ' + dest_path)
     _run_cmd('mkdir -p ' + dest_path)


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services