You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/04/10 18:11:33 UTC

[GitHub] [flink] ambition119 opened a new pull request #11704: [FLINK-17088] [runtime][web] Search TaskManager log content based on keywords function

ambition119 opened a new pull request #11704: [FLINK-17088] [runtime][web] Search TaskManager log content based on keywords function
URL: https://github.com/apache/flink/pull/11704
 
 
   ##  What is the purpose of the change
   Usually the taskmanager log file has a lot of content. There are several ways to search for content keywords:
   The first one: in browser ctrl + f
   The second type: use shell command operations on the server ip, such as grep -A
   The third kind: Log files are connected to Elasticsearch through Logstash / Filebeat
   
   These all increase the user's operation, which brings inconvenience, so the search function is developed to query the log content.
   
   ## Brief change log
     - *flink-runtime module add TaskManagerLogSearchInfoHandler class*
     - *web-dashboard change*
   
   ## Verifying this change
   
   1. Added tests in `TaskManagerLogSearchInfoHandlerTest`
   2. $ cd web-dashboard 
       $ npm run proxy 
   ![image](https://user-images.githubusercontent.com/20353043/79012388-c1822a00-7b98-11ea-82a6-a0bbffe7c6b4.png)
   
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (**yes** / no)
     - If yes, how is the feature documented? (not applicable / docs / **JavaDocs** / not documented)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11704: [FLINK-17088] [runtime][web] Search TaskManager log content based on keywords function

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11704: [FLINK-17088] [runtime][web] Search TaskManager log content based on keywords function
URL: https://github.com/apache/flink/pull/11704#issuecomment-612221335
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "733d9ef3444144358896e4a51a92bb677501a532",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7346",
       "triggerID" : "733d9ef3444144358896e4a51a92bb677501a532",
       "triggerType" : "PUSH"
     }, {
       "hash" : "733d9ef3444144358896e4a51a92bb677501a532",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159868653",
       "triggerID" : "733d9ef3444144358896e4a51a92bb677501a532",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d0618cceade6291fd73c7550fc32231803343d74",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "d0618cceade6291fd73c7550fc32231803343d74",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 733d9ef3444144358896e4a51a92bb677501a532 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/159868653) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7346) 
   * d0618cceade6291fd73c7550fc32231803343d74 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11704: [FLINK-17088] [runtime][web] Search TaskManager log content based on keywords function

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11704: [FLINK-17088] [runtime][web] Search TaskManager log content based on keywords function
URL: https://github.com/apache/flink/pull/11704#issuecomment-612221335
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "733d9ef3444144358896e4a51a92bb677501a532",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7346",
       "triggerID" : "733d9ef3444144358896e4a51a92bb677501a532",
       "triggerType" : "PUSH"
     }, {
       "hash" : "733d9ef3444144358896e4a51a92bb677501a532",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159868653",
       "triggerID" : "733d9ef3444144358896e4a51a92bb677501a532",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 733d9ef3444144358896e4a51a92bb677501a532 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/159868653) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7346) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #11704: [FLINK-17088] [runtime][web] Search TaskManager log content based on keywords function

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11704: [FLINK-17088] [runtime][web] Search TaskManager log content based on keywords function
URL: https://github.com/apache/flink/pull/11704#issuecomment-612221335
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "733d9ef3444144358896e4a51a92bb677501a532",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "733d9ef3444144358896e4a51a92bb677501a532",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 733d9ef3444144358896e4a51a92bb677501a532 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11704: [FLINK-17088] [runtime][web] Search TaskManager log content based on keywords function

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11704: [FLINK-17088] [runtime][web] Search TaskManager log content based on keywords function
URL: https://github.com/apache/flink/pull/11704#issuecomment-612221335
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "733d9ef3444144358896e4a51a92bb677501a532",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7346",
       "triggerID" : "733d9ef3444144358896e4a51a92bb677501a532",
       "triggerType" : "PUSH"
     }, {
       "hash" : "733d9ef3444144358896e4a51a92bb677501a532",
       "status" : "PENDING",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159868653",
       "triggerID" : "733d9ef3444144358896e4a51a92bb677501a532",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 733d9ef3444144358896e4a51a92bb677501a532 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/159868653) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7346) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #11704: [FLINK-17088] [runtime][web] Search TaskManager log content based on keywords function

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11704: [FLINK-17088] [runtime][web] Search TaskManager log content based on keywords function
URL: https://github.com/apache/flink/pull/11704#issuecomment-612152374
 
 
   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 733d9ef3444144358896e4a51a92bb677501a532 (Fri Apr 10 18:13:34 UTC 2020)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
    * **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-17088).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11704: [FLINK-17088] [runtime][web] Search TaskManager log content based on keywords function

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11704: [FLINK-17088] [runtime][web] Search TaskManager log content based on keywords function
URL: https://github.com/apache/flink/pull/11704#issuecomment-612221335
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "733d9ef3444144358896e4a51a92bb677501a532",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7346",
       "triggerID" : "733d9ef3444144358896e4a51a92bb677501a532",
       "triggerType" : "PUSH"
     }, {
       "hash" : "733d9ef3444144358896e4a51a92bb677501a532",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159868653",
       "triggerID" : "733d9ef3444144358896e4a51a92bb677501a532",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d0618cceade6291fd73c7550fc32231803343d74",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7362",
       "triggerID" : "d0618cceade6291fd73c7550fc32231803343d74",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d0618cceade6291fd73c7550fc32231803343d74",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159943368",
       "triggerID" : "d0618cceade6291fd73c7550fc32231803343d74",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * d0618cceade6291fd73c7550fc32231803343d74 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/159943368) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7362) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11704: [FLINK-17088] [runtime][web] Search TaskManager log content based on keywords function

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11704: [FLINK-17088] [runtime][web] Search TaskManager log content based on keywords function
URL: https://github.com/apache/flink/pull/11704#issuecomment-612221335
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "733d9ef3444144358896e4a51a92bb677501a532",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7346",
       "triggerID" : "733d9ef3444144358896e4a51a92bb677501a532",
       "triggerType" : "PUSH"
     }, {
       "hash" : "733d9ef3444144358896e4a51a92bb677501a532",
       "status" : "PENDING",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159868653",
       "triggerID" : "733d9ef3444144358896e4a51a92bb677501a532",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 733d9ef3444144358896e4a51a92bb677501a532 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/159868653) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7346) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11704: [FLINK-17088] [runtime][web] Search TaskManager log content based on keywords function

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11704: [FLINK-17088] [runtime][web] Search TaskManager log content based on keywords function
URL: https://github.com/apache/flink/pull/11704#issuecomment-612221335
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "733d9ef3444144358896e4a51a92bb677501a532",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7346",
       "triggerID" : "733d9ef3444144358896e4a51a92bb677501a532",
       "triggerType" : "PUSH"
     }, {
       "hash" : "733d9ef3444144358896e4a51a92bb677501a532",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159868653",
       "triggerID" : "733d9ef3444144358896e4a51a92bb677501a532",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d0618cceade6291fd73c7550fc32231803343d74",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7362",
       "triggerID" : "d0618cceade6291fd73c7550fc32231803343d74",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d0618cceade6291fd73c7550fc32231803343d74",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159943368",
       "triggerID" : "d0618cceade6291fd73c7550fc32231803343d74",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * d0618cceade6291fd73c7550fc32231803343d74 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/159943368) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7362) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] wuchong commented on issue #11704: [FLINK-17088] [runtime][web] Search TaskManager log content based on keywords function

Posted by GitBox <gi...@apache.org>.
wuchong commented on issue #11704: [FLINK-17088] [runtime][web] Search TaskManager log content based on keywords function
URL: https://github.com/apache/flink/pull/11704#issuecomment-612314773
 
 
   Hi @jinglining @GJL , could you help to review this PR? I'm not very familiar with this part. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11704: [FLINK-17088] [runtime][web] Search TaskManager log content based on keywords function

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11704: [FLINK-17088] [runtime][web] Search TaskManager log content based on keywords function
URL: https://github.com/apache/flink/pull/11704#issuecomment-612221335
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "733d9ef3444144358896e4a51a92bb677501a532",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7346",
       "triggerID" : "733d9ef3444144358896e4a51a92bb677501a532",
       "triggerType" : "PUSH"
     }, {
       "hash" : "733d9ef3444144358896e4a51a92bb677501a532",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159868653",
       "triggerID" : "733d9ef3444144358896e4a51a92bb677501a532",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d0618cceade6291fd73c7550fc32231803343d74",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7362",
       "triggerID" : "d0618cceade6291fd73c7550fc32231803343d74",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d0618cceade6291fd73c7550fc32231803343d74",
       "status" : "PENDING",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159943368",
       "triggerID" : "d0618cceade6291fd73c7550fc32231803343d74",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 733d9ef3444144358896e4a51a92bb677501a532 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/159868653) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7346) 
   * d0618cceade6291fd73c7550fc32231803343d74 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/159943368) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7362) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services