You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flink.apache.org by dw...@apache.org on 2019/05/23 06:48:59 UTC

[flink] branch master updated: [FLINK-12411][table-planner][tests] Workaround limited support of not nullable fields in window aggregation

This is an automated email from the ASF dual-hosted git repository.

dwysakowicz pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/flink.git


The following commit(s) were added to refs/heads/master by this push:
     new 7a3f081  [FLINK-12411][table-planner][tests] Workaround limited support of not nullable fields in window aggregation
7a3f081 is described below

commit 7a3f0813d15982177318c6c58cbe1d83799132e4
Author: Dawid Wysakowicz <dw...@apache.org>
AuthorDate: Mon May 6 09:06:35 2019 +0200

    [FLINK-12411][table-planner][tests] Workaround limited support of not nullable fields in window aggregation
    
    This does not fix the problem. It just makes the e2e test pass. For a
    proper fix of the underlying problem see FLINK-12249.
---
 .../main/java/org/apache/flink/sql/tests/StreamSQLTestProgram.java    | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/flink-end-to-end-tests/flink-stream-sql-test/src/main/java/org/apache/flink/sql/tests/StreamSQLTestProgram.java b/flink-end-to-end-tests/flink-stream-sql-test/src/main/java/org/apache/flink/sql/tests/StreamSQLTestProgram.java
index 47bca8e..cde040d 100644
--- a/flink-end-to-end-tests/flink-stream-sql-test/src/main/java/org/apache/flink/sql/tests/StreamSQLTestProgram.java
+++ b/flink-end-to-end-tests/flink-stream-sql-test/src/main/java/org/apache/flink/sql/tests/StreamSQLTestProgram.java
@@ -106,7 +106,9 @@ public class StreamSQLTestProgram {
 		String tumbleQuery = String.format(
 			"SELECT " +
 			"  key, " +
-			"  CASE SUM(cnt) / COUNT(*) WHEN 101 THEN 1 ELSE 99 END AS correct, " +
+			//TODO: The "WHEN -1 THEN NULL" part is a temporary workaround, to make the test pass, for
+			// https://issues.apache.org/jira/browse/FLINK-12249. We should remove it once the issue is fixed.
+			"  CASE SUM(cnt) / COUNT(*) WHEN 101 THEN 1 WHEN -1 THEN NULL ELSE 99 END AS correct, " +
 			"  TUMBLE_START(rowtime, INTERVAL '%d' SECOND) AS wStart, " +
 			"  TUMBLE_ROWTIME(rowtime, INTERVAL '%d' SECOND) AS rowtime " +
 			"FROM (%s) " +