You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mesos.apache.org by mp...@apache.org on 2016/12/21 04:46:02 UTC
mesos git commit: Made headers in stout standalone.
Repository: mesos
Updated Branches:
refs/heads/master 5b5c4d121 -> d21173623
Made headers in stout standalone.
Missing includes were found by attempting to parse the header files
standalone with
$ clang++ -fsyntax-only -I .... HEADER_FILE.hpp
By fixing failures we can make sure that all required symbols are
defined.
Note this change does not address the issue of transitive includes.
Review: https://reviews.apache.org/r/54083/
Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/d2117362
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/d2117362
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/d2117362
Branch: refs/heads/master
Commit: d2117362349ab4c383045720f77d42b2d9fd6871
Parents: 5b5c4d1
Author: Benjamin Bannier <be...@mesosphere.io>
Authored: Tue Dec 20 22:14:15 2016 -0500
Committer: Michael Park <mp...@apache.org>
Committed: Tue Dec 20 22:15:20 2016 -0500
----------------------------------------------------------------------
3rdparty/stout/include/stout/os.hpp | 1 +
3rdparty/stout/include/stout/os/osx.hpp | 1 +
3rdparty/stout/include/stout/os/permissions.hpp | 3 +++
3rdparty/stout/include/stout/os/posix/socket.hpp | 1 +
3rdparty/stout/include/stout/os/posix/su.hpp | 5 +++--
3rdparty/stout/include/stout/os/posix/xattr.hpp | 6 ++++++
6 files changed, 15 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/mesos/blob/d2117362/3rdparty/stout/include/stout/os.hpp
----------------------------------------------------------------------
diff --git a/3rdparty/stout/include/stout/os.hpp b/3rdparty/stout/include/stout/os.hpp
index 63265ee..ed6fec3 100644
--- a/3rdparty/stout/include/stout/os.hpp
+++ b/3rdparty/stout/include/stout/os.hpp
@@ -54,6 +54,7 @@
#include <stout/os/mkdir.hpp>
#include <stout/os/mkdtemp.hpp>
#include <stout/os/mktemp.hpp>
+#include <stout/os/os.hpp>
#include <stout/os/pagesize.hpp>
#include <stout/os/process.hpp>
#include <stout/os/rename.hpp>
http://git-wip-us.apache.org/repos/asf/mesos/blob/d2117362/3rdparty/stout/include/stout/os/osx.hpp
----------------------------------------------------------------------
diff --git a/3rdparty/stout/include/stout/os/osx.hpp b/3rdparty/stout/include/stout/os/osx.hpp
index 770c85d..504af3e 100644
--- a/3rdparty/stout/include/stout/os/osx.hpp
+++ b/3rdparty/stout/include/stout/os/osx.hpp
@@ -32,6 +32,7 @@
#include <stout/none.hpp>
#include <stout/strings.hpp>
+#include <stout/os/os.hpp>
#include <stout/os/pagesize.hpp>
#include <stout/os/process.hpp>
#include <stout/os/sysctl.hpp>
http://git-wip-us.apache.org/repos/asf/mesos/blob/d2117362/3rdparty/stout/include/stout/os/permissions.hpp
----------------------------------------------------------------------
diff --git a/3rdparty/stout/include/stout/os/permissions.hpp b/3rdparty/stout/include/stout/os/permissions.hpp
index 1fa7614..453e60c 100644
--- a/3rdparty/stout/include/stout/os/permissions.hpp
+++ b/3rdparty/stout/include/stout/os/permissions.hpp
@@ -17,6 +17,9 @@
#include <string>
+#include <stout/error.hpp>
+#include <stout/try.hpp>
+
namespace os {
http://git-wip-us.apache.org/repos/asf/mesos/blob/d2117362/3rdparty/stout/include/stout/os/posix/socket.hpp
----------------------------------------------------------------------
diff --git a/3rdparty/stout/include/stout/os/posix/socket.hpp b/3rdparty/stout/include/stout/os/posix/socket.hpp
index 836e4b3..041f000 100644
--- a/3rdparty/stout/include/stout/os/posix/socket.hpp
+++ b/3rdparty/stout/include/stout/os/posix/socket.hpp
@@ -13,6 +13,7 @@
#ifndef __STOUT_OS_POSIX_SOCKET_HPP__
#define __STOUT_OS_POSIX_SOCKET_HPP__
+#include <errno.h>
#include <unistd.h>
#include <sys/socket.h>
http://git-wip-us.apache.org/repos/asf/mesos/blob/d2117362/3rdparty/stout/include/stout/os/posix/su.hpp
----------------------------------------------------------------------
diff --git a/3rdparty/stout/include/stout/os/posix/su.hpp b/3rdparty/stout/include/stout/os/posix/su.hpp
index c3ce87e..f3f45eb 100644
--- a/3rdparty/stout/include/stout/os/posix/su.hpp
+++ b/3rdparty/stout/include/stout/os/posix/su.hpp
@@ -17,8 +17,6 @@
#ifndef __STOUT_OS_POSIX_SU_HPP__
#define __STOUT_OS_POSIX_SU_HPP__
-#include <string>
-
#include <errno.h>
#include <grp.h>
#include <limits.h>
@@ -27,6 +25,9 @@
#include <sys/syscall.h>
+#include <string>
+#include <vector>
+
#include <stout/error.hpp>
#include <stout/none.hpp>
#include <stout/nothing.hpp>
http://git-wip-us.apache.org/repos/asf/mesos/blob/d2117362/3rdparty/stout/include/stout/os/posix/xattr.hpp
----------------------------------------------------------------------
diff --git a/3rdparty/stout/include/stout/os/posix/xattr.hpp b/3rdparty/stout/include/stout/os/posix/xattr.hpp
index 56f7308..6913c15 100644
--- a/3rdparty/stout/include/stout/os/posix/xattr.hpp
+++ b/3rdparty/stout/include/stout/os/posix/xattr.hpp
@@ -20,6 +20,12 @@
#include <sys/xattr.h>
#endif
+#include <string>
+
+#include <stout/error.hpp>
+#include <stout/nothing.hpp>
+#include <stout/try.hpp>
+
namespace os {
inline Try<Nothing> setxattr(